Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp4470800ybz; Tue, 21 Apr 2020 00:57:05 -0700 (PDT) X-Google-Smtp-Source: APiQypL0JuLA3RMVoVRCSYjAKsv0aC6S6j9gkKPkCcjYVU+ZkPilCAfYoeopZo9z4IMr5V6eVUfW X-Received: by 2002:aa7:d78b:: with SMTP id s11mr18151674edq.226.1587455825810; Tue, 21 Apr 2020 00:57:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1587455825; cv=none; d=google.com; s=arc-20160816; b=wx0evKA+mwDIguIY+m2Dhcf/iagIu2pStVjZrkGyUAGRyguulg0/sV4SZ1guU6Fzvl XNt3iz0dz06CStBREz2CGdLfnpq6/1fz28iTW9mAaJSr7InPJbgA31mU4+EJCBo2gEaS +mixxeCNEwRikwxcjCpOk8CM2BwAM6FPAnAI46AyIQMCmnbOUxW3CkDRsve+rCTDAIKS +Rg52F8BK8j6r3+cSgmIcKOuIqoyrUFQ607S2BEX//fTiFTdyXTLRH2yTVUJYxY9FUVN WhNjwHlMXO4ha3USa/kBpaMzI6JpW4tCTjlFmsS+z7DfLppP7Kl8XBcxnycvB5i4ihZX f+XQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=Ei5sgLot33BM0x+A9zMBgo0Lj1B2UEEl+JFi/GhUUck=; b=BbV0lvRY0VJz9CWi0GkW/ydcPief1oq7O5V7UpUIMlaJNyY6+zxzHln7uusr6LpPsS C90S0hl53dhk1yC57ZPVSn/jweb9FpaIAyoJRYhkJiCFle1ikwwHihiBfQqKFXvU66aT TZ3r/wBfr6TQi4hUkaZqAPGkV7OMWnCOzgPfUBxE/Dyere+Io2EOLWUOzzudYQOkI7uJ qAG73cm15IMew7lemIxKhaCVXdobnwz7e717axc7o1x6O5k7x8G3TNyNgs5y5aOAnd4+ KUDHFhkA0FluF6zEbdGniSIg9TFOXoOMycn3kRDrATsFt9dBfKum/td2OAC3za46leCe uFPQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id dd5si1220697edb.34.2020.04.21.00.56.42; Tue, 21 Apr 2020 00:57:05 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728214AbgDUHzi (ORCPT + 99 others); Tue, 21 Apr 2020 03:55:38 -0400 Received: from verein.lst.de ([213.95.11.211]:45190 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725992AbgDUHzi (ORCPT ); Tue, 21 Apr 2020 03:55:38 -0400 Received: by verein.lst.de (Postfix, from userid 2407) id 58CB668C4E; Tue, 21 Apr 2020 09:55:34 +0200 (CEST) Date: Tue, 21 Apr 2020 09:55:34 +0200 From: Christoph Hellwig To: Matthew Wilcox Cc: Andrey Ignatov , Christoph Hellwig , Kees Cook , Iurii Zaikin , Luis Chamberlain , Greg Kroah-Hartman , "Rafael J. Wysocki" , Alexei Starovoitov , Daniel Borkmann , linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, netdev@vger.kernel.org, bpf@vger.kernel.org Subject: Re: [PATCH 6/6] sysctl: pass kernel pointers to ->proc_handler Message-ID: <20200421075534.GC15772@lst.de> References: <20200417064146.1086644-1-hch@lst.de> <20200417064146.1086644-7-hch@lst.de> <20200417193910.GA7011@rdna-mbp> <20200417195015.GO5820@bombadil.infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200417195015.GO5820@bombadil.infradead.org> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Apr 17, 2020 at 12:50:15PM -0700, Matthew Wilcox wrote: > > cur_val is allocated separately below to read current value of sysctl > > and not interfere with user-passed buffer. Ok, I'll fix this up.