Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org DC36CC433CB
Subject: Re: [PATCH] arm64: dts: qcom: sm8250: Fix PDC compatible and reg
To:     Vinod Koul <vkoul@kernel.org>,
        Bjorn Andersson <bjorn.andersson@linaro.org>
Cc:     Andy Gross <agross@kernel.org>,
        Venkata Narendra Kumar Gutta <vnkgutta@codeaurora.org>,
        Rob Herring <robh+dt@kernel.org>,
        linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20200415054703.739507-1-bjorn.andersson@linaro.org>
 <20200421070227.GD72691@vkoul-mobl>
From:   Maulik Shah <mkshah@codeaurora.org>
Message-ID: <d67adcc2-7f5c-3ed7-5c7c-c3b6b46cbd0b@codeaurora.org>
Date:   Tue, 21 Apr 2020 13:40:17 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101
 Thunderbird/68.7.0
MIME-Version: 1.0
In-Reply-To: <20200421070227.GD72691@vkoul-mobl>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-GB
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi,

We can drop the second reg,
, <0 0x17c000f0 0 0x60>

The change [1] to read second reg and configure it, is not yet gone in 
pdc irqchip driver.
Otherthan this, the patch looks good to me.

Thanks,
Maulik

On 4/21/2020 12:32 PM, Vinod Koul wrote:
> On 14-04-20, 22:47, Bjorn Andersson wrote:
>> The pdc node suffers from both too narrow compatible and insufficient
>> cells in the reg, fix these.
> Reviewed-by: Vinod Koul <vkoul@kernel.org>
> Tested-by: Vinod Koul <vkoul@kernel.org>
>
>> Fixes: 60378f1a171e ("arm64: dts: qcom: sm8250: Add sm8250 dts file")
>> Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
>> ---
>>   arch/arm64/boot/dts/qcom/sm8250.dtsi | 4 ++--
>>   1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/sm8250.dtsi b/arch/arm64/boot/dts/qcom/sm8250.dtsi
>> index 891d83b2afea..2a7eaefd221d 100644
>> --- a/arch/arm64/boot/dts/qcom/sm8250.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/sm8250.dtsi
>> @@ -314,8 +314,8 @@ intc: interrupt-controller@17a00000 {
>>   		};
>>   
>>   		pdc: interrupt-controller@b220000 {
>> -			compatible = "qcom,sm8250-pdc";
>> -			reg = <0x0b220000 0x30000>, <0x17c000f0 0x60>;
>> +			compatible = "qcom,sm8250-pdc", "qcom,pdc";
>> +			reg = <0 0x0b220000 0 0x30000>, <0 0x17c000f0 0 0x60>;
>>   			qcom,pdc-ranges = <0 480 94>, <94 609 31>,
>>   					  <125 63 1>, <126 716 12>;
>>   			#interrupt-cells = <2>;
>> -- 
>> 2.24.0
[1] https://patchwork.kernel.org/patch/11145353/

-- 
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation