Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp4497867ybz; Tue, 21 Apr 2020 01:32:07 -0700 (PDT) X-Google-Smtp-Source: APiQypIFbq3F4S7FvyzXIt/03Tih/g+sSv5+J8UFYoUVq9t9C0pQC+Bsk2D5UKlf+Lx+JA5jPFk+ X-Received: by 2002:aa7:c497:: with SMTP id m23mr17399480edq.155.1587457927222; Tue, 21 Apr 2020 01:32:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1587457927; cv=none; d=google.com; s=arc-20160816; b=PpttGktsG6LOAqifyPfR6UwQ1rTfGLM2ooarg2K5O9cGbyliHq/cv8ns1Ntc2ADAIX cLUbKPwUIkEr1FHWyxZHWmzYDEIEYqd6M3ot3psAdEZeOSqmJdOGFtOX2EIP47g+sWta SyhuLAPeFWp04/xibDi7Zjqr8cauCo0sN1ac2bS5CmZX+RE3qKg05rbTjPheJDrjwYwy YRvvWTXIU+S/jodSDq5Diq07mwp/yevJxjCVFR8TEQFre6101sL4yqFZHi/GlrfNzV4b BTvfCJH3A7OKGDMdVYnOZNpeL75ga0QMbvOO3TfD8zlocB1imKPUMZBpnUHcwDJQ1yLh FwxA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from; bh=U+TC/xh1odMOYFrJFZf+7fy8kP6ke7CmUBNP6Xp+488=; b=EoS6VXenJasmC/1boTkMXsjV28+KbeGCf9gjDvTMXLzQYJiwiZ9VK5a8oSSb24y2kp Cj05nj1IzgqTRpT5CqXntwylY/OQQXplVS4oNW9bwTqcDCoMYACIWgb59W6jmy/W+6kH M2Mz555xIOZp4EcBC/G+MEnNaROYaDa8lAyFhKNdb6KBWT9Ik1F5w7z/BBqBCc4nBmMh SDRuGA0YauzG/2jnEG+pOUcNeL2kMSWwLoh5r2SmE6xQZSysrpcsW2RLaiZEoqfDTQmY l9M7AaFlUiC+oPrvqEMKXy7POVDgVUspBHBm/qStST53yoA/c+Pwg51lMiusjgtoiNR/ 0p3A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id n62si1156466edc.8.2020.04.21.01.31.44; Tue, 21 Apr 2020 01:32:07 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728436AbgDUIa1 (ORCPT + 99 others); Tue, 21 Apr 2020 04:30:27 -0400 Received: from mx2.suse.de ([195.135.220.15]:56244 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726095AbgDUIa0 (ORCPT ); Tue, 21 Apr 2020 04:30:26 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id BB346AD2C; Tue, 21 Apr 2020 08:30:23 +0000 (UTC) From: Mian Yousaf Kaukab To: linux-pm@vger.kernel.org, andy.tang@nxp.com, sboyd@kernel.org, linux-clk@vger.kernel.org, rjw@rjwysocki.net, shawnguo@kernel.org, leoyang.li@nxp.com Cc: viresh.kumar@linaro.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, Mian Yousaf Kaukab Subject: [PATCH v2 1/2] cpufreq: qoriq: convert to a platform driver Date: Tue, 21 Apr 2020 10:29:59 +0200 Message-Id: <20200421083000.16740-1-ykaukab@suse.de> X-Mailer: git-send-email 2.16.4 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The driver has to be manually loaded if it is built as a module. It is neither exporting MODULE_DEVICE_TABLE nor MODULE_ALIAS. Moreover, no platform-device is created (and thus no uevent is sent) for the clockgen nodes it depends on. Convert the module to a platform driver with its own alias. Moreover, drop whitelisted SOCs. Platform device will be created only for the compatible platforms. Reviewed-by: Yuantian Tang Acked-by: Viresh Kumar Signed-off-by: Mian Yousaf Kaukab --- v2: +Rafael, Stephen, linux-clk Add Reviewed-by and Acked-by tags drivers/cpufreq/qoriq-cpufreq.c | 76 ++++++++++++++++------------------------- 1 file changed, 29 insertions(+), 47 deletions(-) diff --git a/drivers/cpufreq/qoriq-cpufreq.c b/drivers/cpufreq/qoriq-cpufreq.c index 8e436dc75c8b..6b6b20da2bcf 100644 --- a/drivers/cpufreq/qoriq-cpufreq.c +++ b/drivers/cpufreq/qoriq-cpufreq.c @@ -18,6 +18,7 @@ #include #include #include +#include /** * struct cpu_data @@ -29,12 +30,6 @@ struct cpu_data { struct cpufreq_frequency_table *table; }; -/* - * Don't use cpufreq on this SoC -- used when the SoC would have otherwise - * matched a more generic compatible. - */ -#define SOC_BLACKLIST 1 - /** * struct soc_data - SoC specific data * @flags: SOC_xxx @@ -264,64 +259,51 @@ static struct cpufreq_driver qoriq_cpufreq_driver = { .attr = cpufreq_generic_attr, }; -static const struct soc_data blacklist = { - .flags = SOC_BLACKLIST, -}; - -static const struct of_device_id node_matches[] __initconst = { +static const struct of_device_id qoriq_cpufreq_blacklist[] = { /* e6500 cannot use cpufreq due to erratum A-008083 */ - { .compatible = "fsl,b4420-clockgen", &blacklist }, - { .compatible = "fsl,b4860-clockgen", &blacklist }, - { .compatible = "fsl,t2080-clockgen", &blacklist }, - { .compatible = "fsl,t4240-clockgen", &blacklist }, - - { .compatible = "fsl,ls1012a-clockgen", }, - { .compatible = "fsl,ls1021a-clockgen", }, - { .compatible = "fsl,ls1028a-clockgen", }, - { .compatible = "fsl,ls1043a-clockgen", }, - { .compatible = "fsl,ls1046a-clockgen", }, - { .compatible = "fsl,ls1088a-clockgen", }, - { .compatible = "fsl,ls2080a-clockgen", }, - { .compatible = "fsl,lx2160a-clockgen", }, - { .compatible = "fsl,p4080-clockgen", }, - { .compatible = "fsl,qoriq-clockgen-1.0", }, - { .compatible = "fsl,qoriq-clockgen-2.0", }, + { .compatible = "fsl,b4420-clockgen", }, + { .compatible = "fsl,b4860-clockgen", }, + { .compatible = "fsl,t2080-clockgen", }, + { .compatible = "fsl,t4240-clockgen", }, {} }; -static int __init qoriq_cpufreq_init(void) +static int qoriq_cpufreq_probe(struct platform_device *pdev) { int ret; - struct device_node *np; - const struct of_device_id *match; - const struct soc_data *data; - - np = of_find_matching_node(NULL, node_matches); - if (!np) - return -ENODEV; - - match = of_match_node(node_matches, np); - data = match->data; - - of_node_put(np); + struct device_node *np; - if (data && data->flags & SOC_BLACKLIST) + np = of_find_matching_node(NULL, qoriq_cpufreq_blacklist); + if (np) { + dev_info(&pdev->dev, "Disabling due to erratum A-008083"); return -ENODEV; + } ret = cpufreq_register_driver(&qoriq_cpufreq_driver); - if (!ret) - pr_info("Freescale QorIQ CPU frequency scaling driver\n"); + if (ret) + return ret; - return ret; + dev_info(&pdev->dev, "Freescale QorIQ CPU frequency scaling driver\n"); + return 0; } -module_init(qoriq_cpufreq_init); -static void __exit qoriq_cpufreq_exit(void) +static int qoriq_cpufreq_remove(struct platform_device *pdev) { cpufreq_unregister_driver(&qoriq_cpufreq_driver); + + return 0; } -module_exit(qoriq_cpufreq_exit); +static struct platform_driver qoriq_cpufreq_platform_driver = { + .driver = { + .name = "qoriq-cpufreq", + }, + .probe = qoriq_cpufreq_probe, + .remove = qoriq_cpufreq_remove, +}; +module_platform_driver(qoriq_cpufreq_platform_driver); + +MODULE_ALIAS("platform:qoriq-cpufreq"); MODULE_LICENSE("GPL"); MODULE_AUTHOR("Tang Yuantian "); MODULE_DESCRIPTION("cpufreq driver for Freescale QorIQ series SoCs"); -- 2.16.4