Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20200416181944.5879-1-jbx6244@gmail.com> <CAGb2v67N6t+C8dVKdjuOv1NzD9=3-n0GZQkshy1Pm6PFPJ87dQ@mail.gmail.com>
 <2710874.PL6qFFFsBp@diego>
In-Reply-To: <2710874.PL6qFFFsBp@diego>
From:   Chen-Yu Tsai <wens@kernel.org>
Date:   Tue, 21 Apr 2020 16:29:49 +0800
Message-ID: <CAGb2v67vV2Bxff5Gj1R8Qx3Cj+nzA5ine12hoXbhGP5Z+S7=UA@mail.gmail.com>
Subject: Re: [PATCH 1/3] arm64: dts: rockchip: add bus-width properties to mmc
 nodes for rk3328.dtsi
To:     =?UTF-8?Q?Heiko_St=C3=BCbner?= <heiko@sntech.de>
Cc:     Chen-Yu Tsai <wens@kernel.org>, Johan Jonker <jbx6244@gmail.com>,
        devicetree <devicetree@vger.kernel.org>,
        Rob Herring <robh+dt@kernel.org>,
        linux-kernel <linux-kernel@vger.kernel.org>,
        linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
        "open list:ARM/Rockchip SoC..." <linux-rockchip@lists.infradead.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue, Apr 21, 2020 at 4:23 PM Heiko St=C3=BCbner <heiko@sntech.de> wrote:
>
> Hi ChenYu,
>
> Am Dienstag, 21. April 2020, 05:48:52 CEST schrieb Chen-Yu Tsai:
> > On Fri, Apr 17, 2020 at 2:19 AM Johan Jonker <jbx6244@gmail.com> wrote:
> > >
> > > 'bus-width' and pinctrl containing the bus-pins
> > > should be in the same file, so add them to
> > > all mmc nodes in 'rk3328.dtsi'.
> >
> > Nope. First of all, pinctrl usage is with pinctrl-N properties, not the
> > pinctrl device, and there are no defaults set for any of the mmc nodes.
> > Second, these are board design specific. For example, boards are free t=
o
> > use just 4 bits for the eMMC if they so desire. So this should be in ea=
ch
> > board dts file. If a board is missing this property, fix the board.
>
> you are correct that the pinctrl entries are missing from the patches,
> bus-width and pinctrl should be defined in the same file each time,
> but for the whole idea I tend to disagree.
>
> So far every board with a Rockchip socs follows Rockchip's reference desi=
gn
> for a lot of parts - for example I only see sdmmc nodes with bus-width=3D=
4
> etc.
>
> So the basic idea is to have default pinctrl settings for the settings
> everybody uses predefined ... if a board comes along that needs different
> settings it is free to redefine that.

I think having a default is a great idea. :)

ChenYu