Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp4512858ybz; Tue, 21 Apr 2020 01:53:30 -0700 (PDT) X-Google-Smtp-Source: APiQypJYrTwtYWbIlC9ndg67jo6iULzwp+tMN9iQQhqD6+PR1ddI4BaL9Sep4QZ2TeIhG9qXF5yD X-Received: by 2002:a17:906:af59:: with SMTP id ly25mr20080282ejb.65.1587459210487; Tue, 21 Apr 2020 01:53:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1587459210; cv=none; d=google.com; s=arc-20160816; b=dSD9S5R7aLub1HLEty8jcHC+QWYtz/SHks7KKqN0uLNEKpVz7VJTKVRLMPnzp2dIzo /vevrBL0mhpYG5Z60xpqemrEUvDkLBJSqaUWQS8kkLqRWmiQPtQeMKOXWa34b5d4ABaO kA5iuqXGKgCYlwo82SskQQo/9IPNnEIKirTe4GaqPtmUVszIET8glQ2BIRfkJGgE5QZV Uk1aEbmXvFdzTDC8xNetkOraMHIpVLrI2Ccnq76QmzIHlHDROL2WkyaA3h3XAvtdkbjn rfy/6IVM6vFfIcb8blr6/H+2Xjg262ULWopYsMgIXlWhETyO6U+BuzmGinTB9htPeRXu 0IbQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from; bh=0PasCMxzosuQhHVQZsGBpdpK/DKGZ5BN3eEaFR9vUDE=; b=A51yqsTIHi5oZFKlmYiaIkVskRcgs5nHypm6va8MviIyMDpbLYYkq+tzd1PoIH485D aUk3y32/+rK/ZnRY939tXoWf06dqHzOvBX2byBoj9xuKoD6mVdo2NvxDE5g0OK1UzrAm XWwGtR5+eBawP6M9mceIeIAY6IoTVZ5QdgT/8O54vRi3qBNtTVZ2efAY5QOtEjytkBlQ 9ju9F6OXorriH+GC5zPp6jT/Aqbgvps6wN12qha944Y33VXf/oFMskYh+2vbl1u1BE4u S1wYGZ/cAU9cFupPO+4r2FG8OrthLAG0/FktYttHgCyRYB78XC7Vn8XEoiQhAp8pEXbd GWFA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nxp.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id bm22si1117221edb.522.2020.04.21.01.53.08; Tue, 21 Apr 2020 01:53:30 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nxp.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727043AbgDUItx (ORCPT + 99 others); Tue, 21 Apr 2020 04:49:53 -0400 Received: from inva020.nxp.com ([92.121.34.13]:39700 "EHLO inva020.nxp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726052AbgDUItx (ORCPT ); Tue, 21 Apr 2020 04:49:53 -0400 Received: from inva020.nxp.com (localhost [127.0.0.1]) by inva020.eu-rdc02.nxp.com (Postfix) with ESMTP id 6C8DF1A0C15; Tue, 21 Apr 2020 10:49:51 +0200 (CEST) Received: from invc005.ap-rdc01.nxp.com (invc005.ap-rdc01.nxp.com [165.114.16.14]) by inva020.eu-rdc02.nxp.com (Postfix) with ESMTP id 582C61A0C34; Tue, 21 Apr 2020 10:49:46 +0200 (CEST) Received: from localhost.localdomain (shlinux2.ap.freescale.net [10.192.224.44]) by invc005.ap-rdc01.nxp.com (Postfix) with ESMTP id 3CA4F4029E; Tue, 21 Apr 2020 16:49:40 +0800 (SGT) From: Shengjiu Wang To: timur@kernel.org, nicoleotsuka@gmail.com, Xiubo.Lee@gmail.com, festevam@gmail.com, broonie@kernel.org, perex@perex.cz, tiwai@suse.com, alsa-devel@alsa-project.org Cc: linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: [PATCH] ASoC: fsl_esai: Remove expensive print in irq handler Date: Tue, 21 Apr 2020 16:41:23 +0800 Message-Id: <1587458483-2166-1-git-send-email-shengjiu.wang@nxp.com> X-Mailer: git-send-email 2.7.4 X-Virus-Scanned: ClamAV using ClamSMTP Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Use dev_dbg instead of dev_err in irq handler, the dev_err is expensive, we don't need the message to be printed everytime, which is almost a debug option. Signed-off-by: Shengjiu Wang --- sound/soc/fsl/fsl_esai.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sound/soc/fsl/fsl_esai.c b/sound/soc/fsl/fsl_esai.c index c7a49d03463a..453392a9cd68 100644 --- a/sound/soc/fsl/fsl_esai.c +++ b/sound/soc/fsl/fsl_esai.c @@ -94,10 +94,10 @@ static irqreturn_t esai_isr(int irq, void *devid) dev_dbg(&pdev->dev, "isr: Transmission Initialized\n"); if (esr & ESAI_ESR_RFF_MASK) - dev_warn(&pdev->dev, "isr: Receiving overrun\n"); + dev_dbg(&pdev->dev, "isr: Receiving overrun\n"); if (esr & ESAI_ESR_TFE_MASK) - dev_warn(&pdev->dev, "isr: Transmission underrun\n"); + dev_dbg(&pdev->dev, "isr: Transmission underrun\n"); if (esr & ESAI_ESR_TLS_MASK) dev_dbg(&pdev->dev, "isr: Just transmitted the last slot\n"); -- 2.21.0