Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 21 Apr 2020 10:51:40 +0100
From:   Mark Brown <broonie@kernel.org>
To:     Shengjiu Wang <shengjiu.wang@nxp.com>
Cc:     timur@kernel.org, nicoleotsuka@gmail.com, Xiubo.Lee@gmail.com,
        festevam@gmail.com, perex@perex.cz, tiwai@suse.com,
        alsa-devel@alsa-project.org, linuxppc-dev@lists.ozlabs.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ASoC: fsl_esai: Remove expensive print in irq handler
Message-ID: <20200421095139.GA4540@sirena.org.uk>
References: <1587458483-2166-1-git-send-email-shengjiu.wang@nxp.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="SLDf9lqlvOQaIe6s"
Content-Disposition: inline
In-Reply-To: <1587458483-2166-1-git-send-email-shengjiu.wang@nxp.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


--SLDf9lqlvOQaIe6s
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Apr 21, 2020 at 04:41:23PM +0800, Shengjiu Wang wrote:
> Use dev_dbg instead of dev_err in irq handler, the dev_err
> is expensive, we don't need the message to be printed everytime,
> which is almost a debug option.

>  	if (esr & ESAI_ESR_RFF_MASK)
> -		dev_warn(&pdev->dev, "isr: Receiving overrun\n");
> +		dev_dbg(&pdev->dev, "isr: Receiving overrun\n");
> =20
>  	if (esr & ESAI_ESR_TFE_MASK)
> -		dev_warn(&pdev->dev, "isr: Transmission underrun\n");
> +		dev_dbg(&pdev->dev, "isr: Transmission underrun\n");

These are error messages which would suggest a problem that'd lead to
data corruption, it seems bad not to try to flag that to the user -
surely we've got bigger problems than performance if this happens?
Perhaps convert to a ratelimited print if the issue is that when errors
happen they happen a lot?

--SLDf9lqlvOQaIe6s
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl6ewiMACgkQJNaLcl1U
h9CKwwf/Tpe5//zRDnlqtVpZt3Oxy35CTdjomxN1dhZTt7hBudQjOITkDCoiNst3
SEvHAoPl0m/Y5PyAiZGgZlxFxttzFt7kPUskvTeDXWhmWRWjErukhTFBAbsA/xZM
AlHWU436vHLDv7G769/c+foQJxQQAnfiCmS2BOK/4K18HIMLgz+C6e78zEXkFPsX
rkvU9CKIZYUwgNB/YJ00JHWTy99JeURMB9IhF5vz9u+rKO7fflOjF+o/XMsxHsVw
YHYxXyu35bWT21LslOL2gsB5NWI6MIzRXOirDJKY3wHhzspdL3NkMOg0QFb3pSs0
ZHl2Tbk2fhTu7Aebf9LPYn11mmwaWA==
=YObh
-----END PGP SIGNATURE-----

--SLDf9lqlvOQaIe6s--