Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp13290ybz; Tue, 21 Apr 2020 03:47:11 -0700 (PDT) X-Google-Smtp-Source: APiQypKKI/7TVXKtEG7lM8QdbkH3Km0g56VKJXQoAIoDY5GBfpChSLYxpf2sfKgsZWHbNLssHY0j X-Received: by 2002:a17:906:a2d3:: with SMTP id by19mr20871789ejb.370.1587466030897; Tue, 21 Apr 2020 03:47:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1587466030; cv=none; d=google.com; s=arc-20160816; b=nC4N7ZcwyVpKkvBl9FzywtzR0VmUz5HZByquIKgIHYJZ8NnZv10sYDcyEEXsu8LQxD CEQBKrgDUrnPaj20z2CRMIbwdbji1l/zxaYMWnKMBtfpjDnpPO8j0P69i8JCpBL0bYy0 ei5jPkwJmYeuThMgz17MlLEP2ko5R59Lqhuzz0YPyYEh5FT+fmheuNICsk44KAzuOQ/Q 6xcr+9aSA8XjIe2sWh05rJO2Zj76Mu7XcjhfQBrCHGKrk3ouufUYWdE9rvL87xqzRCA8 KecADjuCdFIPTg+6whDXrHEs6SOmPhc5U8R8fOocCw3R1JgDeU5Tf2trjsbdJGGWJo6I YqDQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date:autocrypt :from:references:cc:to:subject; bh=AjaoHDrYMdq9LI3cVt6WUQCf+fLZp6UDnAFhqfiK7nI=; b=GDuNYK4XmfnAn/d4uLCUYgP5B8UWKWuAblBsTFkF9WYPJyej7uywhca3T6CKrcxoJZ yxR55bAyjTELcOAC4Ve4kEHx3pYPTbKbCNScOWFUWyx9VIZcJamGFeK7DCVabcU/1Rje 1KWhmyYUq1EsFD/RN2n0HOvtyImUywSBbPtKOnjpr0vY7E2+JT4BLcSOYoQSEFyPpg+V AbSkjQRZTcloAOId1beB+cQzG5fdDHtz2X21Xz22/Fqga5TdHXMNRr720eXKeb2gLWWl 6PtB4ywkgY/83EM7AFWjcgkc+DouBdz++uf2Dodts5QisrvksNMQ6GsyKTUhpwg/e7z2 60oA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id w7si980531edr.309.2020.04.21.03.46.47; Tue, 21 Apr 2020 03:47:10 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728551AbgDUKnN (ORCPT + 99 others); Tue, 21 Apr 2020 06:43:13 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:31968 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728480AbgDUKnM (ORCPT ); Tue, 21 Apr 2020 06:43:12 -0400 Received: from pps.filterd (m0098404.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 03LAVxbu144167 for ; Tue, 21 Apr 2020 06:43:12 -0400 Received: from e06smtp03.uk.ibm.com (e06smtp03.uk.ibm.com [195.75.94.99]) by mx0a-001b2d01.pphosted.com with ESMTP id 30gmu7y4mv-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Tue, 21 Apr 2020 06:43:12 -0400 Received: from localhost by e06smtp03.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 21 Apr 2020 11:42:46 +0100 Received: from b06cxnps3075.portsmouth.uk.ibm.com (9.149.109.195) by e06smtp03.uk.ibm.com (192.168.101.133) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Tue, 21 Apr 2020 11:42:42 +0100 Received: from d06av22.portsmouth.uk.ibm.com (d06av22.portsmouth.uk.ibm.com [9.149.105.58]) by b06cxnps3075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 03LAh4ui48234514 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 21 Apr 2020 10:43:04 GMT Received: from d06av22.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 587084C046; Tue, 21 Apr 2020 10:43:04 +0000 (GMT) Received: from d06av22.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id D75B84C044; Tue, 21 Apr 2020 10:43:03 +0000 (GMT) Received: from oc7455500831.ibm.com (unknown [9.145.151.164]) by d06av22.portsmouth.uk.ibm.com (Postfix) with ESMTP; Tue, 21 Apr 2020 10:43:03 +0000 (GMT) Subject: Re: stop using ioctl_by_bdev in the s390 DASD driver To: Cornelia Huck Cc: Christoph Hellwig , Stefan Haberland , Jan Hoeppner , Jens Axboe , Heiko Carstens , Vasily Gorbik , linux-s390@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org References: <20200421061226.33731-1-hch@lst.de> <20200421123256.2f5d9dbd.cohuck@redhat.com> From: Christian Borntraeger Autocrypt: addr=borntraeger@de.ibm.com; prefer-encrypt=mutual; keydata= xsFNBE6cPPgBEAC2VpALY0UJjGmgAmavkL/iAdqul2/F9ONz42K6NrwmT+SI9CylKHIX+fdf J34pLNJDmDVEdeb+brtpwC9JEZOLVE0nb+SR83CsAINJYKG3V1b3Kfs0hydseYKsBYqJTN2j CmUXDYq9J7uOyQQ7TNVoQejmpp5ifR4EzwIFfmYDekxRVZDJygD0wL/EzUr8Je3/j548NLyL 4Uhv6CIPf3TY3/aLVKXdxz/ntbLgMcfZsDoHgDk3lY3r1iwbWwEM2+eYRdSZaR4VD+JRD7p8 0FBadNwWnBce1fmQp3EklodGi5y7TNZ/CKdJ+jRPAAnw7SINhSd7PhJMruDAJaUlbYaIm23A +82g+IGe4z9tRGQ9TAflezVMhT5J3ccu6cpIjjvwDlbxucSmtVi5VtPAMTLmfjYp7VY2Tgr+ T92v7+V96jAfE3Zy2nq52e8RDdUo/F6faxcumdl+aLhhKLXgrozpoe2nL0Nyc2uqFjkjwXXI OBQiaqGeWtxeKJP+O8MIpjyGuHUGzvjNx5S/592TQO3phpT5IFWfMgbu4OreZ9yekDhf7Cvn /fkYsiLDz9W6Clihd/xlpm79+jlhm4E3xBPiQOPCZowmHjx57mXVAypOP2Eu+i2nyQrkapaY IdisDQfWPdNeHNOiPnPS3+GhVlPcqSJAIWnuO7Ofw1ZVOyg/jwARAQABzUNDaHJpc3RpYW4g Qm9ybnRyYWVnZXIgKDJuZCBJQk0gYWRkcmVzcykgPGJvcm50cmFlZ2VyQGxpbnV4LmlibS5j b20+wsF5BBMBAgAjBQJdP/hMAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQEXu8 gLWmHHy/pA/+JHjpEnd01A0CCyfVnb5fmcOlQ0LdmoKWLWPvU840q65HycCBFTt6V62cDljB kXFFxMNA4y/2wqU0H5/CiL963y3gWIiJsZa4ent+KrHl5GK1nIgbbesfJyA7JqlB0w/E/SuY NRQwIWOo/uEvOgXnk/7+rtvBzNaPGoGiiV1LZzeaxBVWrqLtmdi1iulW/0X/AlQPuF9dD1Px hx+0mPjZ8ClLpdSp5d0yfpwgHtM1B7KMuQPQZGFKMXXTUd3ceBUGGczsgIMipZWJukqMJiJj QIMH0IN7XYErEnhf0GCxJ3xAn/J7iFpPFv8sFZTvukntJXSUssONnwiKuld6ttUaFhSuSoQg OFYR5v7pOfinM0FcScPKTkrRsB5iUvpdthLq5qgwdQjmyINt3cb+5aSvBX2nNN135oGOtlb5 tf4dh00kUR8XFHRrFxXx4Dbaw4PKgV3QLIHKEENlqnthH5t0tahDygQPnSucuXbVQEcDZaL9 WgJqlRAAj0pG8M6JNU5+2ftTFXoTcoIUbb0KTOibaO9zHVeGegwAvPLLNlKHiHXcgLX1tkjC DrvE2Z0e2/4q7wgZgn1kbvz7ZHQZB76OM2mjkFu7QNHlRJ2VXJA8tMXyTgBX6kq1cYMmd/Hl OhFrAU3QO1SjCsXA2CDk9MM1471mYB3CTXQuKzXckJnxHkHOwU0ETpw8+AEQAJjyNXvMQdJN t07BIPDtbAQk15FfB0hKuyZVs+0lsjPKBZCamAAexNRk11eVGXK/YrqwjChkk60rt3q5i42u PpNMO9aS8cLPOfVft89Y654Qd3Rs1WRFIQq9xLjdLfHh0i0jMq5Ty+aiddSXpZ7oU6E+ud+X Czs3k5RAnOdW6eV3+v10sUjEGiFNZwzN9Udd6PfKET0J70qjnpY3NuWn5Sp1ZEn6lkq2Zm+G 9G3FlBRVClT30OWeiRHCYB6e6j1x1u/rSU4JiNYjPwSJA8EPKnt1s/Eeq37qXXvk+9DYiHdT PcOa3aNCSbIygD3jyjkg6EV9ZLHibE2R/PMMid9FrqhKh/cwcYn9FrT0FE48/2IBW5mfDpAd YvpawQlRz3XJr2rYZJwMUm1y+49+1ZmDclaF3s9dcz2JvuywNq78z/VsUfGz4Sbxy4ShpNpG REojRcz/xOK+FqNuBk+HoWKw6OxgRzfNleDvScVmbY6cQQZfGx/T7xlgZjl5Mu/2z+ofeoxb vWWM1YCJAT91GFvj29Wvm8OAPN/+SJj8LQazd9uGzVMTz6lFjVtH7YkeW/NZrP6znAwv5P1a DdQfiB5F63AX++NlTiyA+GD/ggfRl68LheSskOcxDwgI5TqmaKtX1/8RkrLpnzO3evzkfJb1 D5qh3wM1t7PZ+JWTluSX8W25ABEBAAHCwV8EGAECAAkFAk6cPPgCGwwACgkQEXu8gLWmHHz8 2w//VjRlX+tKF3szc0lQi4X0t+pf88uIsvR/a1GRZpppQbn1jgE44hgF559K6/yYemcvTR7r 6Xt7cjWGS4wfaR0+pkWV+2dbw8Xi4DI07/fN00NoVEpYUUnOnupBgychtVpxkGqsplJZQpng v6fauZtyEcUK3dLJH3TdVQDLbUcL4qZpzHbsuUnTWsmNmG4Vi0NsEt1xyd/Wuw+0kM/oFEH1 4BN6X9xZcG8GYUbVUd8+bmio8ao8m0tzo4pseDZFo4ncDmlFWU6hHnAVfkAs4tqA6/fl7RLN JuWBiOL/mP5B6HDQT9JsnaRdzqF73FnU2+WrZPjinHPLeE74istVgjbowvsgUqtzjPIG5pOj cAsKoR0M1womzJVRfYauWhYiW/KeECklci4TPBDNx7YhahSUlexfoftltJA8swRshNA/M90/ i9zDo9ySSZHwsGxG06ZOH5/MzG6HpLja7g8NTgA0TD5YaFm/oOnsQVsf2DeAGPS2xNirmknD jaqYefx7yQ7FJXXETd2uVURiDeNEFhVZWb5CiBJM5c6qQMhmkS4VyT7/+raaEGgkEKEgHOWf ZDP8BHfXtszHqI3Fo1F4IKFo/AP8GOFFxMRgbvlAs8z/+rEEaQYjxYJqj08raw6P4LFBqozr nS4h0HDFPrrp1C2EMVYIQrMokWvlFZbCpsdYbBI= Date: Tue, 21 Apr 2020 12:43:03 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 MIME-Version: 1.0 In-Reply-To: <20200421123256.2f5d9dbd.cohuck@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 x-cbid: 20042110-0012-0000-0000-000003A88637 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 20042110-0013-0000-0000-000021E5D33D Message-Id: <427b0095-6a38-5632-8e46-422c7a4a552a@de.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.138,18.0.676 definitions=2020-04-21_03:2020-04-20,2020-04-21 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 priorityscore=1501 spamscore=0 lowpriorityscore=0 adultscore=0 impostorscore=0 mlxscore=0 malwarescore=0 suspectscore=0 mlxlogscore=692 clxscore=1015 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2003020000 definitions=main-2004210081 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 21.04.20 12:32, Cornelia Huck wrote: > On Tue, 21 Apr 2020 11:58:31 +0200 > Christian Borntraeger wrote: > >> On 21.04.20 08:12, Christoph Hellwig wrote: >>> Hi Jens and DASD maintainers, >>> >>> can you take a look at this series, which stops the DASD driver from >>> issuing ioctls from kernel space, in preparation of removing >>> ioctl_by_bdev. I don't really like the new s390-only method, but short >>> of forcing the dasd driver to be built into the kernel I can't think of >>> anything better. But maybe the s390 maintainers are fine with forcing >>> the DASD driver to be built in, in which case we could go down that >>> route? >> >> Hmm the defconfig results in dasd built-in anyway. But distros really like >> to keep it modular. >> >> Hmm, we do have >> >> obj-$(CONFIG_DASD) += dasd_mod.o >> obj-$(CONFIG_DASD_DIAG) += dasd_diag_mod.o >> obj-$(CONFIG_DASD_ECKD) += dasd_eckd_mod.o >> obj-$(CONFIG_DASD_FBA) += dasd_fba_mod.o >> >> Would it work to make CONFIG_DASD built-in only and keep the other 3 as modules? >> Not sure about the implications. >> > > I don't think non-eckd dasd drivers are really useful outside of z/VM > guests, so keeping at least the disciplines modular would be good. > > Also, what about special purpose environments like the zfcp dumper? > Would be good to be able to keep these small. > > How big is the dasd code in the end? File: drivers/s390/block/dasd_diag_mod.ko Size: 519976 Blocks: 1016 IO Block: 4096 regular file -- File: drivers/s390/block/dasd_eckd_mod.ko Size: 2125976 Blocks: 4160 IO Block: 4096 regular file -- File: drivers/s390/block/dasd_fba_mod.ko Size: 524256 Blocks: 1024 IO Block: 4096 regular file -- File: drivers/s390/block/dasd_mod.ko Size: 3273464 Blocks: 6400 IO Block: 4096 regular file So 3 MB seems quite a lot for special purpose Linuxes like the zfcp dumper.