Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp16482ybz; Tue, 21 Apr 2020 03:51:36 -0700 (PDT) X-Google-Smtp-Source: APiQypLE8hukh5BoWOGwPavDlWaKnesT6y+oUfK108x33tP3htz0PFiAd5tZV27JzH/3M91xtIhy X-Received: by 2002:a50:abe2:: with SMTP id u89mr18818979edc.259.1587466295846; Tue, 21 Apr 2020 03:51:35 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1587466295; cv=none; d=google.com; s=arc-20160816; b=bX9aZ06uxkLuHlRJ1i7grhcJjZRQ030X8Fy+ufxKGb+eLuHcsUxhKl0s4JCXLEz38n S1dlZ9gFWFNKAZbAruW37MkHF6Lae2MRg/vJgY/njoBDF60DcyBsq7lWwQXyVUa4ZJrR zjLtAy7+kI/OIQOizn6PwkYi2KjBOkiXatv4E9lE383ZehCTa6rEjXv8chifHlZYQhEE dyS2ZblbDfKNZyeVo6KwYddS6ac4QEiocFurkiZS5TaI5lXsoPkZtRrCpleeJixRIBzb 9fOMHrOofkbxalUvWYfOPud915suxA+M/rhSd4VT52TfOH9NniKfbOavIFBBtnv/KwKb vuIQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :ironport-sdr:ironport-sdr; bh=tCp2mFGesE7VthUjvASSEIH/72nQwj217emC4xwg67U=; b=nBe53sH0bxglU8V8CxI2kYMU04hzeVvPclVLf39w/cANkcyJht2w5hLeENb3u0055a PhpVYlhwe0cwFy3m/lno1qKiYTEcoME/OMojNBQ+B31B9N6MG/WJX+kMPD2uESnVd2F9 zd2imRY+kTDHeMBJmEWE4TckUjMnjh6qxVk+S3HmJ6NM3FfDpQdC9nTyDM84rAs467jy /UFSjkpOqrNqT2+Q9nEXI+/y+3X8F0ue/nRJ2Ry+wEfC1/CQ+AvA9JVK/s75zh3dWp9k VTE9zTsiD5+WEWsX7UT3hNZn6+l9uIFQcin9oAzOdMHpmiBn1fg7fGQ/5UJ2dS4rV48G Upow== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id h10si1285659ejt.278.2020.04.21.03.51.11; Tue, 21 Apr 2020 03:51:35 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728422AbgDUKuA (ORCPT + 99 others); Tue, 21 Apr 2020 06:50:00 -0400 Received: from mga11.intel.com ([192.55.52.93]:12785 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726018AbgDUKuA (ORCPT ); Tue, 21 Apr 2020 06:50:00 -0400 IronPort-SDR: rXYLHfoZ9m0r0WXb+yCRQASGRuGOubbfK7rvLH3/KRmuLiQMjkV/5ea10ubLrw7MPCsNoQLiNp 5msFJ4MMjohQ== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Apr 2020 03:49:59 -0700 IronPort-SDR: bIZwYTysqpJ2YziHJ4mCUKfCOuUQQ6JRXs+0+eS3ychRYrpQqvBRt467vNlybSUYb/myyguePQ fLr6fZLsYmpw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.72,410,1580803200"; d="scan'208";a="456058639" Received: from chenyu-office.sh.intel.com ([10.239.158.173]) by fmsmga005.fm.intel.com with ESMTP; 21 Apr 2020 03:49:56 -0700 From: Chen Yu To: linux-kernel@vger.kernel.org Cc: Peter Zijlstra , Vincent Guittot , Steven Rostedt , Valentin Schneider , Ingo Molnar , Juri Lelli , Dietmar Eggemann , Mel Gorman , Ben Segall , Chen Yu Subject: [PATCH 0/2][v3] sched: Clean up newidle_balance() and pick_next_task() Date: Tue, 21 Apr 2020 18:48:47 +0800 Message-Id: X-Mailer: git-send-email 2.17.1 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org As Peter suggested, here are two minor code clean up in the scheduler: 1. turn newidle_balance() into a static function. 2. code extraction in pick_next_task() for future re-use. Chen Yu (2): sched: Make newidle_balance() static again sched: Extract the task putting code from pick_next_task() kernel/sched/core.c | 39 +++++++++++++++++++++++---------------- kernel/sched/fair.c | 6 ++++-- kernel/sched/sched.h | 4 ---- 3 files changed, 27 insertions(+), 22 deletions(-) -- 2.17.1