Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp36248ybz; Tue, 21 Apr 2020 04:15:17 -0700 (PDT) X-Google-Smtp-Source: APiQypJFXprO8v513TQ2+//JVFrDFsOjBb8y4bQYT0YPVxJo9Ue7fQF7U0gqeC+bXat4ld2IFUzy X-Received: by 2002:a05:6402:1496:: with SMTP id e22mr18283257edv.301.1587467716879; Tue, 21 Apr 2020 04:15:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1587467716; cv=none; d=google.com; s=arc-20160816; b=IZaxeIeb0dpY5y8sPOF8/wbCW5kIL8rya/2xlOx+iH2GTRQ/TAr3fozXR8AAMTsqx2 e2LpaHZP9MiTMXXX5TU8lwayhbcU13VENWFvcmn9sRk+R7ZNBbV6dVL+ennXLWXoB8jP lIBwzsU9YMoKc54Iu6pYVU4du3vm2mWHqftDYg/On3TmHHmRINKpcPjFUCyn16+u+taa jdmmPrSjwj/PA/QgonpcNViu3zFBO3iFripsGSVnx/LWIw7T20vMpJZ3vBHp7QSFaKeA W2HeZVKCbpnhHXhK+7yXmMu27uI2PFuSdr2cpF1bhrHo9QRG7Ruz9ME3AMTvvfEZdjkd RfLg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-language:in-reply-to:mime-version :user-agent:date:message-id:autocrypt:from:references:cc:to:subject :dkim-signature; bh=O5UFoBp/u/YGve2539Ml1suvS962s7VYeI16yybZvPs=; b=tgtkAURnIP4N7gbpSS06pzBQQ6hAVmgxb9MZPWIcV8TO6vXicTcAWvEUlRqVqCV3DH Pl+nTm1iEQO+QzXunHpfZwBCZGWMuzGJvYPJjjeO9hlWLdUAqOqKcRGqaqYsyA+sxXL0 y6iPS764n9Pk6o4GJTu1u8fUbvuxoGrQRTF8MYSlHm7u/T4lXcSv2YFviqE/dwQsaaVl i+NMs11o9J8oCJCQ1f7xTxBhNveivceF3DzkPQYhFf0xXSOdTABgFKaAasW3yCiE4yjD qawyDN+M/mREG/HOblpevvaUpM+/dKIyrT+D7F+i0p9Y5bRuR+1ChkG7DblcKzXyKtMH YVMg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@web.de header.s=dbaedf251592 header.b=fr+vNmxv; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id l4si1384062ede.294.2020.04.21.04.14.53; Tue, 21 Apr 2020 04:15:16 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@web.de header.s=dbaedf251592 header.b=fr+vNmxv; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728550AbgDULMm (ORCPT + 99 others); Tue, 21 Apr 2020 07:12:42 -0400 Received: from mout.web.de ([212.227.17.12]:58359 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727120AbgDULMl (ORCPT ); Tue, 21 Apr 2020 07:12:41 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=dbaedf251592; t=1587467549; bh=O5UFoBp/u/YGve2539Ml1suvS962s7VYeI16yybZvPs=; h=X-UI-Sender-Class:Subject:To:Cc:References:From:Date:In-Reply-To; b=fr+vNmxvF6ksTrRXdZK4j5atjhg2vhao13RM4Ppg20XbCXSsutf+cN6EBspZT/WyG uWYJIqKKcVVluYAxcrLJPco5hDKyGSAwL9Y6JqY7Jh9bug0T1nMdSy4MqX+8w5WCfh g0lmlKKuJUSCvIHQDIZyRzYTlnvzm+jQdMzyDeII= X-UI-Sender-Class: c548c8c5-30a9-4db5-a2e7-cb6cb037b8f9 Received: from [192.168.1.2] ([2.243.91.59]) by smtp.web.de (mrweb103 [213.165.67.124]) with ESMTPSA (Nemesis) id 0M9XM3-1jW7E33KOd-00D1e6; Tue, 21 Apr 2020 13:12:28 +0200 Subject: Re: [V3] amdgpu: remove unnecessary condition check To: =?UTF-8?B?6LW15Yab5aWO?= , amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org Cc: opensource.kernel@vivo.com, linux-kernel@vger.kernel.org, David Airlie , Daniel Vetter , Alex Deucher , =?UTF-8?Q?Christian_K=c3=b6nig?= , Chunming Zhou , =?UTF-8?Q?Felix_K=c3=bchling?= References: From: Markus Elfring Autocrypt: addr=Markus.Elfring@web.de; prefer-encrypt=mutual; keydata= mQINBFg2+xABEADBJW2hoUoFXVFWTeKbqqif8VjszdMkriilx90WB5c0ddWQX14h6w5bT/A8 +v43YoGpDNyhgA0w9CEhuwfZrE91GocMtjLO67TAc2i2nxMc/FJRDI0OemO4VJ9RwID6ltwt mpVJgXGKkNJ1ey+QOXouzlErVvE2fRh+KXXN1Q7fSmTJlAW9XJYHS3BDHb0uRpymRSX3O+E2 lA87C7R8qAigPDZi6Z7UmwIA83ZMKXQ5stA0lhPyYgQcM7fh7V4ZYhnR0I5/qkUoxKpqaYLp YHBczVP+Zx/zHOM0KQphOMbU7X3c1pmMruoe6ti9uZzqZSLsF+NKXFEPBS665tQr66HJvZvY GMDlntZFAZ6xQvCC1r3MGoxEC1tuEa24vPCC9RZ9wk2sY5Csbva0WwYv3WKRZZBv8eIhGMxs rcpeGShRFyZ/0BYO53wZAPV1pEhGLLxd8eLN/nEWjJE0ejakPC1H/mt5F+yQBJAzz9JzbToU 5jKLu0SugNI18MspJut8AiA1M44CIWrNHXvWsQ+nnBKHDHHYZu7MoXlOmB32ndsfPthR3GSv jN7YD4Ad724H8fhRijmC1+RpuSce7w2JLj5cYj4MlccmNb8YUxsE8brY2WkXQYS8Ivse39MX BE66MQN0r5DQ6oqgoJ4gHIVBUv/ZwgcmUNS5gQkNCFA0dWXznQARAQABtCZNYXJrdXMgRWxm cmluZyA8TWFya3VzLkVsZnJpbmdAd2ViLmRlPokCVAQTAQgAPhYhBHDP0hzibeXjwQ/ITuU9 Figxg9azBQJYNvsQAhsjBQkJZgGABQsJCAcCBhUICQoLAgQWAgMBAh4BAheAAAoJEOU9Figx g9azcyMP/iVihZkZ4VyH3/wlV3nRiXvSreqg+pGPI3c8J6DjP9zvz7QHN35zWM++1yNek7Ar OVXwuKBo18ASlYzZPTFJZwQQdkZSV+atwIzG3US50ZZ4p7VyUuDuQQVVqFlaf6qZOkwHSnk+ CeGxlDz1POSHY17VbJG2CzPuqMfgBtqIU1dODFLpFq4oIAwEOG6fxRa59qbsTLXxyw+PzRaR LIjVOit28raM83Efk07JKow8URb4u1n7k9RGAcnsM5/WMLRbDYjWTx0lJ2WO9zYwPgRykhn2 sOyJVXk9xVESGTwEPbTtfHM+4x0n0gC6GzfTMvwvZ9G6xoM0S4/+lgbaaa9t5tT/PrsvJiob kfqDrPbmSwr2G5mHnSM9M7B+w8odjmQFOwAjfcxoVIHxC4Cl/GAAKsX3KNKTspCHR0Yag78w i8duH/eEd4tB8twcqCi3aCgWoIrhjNS0myusmuA89kAWFFW5z26qNCOefovCx8drdMXQfMYv g5lRk821ZCNBosfRUvcMXoY6lTwHLIDrEfkJQtjxfdTlWQdwr0mM5ye7vd83AManSQwutgpI q+wE8CNY2VN9xAlE7OhcmWXlnAw3MJLW863SXdGlnkA3N+U4BoKQSIToGuXARQ14IMNvfeKX NphLPpUUnUNdfxAHu/S3tPTc/E/oePbHo794dnEm57LuuQINBFg2+xABEADZg/T+4o5qj4cw nd0G5pFy7ACxk28mSrLuva9tyzqPgRZ2bdPiwNXJUvBg1es2u81urekeUvGvnERB/TKekp25 4wU3I2lEhIXj5NVdLc6eU5czZQs4YEZbu1U5iqhhZmKhlLrhLlZv2whLOXRlLwi4jAzXIZAu 76mT813jbczl2dwxFxcT8XRzk9+dwzNTdOg75683uinMgskiiul+dzd6sumdOhRZR7YBT+xC wzfykOgBKnzfFscMwKR0iuHNB+VdEnZw80XGZi4N1ku81DHxmo2HG3icg7CwO1ih2jx8ik0r riIyMhJrTXgR1hF6kQnX7p2mXe6K0s8tQFK0ZZmYpZuGYYsV05OvU8yqrRVL/GYvy4Xgplm3 DuMuC7/A9/BfmxZVEPAS1gW6QQ8vSO4zf60zREKoSNYeiv+tURM2KOEj8tCMZN3k3sNASfoG fMvTvOjT0yzMbJsI1jwLwy5uA2JVdSLoWzBD8awZ2X/eCU9YDZeGuWmxzIHvkuMj8FfX8cK/ 2m437UA877eqmcgiEy/3B7XeHUipOL83gjfq4ETzVmxVswkVvZvR6j2blQVr+MhCZPq83Ota xNB7QptPxJuNRZ49gtT6uQkyGI+2daXqkj/Mot5tKxNKtM1Vbr/3b+AEMA7qLz7QjhgGJcie qp4b0gELjY1Oe9dBAXMiDwARAQABiQI8BBgBCAAmFiEEcM/SHOJt5ePBD8hO5T0WKDGD1rMF Alg2+xACGwwFCQlmAYAACgkQ5T0WKDGD1rOYSw/+P6fYSZjTJDAl9XNfXRjRRyJSfaw6N1pA Ahuu0MIa3djFRuFCrAHUaaFZf5V2iW5xhGnrhDwE1Ksf7tlstSne/G0a+Ef7vhUyeTn6U/0m +/BrsCsBUXhqeNuraGUtaleatQijXfuemUwgB+mE3B0SobE601XLo6MYIhPh8MG32MKO5kOY hB5jzyor7WoN3ETVNQoGgMzPVWIRElwpcXr+yGoTLAOpG7nkAUBBj9n9TPpSdt/npfok9ZfL /Q+ranrxb2Cy4tvOPxeVfR58XveX85ICrW9VHPVq9sJf/a24bMm6+qEg1V/G7u/AM3fM8U2m tdrTqOrfxklZ7beppGKzC1/WLrcr072vrdiN0icyOHQlfWmaPv0pUnW3AwtiMYngT96BevfA qlwaymjPTvH+cTXScnbydfOQW8220JQwykUe+sHRZfAF5TS2YCkQvsyf7vIpSqo/ttDk4+xc Z/wsLiWTgKlih2QYULvW61XU+mWsK8+ZlYUrRMpkauN4CJ5yTpvp+Orcz5KixHQmc5tbkLWf x0n1QFc1xxJhbzN+r9djSGGN/5IBDfUqSANC8cWzHpWaHmSuU3JSAMB/N+yQjIad2ztTckZY pwT6oxng29LzZspTYUEzMz3wK2jQHw+U66qBFk8whA7B2uAU1QdGyPgahLYSOa4XAEGb6wbI FEE= Message-ID: Date: Tue, 21 Apr 2020 13:12:27 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US X-Provags-ID: V03:K1:mCPUfKMzwUiOkjUTV5F70mtnY9PpBoYAwL6Vc5A1nyuUxnokLJA TKqhFejjfmU1T/A/0WsYdV3do9OwELrcIioUHURJ9EkSzwsBCfzctvY1a8V+a70GWTFcdxd foCVKbcaPlim5xA0GbRH9rrGNNexa6L1/MO5heq1uKVww5EehFEEJr7qtTQs6eo1COqLHE2 J+34otu69y2xq9aISg2hg== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:dya4Us5oLyU=:mCwa85+cUoC74r+ODmJtK9 3IktGA0M6a4qXuHi2rnC13RGVR7OYOnenC06SkYnsX//MGRUs+wgqEab4iAcCR0d5342wFDfN dk+fOJInAdBdpnjg2/f3VLQ3hHW+y1Ubd/v5ejQmzaXQFvsweXXYTlXuJmOe4NotJKQBvZ/7T CM347BMEen7iBEeu0cxinWBEn6z+8/Gwcl/xgBpHDPm1KXLoa8hJK78mUnHM21IbwV6K7ePo7 ziBSdUkuuQk1duiEjskgTvM6ppXFC5R12Skm9EUCnrbwy6yG7yhbeJGqy+icBUa/JBUiNpJxD dqPyzRX0KO4raZSlc21BtCKpVq+OjFR627f1MrTZlNpzRzzhU4nHqENhtR69c7dBRIn4bDcJc FdpsxWzTRXHnV/x4izp8vS3TEl0ihr0GRXiCPA8BcpNQUw3OMye/TWa0qiBo9v7NBiTdLUb2P kuKayIgYydA1EKcFX0H1eXzUZpSyJ3YEeA3Npef1LWpZ7GmvnEgvqXHysFF3+HnP+vKjbYW/s 5mZ7J54tTeTDJL39kddWqi58c9meTtrQKhIwEUlyafbWh6Td5FdB5zESI7fe4qdf+hVUfJYQB jnhd3rVVtcQCqHS9bcU5WiBNzrnCjeiKUtcdup/vkDGj257HlewCryakTA4/h9t0h/rbhrdST mrE9BynDQNhCp2wJuDc9m1YAuti/2k1GTq+D1nocFOQ76nskfAEHZL3TdZtBSjqg+Cr6dTJDH JEjEofGDL5o0NXd/DHJMkk7wyDrQo3+oNcVY5ieaf24V5tYxk+66KPVcDrzqfgYI0d2wkVy2A flGw0TtivNkjfwWQRyN/NvNwusrjs9NoWR0iGkWcbks62U+hvOpoNEywz6i2mBG2DsPM7vtWt 9nCLjO0gfoXVulHPwT73Xz4ftuUAnVIFxO9561ufTiQTQHFDP2S0JTFAihOjiNXZF1e5GPtBJ YdRZvP5DprdD6a24ii0nObrHlEdR8lySSQNsW6UZCHBwhDXy1F/M35PIgCqsXmF9XslQ7N+MZ mSr69H+tixc7gg4tU8FR1WSyTcSbVc431mTpLklI/WnvI6ROBPA0ziyecoEapwClaizfoF786 mJ+rrs1KDrcThhFWYE6VW+mARpBrnJvruuDCbQEI7iIMyx1MPhzu7fMEdCIVoID8+6X/EsYvV n1CbacYxkUYKg2SHewoGOTVPBPOey0Krujf1fm8oWixjscDkJuBjsDdCZdafHQxDG8dIdlbqu YPiYhR3cMcue0F7+8 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org >>> There is no need to if check again, maybe we could merge >>> into the above else branch. I find also this commit message still improvable (besides the mentioned implementation details around coding style concerns). How will corresponding review comments be taken better into account? Regards, Markus