Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp54278ybz; Tue, 21 Apr 2020 04:37:25 -0700 (PDT) X-Google-Smtp-Source: APiQypLH0Y+zZy/PythOrtT75TP02maFpO4DEDfiiF1ByxVDrLRLY4H1YvPqu1+jXYjz1AiL/eo6 X-Received: by 2002:aa7:d5d4:: with SMTP id d20mr5548977eds.369.1587469045088; Tue, 21 Apr 2020 04:37:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1587469045; cv=none; d=google.com; s=arc-20160816; b=jTbJVxb8IXTrIcsZLXzZklXMKzH1gMytwBX3NO0c4tetHFJ3/iIPTVLwlafFXsjCsz FUm8R373YDYPO9yCRBvIlMSm1nR+AJ3VoztETWBIa/KRABrek8bj6en9+Ur4Opo4FaQ5 emqawrXd4eeG78BQfX/2SvYR4+Fycd/hEcYCpz7BfJe/FisJg8rwM7bh3138oOQWyoNT mgV7sMPXBS4iiRagJRRBNd9ki6pKeswQQUCNUhsahJ0xXB4hFgKCKjl4PSmYfV4RdL47 PRFYnoO/IQwN5wCsSqBaXQG+P1TYQEpw4gtSMonK6W+iwFRwxlqlGxTSSkjihc2zjcZr 1SLQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject; bh=Uc/fd6Q13fXtWZCdIalKH0g0a6LuNk7TMUIgJRs5RZ8=; b=LvBaqpWtiVkKvzOltWmU7ehP5874eo6A7CY7spMj7ViiLfJhoVq1AbmKHGMLLd9tvW JeMXpfD6OHHuLIWTfjCb50eEzewWZXPxf9nSxQOo0vGQh+Hu/M02t9+yR14WsWQaRud6 OPLTvVove7Z6KXC2A01HVDDoj3UIShH1PEgx19uq4h7Z64fTYX1/tyZwZIG6RbwN9dDV Bbr1SE2LJhS89tTR9LViyrG+rkkAoiSRWF0VvHwalwdkkVgoTRQBqO4jpBBuosXgz+Ck Y2N5B0pjC0ORU3xsd+USI5ez6XGV3V4BHJZHH/omfvp1t3yARYvKPajEqPPR/5e8lhwg 2QCw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id s13si1376079ejr.484.2020.04.21.04.37.01; Tue, 21 Apr 2020 04:37:25 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728480AbgDULf7 (ORCPT + 99 others); Tue, 21 Apr 2020 07:35:59 -0400 Received: from szxga05-in.huawei.com ([45.249.212.191]:2819 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726403AbgDULf7 (ORCPT ); Tue, 21 Apr 2020 07:35:59 -0400 Received: from DGGEMS410-HUB.china.huawei.com (unknown [172.30.72.59]) by Forcepoint Email with ESMTP id 5100D55BC0460382B078; Tue, 21 Apr 2020 19:35:53 +0800 (CST) Received: from [10.134.22.195] (10.134.22.195) by smtp.huawei.com (10.3.19.210) with Microsoft SMTP Server (TLS) id 14.3.487.0; Tue, 21 Apr 2020 19:35:49 +0800 Subject: Re: [f2fs-dev] [PATCH] f2fs: remove redundant assignment to variable err To: Colin King , Jaegeuk Kim , Chao Yu , CC: , References: <20200420220057.98796-1-colin.king@canonical.com> From: Chao Yu Message-ID: <881187e9-68c0-6766-d462-881371973974@huawei.com> Date: Tue, 21 Apr 2020 19:35:48 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20200420220057.98796-1-colin.king@canonical.com> Content-Type: text/plain; charset="windows-1252" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.134.22.195] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2020/4/21 6:00, Colin King wrote: > From: Colin Ian King > > The variable err is being assigned with a value that is never read > and it is being updated later with a new value. The initialization is > redundant and can be removed. > > Addresses-Coverity: ("Unused value") > Signed-off-by: Colin Ian King Reviewed-by: Chao Yu Thanks,