Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp89458ybz; Tue, 21 Apr 2020 05:19:36 -0700 (PDT) X-Google-Smtp-Source: APiQypJ0XkGcCv0vE9XkmpWM4KpK6Lu57fXr08a9+yxzCU0S4UyJWFv1Jc4zb+2am6UPCVsvRoEt X-Received: by 2002:a17:907:40ec:: with SMTP id nn20mr19779012ejb.294.1587471576706; Tue, 21 Apr 2020 05:19:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1587471576; cv=none; d=google.com; s=arc-20160816; b=MD2kKHE0NsojlMdLqyBSZtaxEUf98l+r4DwFGAE2VVc7WWPTa758QqM+qR6GxNZtiB 4HnPeRjL8AnxoIQLnqh2SZEXFrkAaYtuOI0u9UCba2kfYi4q62+2FaQwOM7N5WSecWBl P1CIIHqAIAmlgo9PthS4+aNIViU1qsvpSWo8Gw//a2ZlllUN8tk+NHXsrxxm0PmJvFQ8 fvoJRdcWE8+Jx3y534OAMFWwnFNp4tExS+bZEVTC02nqM4d7hx4q5UKjAMENaHScu3jJ DnFLqfN549he0Dswx5B898G6YKa/YZltS6w/Ovt7ktnAL+2Bw7uFG2SfJbL2C4w5e/Ng RjtA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=o1pPWDD57EzmXU9rW6XIaJoAWqLX4homM90eW9fhV10=; b=lzjliz/+W0vAwL3J9ty18SNlEHPV5GtugZ3TqNqmsGmT8P51atikgyWL0/7hF0uxoW VwUjVUkOejksbIfny6C+l5vAAj/r3NPN0nn2HX1fFZ3ncuNWw9EoCxrIFKhfWggBf1Sl Tih+NZU81PCjyS5Lrc3ryh3Z4t2+u+vd05f/6IsroXrQA2/3U9Eh7SpThyV/YtuPQauy cfoGYiXpyFXMyc5vxNBSFhGvOBpGQePZHhzha07COAAQdzE9+p9wNyp3u7j/nha/0DVJ sTD/UbZXG+W+Xnl8CegD/pgvsYm+P3J8+P95yRYVuT9i0i/USTw9id10iMMtr1tca00p /wcQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id p3si1551718edj.289.2020.04.21.05.19.14; Tue, 21 Apr 2020 05:19:36 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728636AbgDUMPm (ORCPT + 99 others); Tue, 21 Apr 2020 08:15:42 -0400 Received: from foss.arm.com ([217.140.110.172]:33938 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726018AbgDUMPm (ORCPT ); Tue, 21 Apr 2020 08:15:42 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id E99E531B; Tue, 21 Apr 2020 05:15:41 -0700 (PDT) Received: from e107158-lin.cambridge.arm.com (e107158-lin.cambridge.arm.com [10.1.195.21]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id B28CD3F68F; Tue, 21 Apr 2020 05:15:39 -0700 (PDT) Date: Tue, 21 Apr 2020 13:15:37 +0100 From: Qais Yousef To: Peter Zijlstra Cc: Steven Rostedt , Valentin Schneider , Ingo Molnar , Juri Lelli , Vincent Guittot , Dietmar Eggemann , Ben Segall , Mel Gorman , Andrew Morton , Thomas Gleixner , Yury Norov , Paul Turner , Alexey Dobriyan , Josh Don , Pavan Kondeti , linux-kernel@vger.kernel.org Subject: Re: [PATCH 0/4] sched/rt: Distribute tasks in find_lowest_rq() Message-ID: <20200421121536.rwupnm6vna374z5y@e107158-lin.cambridge.arm.com> References: <20200414150556.10920-1-qais.yousef@arm.com> <20200414162742.0ef4d9ee@gandalf.local.home> <20200415093935.GA20730@hirez.programming.kicks-ass.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20200415093935.GA20730@hirez.programming.kicks-ass.net> User-Agent: NeoMutt/20171215 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/15/20 11:39, Peter Zijlstra wrote: > On Tue, Apr 14, 2020 at 04:27:42PM -0400, Steven Rostedt wrote: > > On Tue, 14 Apr 2020 19:58:49 +0100 > > Valentin Schneider wrote: > > > > > To move this forward, I would suggest renaming the current cpumask_any_*() > > > into cpumask_first_*(), and THEN introduce the new pseudo-random > > > ones. People are then free to hand-fix specific locations if it makes sense > > > there, like you're doing for RT. > > > > Or leave "cpumask_any()" as is, and create a new "cpumask_random()" for > > this purpose. > > Well, that's just twisting words, not sure I like that. 'Any' really > means 'any'. So in order to preserve long term sanity, I'd vote for > Valentin's approach of converting existing users over to first. I have answered Valentin's email. So hopefully I have addressed the concerns. If not, I really hate this mass conversion and I think we're better off with the status-quo. Thanks -- Qais Yousef