Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20200421075532.19192-1-m.othacehe@gmail.com> <20200421075532.19192-4-m.othacehe@gmail.com>
In-Reply-To: <20200421075532.19192-4-m.othacehe@gmail.com>
From:   Andy Shevchenko <andy.shevchenko@gmail.com>
Date:   Tue, 21 Apr 2020 15:22:11 +0300
Message-ID: <CAHp75VcJ300S8r_f2cueYzB0OaLBJK9oJySgz5Jekb7dGFWnCw@mail.gmail.com>
Subject: Re: [PATCH v4 3/4] iio: vcnl4000: Add sampling frequency support for VCNL4010/20.
To:     Mathieu Othacehe <m.othacehe@gmail.com>
Cc:     Jonathan Cameron <jic23@kernel.org>,
        Hartmut Knaack <knaack.h@gmx.de>,
        Lars-Peter Clausen <lars@metafoo.de>,
        Peter Meerwald <pmeerw@pmeerw.net>,
        linux-iio <linux-iio@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue, Apr 21, 2020 at 10:56 AM Mathieu Othacehe <m.othacehe@gmail.com> wrote:
>
> Add sampling frequency support for proximity data on VCNL4010 and VCNL4020
> chips.

Couple of nitpicks below.

...

> +static const int vcnl4010_prox_sampling_frequency[][2] = {
> +       {1, 950000},
> +       {3, 906250},
> +       {7, 812500},
> +       {16, 625000},
> +       {31, 250000},
> +       {62, 500000},
> +       {125, 0},

> +       {250, 0}

Leave comma here, potentially helpful if it will be extended.

> +};

...

> +static int vcnl4010_write_proxy_samp_freq(struct vcnl4000_data *data, int val,
> +                                         int val2)
> +{
> +       int i;
> +       const int len = ARRAY_SIZE(vcnl4010_prox_sampling_frequency);
> +
> +       for (i = 0; i < len; i++) {
> +               if (val <= vcnl4010_prox_sampling_frequency[i][0])
> +                       break;
> +       }
> +
> +       if (i == len)
> +               return -EINVAL;

I would refactor this

  unsigned int i = ARRAY_SIZE(vcnl4010_prox_sampling_frequency);

  do {
    if (val > vcnl4010_prox_sampling_frequency[i][0])
      break;
  } while (--i);

You won't need to go full array to return error in this case.

> +       return i2c_smbus_write_byte_data(data->client, VCNL4010_PROX_RATE, i);
> +}

-- 
With Best Regards,
Andy Shevchenko