Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 21 Apr 2020 15:06:13 +0200
From:   Jiri Olsa <jolsa@redhat.com>
To:     Adrian Hunter <adrian.hunter@intel.com>
Cc:     Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@redhat.com>,
        Masami Hiramatsu <mhiramat@kernel.org>,
        Steven Rostedt <rostedt@goodmis.org>,
        Borislav Petkov <bp@alien8.de>,
        "H . Peter Anvin" <hpa@zytor.com>, x86@kernel.org,
        Mark Rutland <mark.rutland@arm.com>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Mathieu Poirier <mathieu.poirier@linaro.org>,
        Leo Yan <leo.yan@linaro.org>,
        Arnaldo Carvalho de Melo <acme@kernel.org>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH V6 13/15] perf intel-pt: Add support for text poke events
Message-ID: <20200421130613.GH809467@krava>
References: <20200405201327.7332-1-adrian.hunter@intel.com>
 <20200405201327.7332-14-adrian.hunter@intel.com>
 <20200421125050.GG809467@krava>
 <4308a61d-cbed-e0ed-d8a9-c7306a933e7b@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4308a61d-cbed-e0ed-d8a9-c7306a933e7b@intel.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue, Apr 21, 2020 at 04:02:32PM +0300, Adrian Hunter wrote:
> On 21/04/20 3:50 pm, Jiri Olsa wrote:
> > On Sun, Apr 05, 2020 at 11:13:25PM +0300, Adrian Hunter wrote:
> >> Select text poke events when available and the kernel is being traced.
> >> Process text poke events to invalidate entries in Intel PT's instruction
> >> cache.
> >>
> >> Example:
> >>
> >>   The example requires kernel config:
> >>     CONFIG_PROC_SYSCTL=y
> >>     CONFIG_SCHED_DEBUG=y
> >>     CONFIG_SCHEDSTATS=y
> >>
> >>   Before:
> >>
> >>     # perf record -o perf.data.before --kcore -a -e intel_pt//k -m,64M &
> >>     # cat /proc/sys/kernel/sched_schedstats
> >>     0
> >>     # echo 1 > /proc/sys/kernel/sched_schedstats
> >>     # cat /proc/sys/kernel/sched_schedstats
> >>     1
> >>     # echo 0 > /proc/sys/kernel/sched_schedstats
> >>     # cat /proc/sys/kernel/sched_schedstats
> >>     0
> >>     # kill %1
> >>     [ perf record: Woken up 1 times to write data ]
> >>     [ perf record: Captured and wrote 3.341 MB perf.data.before ]
> >>     [1]+  Terminated                 perf record -o perf.data.before --kcore -a -e intel_pt//k -m,64M
> >>     # perf script -i perf.data.before --itrace=e >/dev/null
> >>     Warning:
> >>     474 instruction trace errors
> >>
> >>   After:
> >>
> >>     # perf record -o perf.data.after --kcore -a -e intel_pt//k -m,64M &
> >>     # cat /proc/sys/kernel/sched_schedstats
> >>     0
> >>     # echo 1 > /proc/sys/kernel/sched_schedstats
> >>     # cat /proc/sys/kernel/sched_schedstats
> >>     1
> >>     # echo 0 > /proc/sys/kernel/sched_schedstats
> >>     # cat /proc/sys/kernel/sched_schedstats
> >>     0
> >>     # kill %1
> >>     [ perf record: Woken up 1 times to write data ]
> >>     [ perf record: Captured and wrote 2.646 MB perf.data.after ]
> >>     [1]+  Terminated                 perf record -o perf.data.after --kcore -a -e intel_pt//k -m,64M
> >>     # perf script -i perf.data.after --itrace=e >/dev/null
> > 
> > 
> > I'm still seeing some, probably I'm missing some CONFIG, will check
> > 
> > 	# ./perf record -o perf.data.after --kcore -a -e intel_pt//k -m,64M &
> > 	[1] 5880
> > 	# cat /proc/sys/kernel/sched_schedstats
> > 	0
> > 	# echo 1 > /proc/sys/kernel/sched_schedstats
> > 	# cat /proc/sys/kernel/sched_schedstats
> > 	1
> > 	# echo 0 > /proc/sys/kernel/sched_schedstats
> > 	# kill %1
> > 	# [ perf record: Woken up 1 times to write data ]
> > 	[ perf record: Captured and wrote 6.181 MB perf.data.after ]
> > 	[1]+  Terminated              ./perf record -o perf.data.after --kcore -a -e intel_pt//k -m,64M
> > 	# ./perf script --itrace=e -i perf.data.after > /dev/null
> > 	Warning:
> > 	18837 instruction trace errors
> > 
> > 	# ./perf script --itrace=e -i perf.data.after | head
> > 	instruction trace error type 1 time 9274.420582345 cpu 9 pid 845 tid 845 ip 0xffffffff814e6cf2 code 6: Trace doesn't match instruction
> > 	instruction trace error type 1 time 9274.422229726 cpu 39 pid 5880 tid 5880 ip 0xffffffffa030a320 code 6: Trace doesn't match instruction
> > 	instruction trace error type 1 time 9274.422231972 cpu 39 pid 5880 tid 5880 ip 0xffffffffa0315c1c code 6: Trace doesn't match instruction
> > 	instruction trace error type 1 time 9274.422236141 cpu 39 pid 5880 tid 5880 ip 0xffffffff81143263 code 6: Trace doesn't match instruction
> > 	instruction trace error type 1 time 9274.422237424 cpu 39 pid 5880 tid 5880 ip 0xffffffff8115c388 code 6: Trace doesn't match instruction
> > 	instruction trace error type 1 time 9274.422239028 cpu 39 pid 5880 tid 5880 ip 0xffffffff811428c9 code 6: Trace doesn't match instruction
> > 	instruction trace error type 1 time 9274.422239028 cpu 39 pid 5880 tid 5880 ip 0xffffffffa13279fb code 5: Failed to get instruction
> > 	instruction trace error type 1 time 9274.422242556 cpu 39 pid 5880 tid 5880 ip 0xffffffff814e9c73 code 6: Trace doesn't match instruction
> > 	instruction trace error type 1 time 9274.422258915 cpu 39 pid 5880 tid 5880 ip 0xffffffff810d7da2 code 6: Trace doesn't match instruction
> > 	instruction trace error type 1 time 9274.422258915 cpu 39 pid 5880 tid 5880 ip 0xffffffffa030a0b2 code 6: Trace doesn't match instruction
> 
> I don't think it can be CONFIG.  Can you share the branch you are using?
> Then I can test it.
> 

I built the one you mentioned in cover email:
  git://git.infradead.org/users/ahunter/linux-perf.git text_poke

jirka