Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp130704ybz; Tue, 21 Apr 2020 06:09:29 -0700 (PDT) X-Google-Smtp-Source: APiQypJtUhW6KK2mwnp1hUrfuxJ0RRKNMW9VNSf/V9816QYfCPa5QbiwGCz+ZQ2LQsYaJ8uNL+Of X-Received: by 2002:a05:6402:3129:: with SMTP id dd9mr5626078edb.121.1587474569493; Tue, 21 Apr 2020 06:09:29 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1587474569; cv=none; d=google.com; s=arc-20160816; b=F8qrKPYFDLfWYnbDF2apIWwEw126Uv6qkyj3ow1CIZZeykoe5QXroTUtv/lie7hQ2W YvmCzdUzkmPFNQv2Ne/ix8DlUwJJQH70ojgjKK9yCEXM5v8qbYc46ATZBu6qOfUThUl/ Ck8wKTT290IVLNmlOSMAojAzUYrEOjR8/VXtgiaNJPaZKbg5JqPQ+3/O6Y4lR914EUht GlO5euZNywXiYbWvB2F6ZelK5H72TpVoaxL6726LbniCKAmYYpRTT6x6IDb4Eu/kdSSD a6G0hxOXz5T4tD9zOZnVA10zqJknXD0PiDAgqbuaxBTaQKlFYmo3L8kSscnpPZIPvyj0 iilA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:organization:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:ironport-sdr:ironport-sdr; bh=zYRtFLjefRPO0J63z85ps/mc7v2aEgRIPm+qqPzSbko=; b=f0eSx0o6muqdcWaWY1DoYbMNr3ceN3gy2XKHeU5ZVCuJkHAjpGVf8b3GLgPOYfdnxa YORCGamgS/yzZw8Gxl/IJIPv32bjya8jm8s0u0ODF5qZpDAXuGPmSdkFwK1/2B++7D/W dcylEVIGRbMAVdvvRKsAsSNT14RCRDH/+Ub2BIhI6aNuCWLM3dAFv2bMQrIMCSfUomwo zuw8riqIV7rs5jCM/gpGD0y9pHRKGu3VU2msXvlHVBWUtA1lFxclm2r/JbCylPmojAIu fyp6mzSyS+bLhY5honX7s/9CNVaa5ezA/nbW6ilScjBpSht9o5SmyDmL4HrRzKMaqQGu k8Vw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id qt4si1473654ejb.447.2020.04.21.06.09.03; Tue, 21 Apr 2020 06:09:29 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728884AbgDUNHH (ORCPT + 99 others); Tue, 21 Apr 2020 09:07:07 -0400 Received: from mga18.intel.com ([134.134.136.126]:43845 "EHLO mga18.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726628AbgDUNHH (ORCPT ); Tue, 21 Apr 2020 09:07:07 -0400 IronPort-SDR: 2twUAlpQJI1tm0a5GnYzRziT5RSA5vxgKSaLk1TujSC0zTeI2EQ15ucPZ83/swjgGjWKYoYOwA QkSpukuw2ojA== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Apr 2020 06:07:03 -0700 IronPort-SDR: zFkVyC6mhHM0WZz4UZ6Z21PYYWCWic5iCbW1pt7UsKjoBAVw7Usu3KxbuW4uCum52yPBZ4MY1e /3TQ405MYqrg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.72,410,1580803200"; d="scan'208";a="279631889" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by fmsmga004.fm.intel.com with ESMTP; 21 Apr 2020 06:07:01 -0700 Received: from andy by smile with local (Exim 4.93) (envelope-from ) id 1jQscB-002F84-V1; Tue, 21 Apr 2020 16:07:03 +0300 Date: Tue, 21 Apr 2020 16:07:03 +0300 From: Andy Shevchenko To: Joe Perches Cc: Sergey Senozhatsky , Steven Rostedt , Petr Mladek , linux-kernel@vger.kernel.org, Rasmus Villemoes , Andrew Morton Subject: Re: [PATCH v3 0/3] lib/vsprintf: Introduce %ptT for time64_t Message-ID: <20200421130703.GL185537@smile.fi.intel.com> References: <20200415170046.33374-1-andriy.shevchenko@linux.intel.com> <20200415132011.624f35f6@gandalf.local.home> <20200416023425.GB30641@jagdpanzerIV.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Apr 15, 2020 at 07:46:27PM -0700, Joe Perches wrote: > On Thu, 2020-04-16 at 11:34 +0900, Sergey Senozhatsky wrote: > > On (20/04/15 13:20), Steven Rostedt wrote: > > > On Wed, 15 Apr 2020 20:00:43 +0300 > > > Andy Shevchenko wrote: > > > > > > > It is a logical continuation of previously applied %ptR for struct rtc_time. > > > > We have few users of time64_t that would like to print it. > > > > > > > > Andrew, since Petr can't pay attention on this perhaps it can be passed thru > > > > your tree? > > > > > > > > Sergey, Steven, what do you think? > > > > > > I'm fine with these changes. Sergey, what do you think? > > > > I'm not against it in general, I'm slightly concerned if "two users" > > is enough of a justification for new vsprintf() specifier. > > Me too as separate functions could be used here. If we drop T in favour of ' ' (space) as delimiter, we will immediately get 5 or 6 users (I didn't check for new ones during last couple of years though). -- With Best Regards, Andy Shevchenko