Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp140551ybz; Tue, 21 Apr 2020 06:20:34 -0700 (PDT) X-Google-Smtp-Source: APiQypKfaUK83daegR8PkqDBZgI6ycHmNHFFMXxpg7+i2Iy9Nb0PMFqPZIo4v3TiVQjdLP8Mepov X-Received: by 2002:a50:cd17:: with SMTP id z23mr18318812edi.191.1587475233686; Tue, 21 Apr 2020 06:20:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1587475233; cv=none; d=google.com; s=arc-20160816; b=GM+2ybanNVuxsJ7SVYYD1zAWFY+BZUX55GnmsS++gNMNUaYpyr7kyr/d9LUEhJqbY3 yKszboNKwXhugaDkYtqlyoLiEVVv8iky+3O47o9SmV1k5Me2j3bVfNBLkXbp1LDO6wvi mv0VgI8v2C5a7WxL7PTSDFRwsLH3wFcFLd06EOZVy9rQ+jjJJm2nOoLwINddVAxPwwkF nsqxbN8juPluDcNzitGUgs3Qklufd7BXwxong7PUXUuI515adBtjO9mUbRB8DdC2FhRD HurznQG0cOe7r7BTqrwaMIx5pGp8GRjgfYdWu++pkTpIgS3CY1w4ZLpBSbprx6Q1/YWG UmWA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=eQSksNnr16lv473MUndY75YiFvq7xp0brkXvXdv6kL0=; b=derE01kVYl2/iynY5M4MQtQJQTxgpTIyeT+Ce3cqM8aXUYgQ97Q8silYGtsQukbyQO RHzqqNSs+A5BResu6Ma4gw5ARGAStsqrbqMn3YX8vxBPS3P9oQSHoCyEEl7qo3pB5FlU JIF7exLRlU9Ly8UrdnTKtwJvfrKKSm0tnczbHAdrYQBdnxT+vV2yALRJTV6lHqTwY0qi iYZI4rRWfi/FegPw1CXBFooNiLJ4F9y+YfzLqZeCwuv7JEBunXmiVgx4xWJbrPhEMKBm IF/2MurI1rxj9B5qYv191ooaPRWyI4JygYLp7aQ5hRdG/VY9F1xARxa8qVj8yrnv1iIz J8fg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@cirrus.com header.s=PODMain02222019 header.b=bsL2mm9f; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=cirrus.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id bs23si1533842edb.203.2020.04.21.06.20.09; Tue, 21 Apr 2020 06:20:33 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@cirrus.com header.s=PODMain02222019 header.b=bsL2mm9f; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=cirrus.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728956AbgDUNQo (ORCPT + 99 others); Tue, 21 Apr 2020 09:16:44 -0400 Received: from mx0b-001ae601.pphosted.com ([67.231.152.168]:39440 "EHLO mx0b-001ae601.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728337AbgDUNQn (ORCPT ); Tue, 21 Apr 2020 09:16:43 -0400 Received: from pps.filterd (m0077474.ppops.net [127.0.0.1]) by mx0b-001ae601.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 03LDBHuf013669; Tue, 21 Apr 2020 08:15:46 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cirrus.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=PODMain02222019; bh=eQSksNnr16lv473MUndY75YiFvq7xp0brkXvXdv6kL0=; b=bsL2mm9fuCYb7w8ukaP/lJEpAicOMG/62nKFIXRJiItvsAejwDb8ZUTrqs2rTRwRVjvr YYYCt0axmdKqoCNMXAUWRJLwu4pgxTDvPFpglkIicGdxh3YxiUwUCWQDorQHEXAClom8 1fxHf9dIRm2ZZaJiqm/MQjnYejeUfPHE7LxZgfqiR6rb8E5XD4cxYskY90E9718xCVNk 77dwr67UykuFNckrXG1h/z648JM9on0+FHVpcJDuodIMEdEvXEnu3DnRMysd6F1yFQlf Ed6s3Ht/cCbQ5Vc8rqZOKsq1y5QMS1na3BAOjLb5aE/toR8hP2KNk/jsNDKd4+/lOJaU 6g== Authentication-Results: ppops.net; spf=fail smtp.mailfrom=ckeepax@opensource.cirrus.com Received: from ediex01.ad.cirrus.com ([87.246.76.36]) by mx0b-001ae601.pphosted.com with ESMTP id 30fwyqmxnq-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT); Tue, 21 Apr 2020 08:15:46 -0500 Received: from EDIEX01.ad.cirrus.com (198.61.84.80) by EDIEX01.ad.cirrus.com (198.61.84.80) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1591.10; Tue, 21 Apr 2020 14:15:43 +0100 Received: from ediswmail.ad.cirrus.com (198.61.86.93) by EDIEX01.ad.cirrus.com (198.61.84.80) with Microsoft SMTP Server id 15.1.1591.10 via Frontend Transport; Tue, 21 Apr 2020 14:15:43 +0100 Received: from ediswmail.ad.cirrus.com (ediswmail.ad.cirrus.com [198.61.86.93]) by ediswmail.ad.cirrus.com (Postfix) with ESMTP id 6756D2AB; Tue, 21 Apr 2020 13:15:43 +0000 (UTC) Date: Tue, 21 Apr 2020 13:15:43 +0000 From: Charles Keepax To: Shengjiu Wang CC: , , , , , , , , , , , Subject: Re: [PATCH] ASoC: wm8960: Fix wrong clock after suspend & resume Message-ID: <20200421131543.GG44490@ediswmail.ad.cirrus.com> References: <1587468525-27514-1-git-send-email-shengjiu.wang@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <1587468525-27514-1-git-send-email-shengjiu.wang@nxp.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Proofpoint-SPF-Result: fail X-Proofpoint-SPF-Record: v=spf1 include:spf-001ae601.pphosted.com include:spf.protection.outlook.com ip4:5.172.152.52 -all X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 suspectscore=0 spamscore=0 mlxscore=0 adultscore=0 priorityscore=1501 mlxlogscore=999 clxscore=1011 phishscore=0 impostorscore=0 bulkscore=0 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2003020000 definitions=main-2004210105 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Apr 21, 2020 at 07:28:45PM +0800, Shengjiu Wang wrote: > After suspend & resume, wm8960_hw_params may be called when > bias_level is not SND_SOC_BIAS_ON, then wm8960_configure_clocking > is not called. But if sample rate is changed at that time, then > the output clock rate will be not correct. > > So judgement of bias_level is SND_SOC_BIAS_ON in wm8960_hw_params > is not necessary and it causes above issue. > > Fixes: 3176bf2d7ccd ("ASoC: wm8960: update pll and clock setting function") > Signed-off-by: Shengjiu Wang > --- Acked-by: Charles Keepax Thanks, Charles