Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp175441ybz; Tue, 21 Apr 2020 07:01:40 -0700 (PDT) X-Google-Smtp-Source: APiQypJiRqQcETljTshmKBGc5on1pSfYoIgRjxQr/94nfaU6ag10zhyyb7tH5ld2aV6My/0e/YwY X-Received: by 2002:a7b:c772:: with SMTP id x18mr5304033wmk.39.1587477699994; Tue, 21 Apr 2020 07:01:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1587477699; cv=none; d=google.com; s=arc-20160816; b=ncHavGN4GYMfELTku9YhgjIlCjacqFHTqLSZOpwynfUV03YRNnjIzJkndYBdOB5tiB vELDDq4GllzqXn907JNhm1zeUSmRl1E2Z5VRomJuGE+0of6ozp+UmKMPKGK6YbBhQ6N0 KoDSPu0qDHGJUR3AHgwHnDlXCGCjjH0GtTCyI2GzDsQfn+bMWjXwwQfTxcgVrHDvAKqO Cc/WUC3PpNNrTdTC1DVm5nS9Lye8t7fCcfH9tcNO0ltkEdIEw7l9DjaYeguKQnIsFrFM S0TCUPMP0NDdxNJtUnTB0oUQyrEVVGheCOxKDRlmSDo351eVwCWGp4bnzcOEm/TVE3BY 6zuw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:mime-version:user-agent:date:message-id:subject:cc :autocrypt:from:to; bh=GNiU+EL5AIYbNB8aQfXUgHJBCXStKLqMl7Sl4RLhDS4=; b=ElxMcsOTclV8CK4vYmU6mQh3POrvpZswvg2hwPWt/1UJqByBd87/K8+Ub4dG/3Ng2w TnQ2lqZxYkuwIIKNUE/a8FxvhLr9o0DVuVsuCy5POjtoOnpPMVWr8UG3ThDshlF/TpFJ 87SbrNm+CVe4DQ5Y3drI6NQvY3v1Q6yvPP0kQ08zuSN7QfC3F43OjVhb8FzW6jKTPKs+ doldg3xT2Obnj8aMLmKX6r7W3ez2Qh5iXK2PX7Lp9ZsablLnS2OXh3puoBj1t9BHw0Dv pflCCMDmzuKjzsRva25Te2pd01Yriws4xE6rkj95pIm4UiMn76ANE/9z92uCk7qp/Zab 6eXw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=canonical.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id k17si1160793edf.183.2020.04.21.07.01.13; Tue, 21 Apr 2020 07:01:39 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=canonical.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728786AbgDUOAQ (ORCPT + 99 others); Tue, 21 Apr 2020 10:00:16 -0400 Received: from youngberry.canonical.com ([91.189.89.112]:59926 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728316AbgDUOAP (ORCPT ); Tue, 21 Apr 2020 10:00:15 -0400 Received: from 1.general.cking.uk.vpn ([10.172.193.212]) by youngberry.canonical.com with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1jQtRN-0000iS-5e; Tue, 21 Apr 2020 13:59:57 +0000 To: Raed Salem From: Colin Ian King Autocrypt: addr=colin.king@canonical.com; prefer-encrypt=mutual; keydata= mQINBE6TJCgBEACo6nMNvy06zNKj5tiwDsXXS+LhT+LwtEsy9EnraKYXAf2xwazcICSjX06e fanlyhB0figzQO0n/tP7BcfMVNG7n1+DC71mSyRK1ZERcG1523ajvdZOxbBCTvTitYOy3bjs +LXKqeVMhK3mRvdTjjmVpWnWqJ1LL+Hn12ysDVVfkbtuIm2NoaSEC8Ae8LSSyCMecd22d9Pn LR4UeFgrWEkQsqROq6ZDJT9pBLGe1ZS0pVGhkRyBP9GP65oPev39SmfAx9R92SYJygCy0pPv BMWKvEZS/7bpetPNx6l2xu9UvwoeEbpzUvH26PHO3DDAv0ynJugPCoxlGPVf3zcfGQxy3oty dNTWkP6Wh3Q85m+AlifgKZudjZLrO6c+fAw/jFu1UMjNuyhgShtFU7NvEzL3RqzFf9O1qM2m uj83IeFQ1FZ65QAiCdTa3npz1vHc7N4uEQBUxyXgXfCI+A5yDnjHwzU0Y3RYS52TA3nfa08y LGPLTf5wyAREkFYou20vh5vRvPASoXx6auVf1MuxokDShVhxLpryBnlKCobs4voxN54BUO7m zuERXN8kadsxGFzItAyfKYzEiJrpUB1yhm78AecDyiPlMjl99xXk0zs9lcKriaByVUv/NsyJ FQj/kmdxox3XHi9K29kopFszm1tFiDwCFr/xumbZcMY17Yi2bQARAQABtCVDb2xpbiBLaW5n IDxjb2xpbi5raW5nQGNhbm9uaWNhbC5jb20+iQI2BBMBCAAhBQJOkyQoAhsDBQsJCAcDBRUK CQgLBRYCAwEAAh4BAheAAAoJEGjCh9/GqAImsBcP9i6C/qLewfi7iVcOwqF9avfGzOPf7CVr n8CayQnlWQPchmGKk6W2qgnWI2YLIkADh53TS0VeSQ7Tetj8f1gV75eP0Sr/oT/9ovn38QZ2 vN8hpZp0GxOUrzkvvPjpH+zdmKSaUsHGp8idfPpZX7XeBO0yojAs669+3BrnBcU5wW45SjSV nfmVj1ZZj3/yBunb+hgNH1QRcm8ZPICpjvSsGFClTdB4xu2AR28eMiL/TTg9k8Gt72mOvhf0 fS0/BUwcP8qp1TdgOFyiYpI8CGyzbfwwuGANPSupGaqtIRVf+/KaOdYUM3dx/wFozZb93Kws gXR4z6tyvYCkEg3x0Xl9BoUUyn9Jp5e6FOph2t7TgUvv9dgQOsZ+V9jFJplMhN1HPhuSnkvP 5/PrX8hNOIYuT/o1AC7K5KXQmr6hkkxasjx16PnCPLpbCF5pFwcXc907eQ4+b/42k+7E3fDA Erm9blEPINtt2yG2UeqEkL+qoebjFJxY9d4r8PFbEUWMT+t3+dmhr/62NfZxrB0nTHxDVIia u8xM+23iDRsymnI1w0R78yaa0Eea3+f79QsoRW27Kvu191cU7QdW1eZm05wO8QUvdFagVVdW Zg2DE63Fiin1AkGpaeZG9Dw8HL3pJAJiDe0KOpuq9lndHoGHs3MSa3iyQqpQKzxM6sBXWGfk EkK5Ag0ETpMkKAEQAMX6HP5zSoXRHnwPCIzwz8+inMW7mJ60GmXSNTOCVoqExkopbuUCvinN 4Tg+AnhnBB3R1KTHreFGoz3rcV7fmJeut6CWnBnGBtsaW5Emmh6gZbO5SlcTpl7QDacgIUuT v1pgewVHCcrKiX0zQDJkcK8FeLUcB2PXuJd6sJg39kgsPlI7R0OJCXnvT/VGnd3XPSXXoO4K cr5fcjsZPxn0HdYCvooJGI/Qau+imPHCSPhnX3WY/9q5/WqlY9cQA8tUC+7mgzt2VMjFft1h rp/CVybW6htm+a1d4MS4cndORsWBEetnC6HnQYwuC4bVCOEg9eXMTv88FCzOHnMbE+PxxHzW 3Gzor/QYZGcis+EIiU6hNTwv4F6fFkXfW6611JwfDUQCAHoCxF3B13xr0BH5d2EcbNB6XyQb IGngwDvnTyKHQv34wE+4KtKxxyPBX36Z+xOzOttmiwiFWkFp4c2tQymHAV70dsZTBB5Lq06v 6nJs601Qd6InlpTc2mjd5mRZUZ48/Y7i+vyuNVDXFkwhYDXzFRotO9VJqtXv8iqMtvS4xPPo 2DtJx6qOyDE7gnfmk84IbyDLzlOZ3k0p7jorXEaw0bbPN9dDpw2Sh9TJAUZVssK119DJZXv5 2BSc6c+GtMqkV8nmWdakunN7Qt/JbTcKlbH3HjIyXBy8gXDaEto5ABEBAAGJAh8EGAEIAAkF Ak6TJCgCGwwACgkQaMKH38aoAiZ4lg/+N2mkx5vsBmcsZVd3ys3sIsG18w6RcJZo5SGMxEBj t1UgyIXWI9lzpKCKIxKx0bskmEyMy4tPEDSRfZno/T7p1mU7hsM4owi/ic0aGBKP025Iok9G LKJcooP/A2c9dUV0FmygecRcbIAUaeJ27gotQkiJKbi0cl2gyTRlolKbC3R23K24LUhYfx4h pWj8CHoXEJrOdHO8Y0XH7059xzv5oxnXl2SD1dqA66INnX+vpW4TD2i+eQNPgfkECzKzGj+r KRfhdDZFBJj8/e131Y0t5cu+3Vok1FzBwgQqBnkA7dhBsQm3V0R8JTtMAqJGmyOcL+JCJAca 3Yi81yLyhmYzcRASLvJmoPTsDp2kZOdGr05Dt8aGPRJL33Jm+igfd8EgcDYtG6+F8MCBOult TTAu+QAijRPZv1KhEJXwUSke9HZvzo1tNTlY3h6plBsBufELu0mnqQvHZmfa5Ay99dF+dL1H WNp62+mTeHsX6v9EACH4S+Cw9Q1qJElFEu9/1vFNBmGY2vDv14gU2xEiS2eIvKiYl/b5Y85Q QLOHWV8up73KK5Qq/6bm4BqVd1rKGI9un8kezUQNGBKre2KKs6wquH8oynDP/baoYxEGMXBg GF/qjOC6OY+U7kNUW3N/A7J3M2VdOTLu3hVTzJMZdlMmmsg74azvZDV75dUigqXcwjE= Cc: Boris Pismenny , Saeed Mahameed , Leon Romanovsky , Tariq Toukan , "netdev@vger.kernel.org" , linux-rdma@vger.kernel.org, "linux-kernel@vger.kernel.org" Subject: re: net/mlx5: IPsec, Refactor SA handle creation and destruction Message-ID: Date: Tue, 21 Apr 2020 14:59:56 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, Static analysis with Coverity has detected a potential issue with the following commit: commit 7dfee4b1d79e1800818abcfb47747b162c9a2d31 Author: Raed Salem Date: Wed Oct 23 17:04:13 2019 +0300 net/mlx5: IPsec, Refactor SA handle creation and destruction The issue is in mlx5_fpga_is_ipsec_device() in drivers/net/ethernet/mellanox/mlx5/core/fpga/ipsec.c as follows: 710 Bitwise-and with zero bit_and_with_zero: accel_xfrm->attrs.action & MLX5_ACCEL_ESP_ACTION_DECRYPT is always 0. This occurs as the logical operand of if. 711 if (accel_xfrm->attrs.action & MLX5_ACCEL_ESP_ACTION_DECRYPT) { Logically dead code (DEADCODE) 712 err = ida_simple_get(&fipsec->halloc, 1, 0, GFP_KERNEL); 713 if (err < 0) { 714 context = ERR_PTR(err); 715 goto exists; 716 } 717 718 sa_ctx->sa_handle = err; 719 if (sa_handle) 720 *sa_handle = sa_ctx->sa_handle; 721 } in include/linux/mlx5/accel.h MLX5_ACCEL_ESP_ACTION_DECRYPT is defined as zero: 50 enum mlx5_accel_esp_action { 51 MLX5_ACCEL_ESP_ACTION_DECRYPT, 52 MLX5_ACCEL_ESP_ACTION_ENCRYPT, 53 }; I believe there are some other instances of this bit-wise and-ing with zero, e.g. in mlx5_fpga_ipsec_release_sa_ctx() we have: 855 if (sa_ctx->fpga_xfrm->accel_xfrm.attrs.action & 856 MLX5_ACCEL_ESP_ACTION_DECRYPT) Colin