Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp223272ybz; Tue, 21 Apr 2020 07:53:58 -0700 (PDT) X-Google-Smtp-Source: APiQypJNJPTEofl7vS91X98EcRHNCsYB4cZ3WNfpY77s0FOyDVuSGeHJjn1iAxDb+aYJyTZad5RD X-Received: by 2002:a05:6402:c84:: with SMTP id cm4mr3146872edb.316.1587480838077; Tue, 21 Apr 2020 07:53:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1587480838; cv=none; d=google.com; s=arc-20160816; b=fRJiTUqTmKffVnRse2ffAzFtE/fXtS/nzGkOoHrrTx0hPkR56BNEbOc/L1p6eEaGKV OQXWcCQaRwJQ62QZxaWKEYM2oLdvs0bfR+KWRsC19S5EgnYSjPk2DgFPi83owSqlxElm YUwy0YiPWBg0lOcklzOVyUJ+mbMfcL65zEOhPK6VMTa/toWy4Z5gl+goUHZA8aNQFtY1 dedihNcNK5vrFP7xWE2VnE2afL7C4dfFKBohmkfJsL7AfLyEisjzZChN74b56JUj7GiA WUpjk6Io0BMnJ4FOQ3o9W8b7fjVQTvpAGpFOxzekwpWw96dLCLPPrYTQ3PAreZfFgGB2 /0/Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date; bh=03kh6rxdIZPOjY8CdSkAJG0x616V02S53L1Q1l1whWM=; b=D23glsewfHUCEG/2dqLWbhFmGqsMUHcdwh1x2FGJYuaOAT2Cy8u+cMLn4160Pd54IA zyblULlGxDms1yKfmD3AcBVQEz0a2G8Q2TXEWydNGxh0AyvuWANyZR0WKppCkO9yXgLd wxM5K2besGgoMi12VBcuI4z/2AZb6E+bR4fO1bNzlWR8avjGZE+C9Gp+eKLVZAohYTdA 0XQVPai3fH5uFOE84YwnXkwQZBba3oKP7nja9ONgFJK2+DwS4XKPH5vakyS7T3qfiwzO UfSFtGOs3K4nL128qjDafsT9hdso5K7WvRIfsTJ67399FgskPkEBuN/PTkK6954t5wgO 2nuA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id m25si720816eds.232.2020.04.21.07.53.33; Tue, 21 Apr 2020 07:53:58 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728651AbgDUOuF (ORCPT + 99 others); Tue, 21 Apr 2020 10:50:05 -0400 Received: from mail.kernel.org ([198.145.29.99]:54842 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726628AbgDUOuE (ORCPT ); Tue, 21 Apr 2020 10:50:04 -0400 Received: from gandalf.local.home (cpe-66-24-58-225.stny.res.rr.com [66.24.58.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 81A72206A1; Tue, 21 Apr 2020 14:50:03 +0000 (UTC) Date: Tue, 21 Apr 2020 10:50:02 -0400 From: Steven Rostedt To: Chen Yu Cc: linux-kernel@vger.kernel.org, Peter Zijlstra , Vincent Guittot , Valentin Schneider , Ingo Molnar , Juri Lelli , Dietmar Eggemann , Mel Gorman , Ben Segall Subject: Re: [PATCH 2/2][v3] sched: Extract the task putting code from pick_next_task() Message-ID: <20200421105002.31de19ce@gandalf.local.home> In-Reply-To: <5a99860cf66293db58a397d6248bcb2eee326776.1587464698.git.yu.c.chen@intel.com> References: <5a99860cf66293db58a397d6248bcb2eee326776.1587464698.git.yu.c.chen@intel.com> X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 21 Apr 2020 18:50:43 +0800 Chen Yu wrote: > Introduce a new function put_prev_task_balance() to do the balance > when necessary, and then put previous task back to the run queue. > This function is extracted from pick_next_task() to prepare for > future usage by other type of task picking logic. > > No functional change. > > Suggested-by: Peter Zijlstra > Reviewed-by: Valentin Schneider > Signed-off-by: Chen Yu > --- > Reviewed-by: Steven Rostedt (VMware) -- Steve