Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH 1/4] loop: Refactor size calculation.
To:     Martijn Coenen <maco@android.com>
Cc:     Jens Axboe <axboe@kernel.dk>, Christoph Hellwig <hch@lst.de>,
        Ming Lei <ming.lei@redhat.com>,
        Narayan Kamath <narayan@google.com>,
        Zimuzo Ezeozue <zezeozue@google.com>, kernel-team@android.com,
        linux-block <linux-block@vger.kernel.org>,
        LKML <linux-kernel@vger.kernel.org>,
        Martijn Coenen <maco@google.com>,
        Chaitanya Kulkarni <Chaitanya.Kulkarni@wdc.com>,
        Jaegeuk Kim <jaegeuk@kernel.org>
References: <20200420080409.111693-1-maco@android.com>
 <20200420080409.111693-2-maco@android.com>
 <b546eff4-616a-8488-fc11-9b7e23d44bcf@acm.org>
 <CAB0TPYHXCRq-SVGsNBviyCAyP75oKam77W9vdsyri9fzA2tp+g@mail.gmail.com>
From:   Bart Van Assche <bvanassche@acm.org>
Message-ID: <398b9d9e-bb7c-6b95-4766-3e9bf2769a61@acm.org>
Date:   Tue, 21 Apr 2020 08:26:22 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.6.0
MIME-Version: 1.0
In-Reply-To: <CAB0TPYHXCRq-SVGsNBviyCAyP75oKam77W9vdsyri9fzA2tp+g@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 4/21/20 4:48 AM, Martijn Coenen wrote:
> On Mon, Apr 20, 2020 at 3:22 PM Bart Van Assche <bvanassche@acm.org> wrote:
>> Please also change the "kill_bdev should have truncated all the pages"
>> comment into something like "return -EAGAIN if any pages have been
>> dirtied after kill_bdev() returned".
> 
> Sure - would you prefer this to be in a separate change?

Since the comment "kill_bdev should have truncated all the pages" has to 
be moved, I think that it's fine to integrate the fix for that comment 
in this patch.

Thanks,

Bart.