Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751296AbWCCOsc (ORCPT ); Fri, 3 Mar 2006 09:48:32 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751240AbWCCOsc (ORCPT ); Fri, 3 Mar 2006 09:48:32 -0500 Received: from smtp105.rog.mail.re2.yahoo.com ([206.190.36.83]:33710 "HELO smtp105.rog.mail.re2.yahoo.com") by vger.kernel.org with SMTP id S1751138AbWCCOsb (ORCPT ); Fri, 3 Mar 2006 09:48:31 -0500 DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=s1024; d=rogers.com; h=Received:Subject:From:To:Cc:In-Reply-To:References:Content-Type:Date:Message-Id:Mime-Version:X-Mailer:Content-Transfer-Encoding; b=fqZpKE6wgvC4UmeO2Vd4zOuAA9VD/ES8aGQzPtHDJfEpGpXehSwpovR+JFpa8ikwFE9Z7CecpwGUszi5HcMnb4Gfc4C/uhgZQgDS3W92/TV37b8O+B5jfJwM4jix1MP6biEIFDbVUvdG7C4eNwzTJ2GwckOUdspQ9RZ25cBwozM= ; Subject: Re: [2.6 patch] make UNIX a bool From: "James C. Georgas" To: Adrian Bunk Cc: linux-kernel@vger.kernel.org In-Reply-To: <20060303114642.GO9295@stusta.de> References: <20060301175852.GA4708@stusta.de> <20060302173840.GB9295@stusta.de> <9a8748490603021228k7ad1fb5gd931d9778307ca58@mail.gmail.com> <20060302203245.GD9295@stusta.de> <1141335521.3582.14.camel@Rainsong.home> <20060302214423.GI9295@stusta.de> <1141361097.3582.40.camel@Rainsong.home> <20060303114642.GO9295@stusta.de> Content-Type: text/plain Date: Fri, 03 Mar 2006 09:48:46 -0500 Message-Id: <1141397326.3582.57.camel@Rainsong.home> Mime-Version: 1.0 X-Mailer: Evolution 2.4.2.1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2211 Lines: 58 On Fri, 2006-03-03 at 12:46 +0100, Adrian Bunk wrote: > On Thu, Mar 02, 2006 at 11:44:57PM -0500, James C. Georgas wrote: > > On Thu, 2006-02-03 at 22:44 +0100, Adrian Bunk wrote: > > > > > > > > > > > > We do not have to export symbols we don't want to export to modules but > > > > > needed by CONFIG_UNIX. > > > > > > > > Sorry, I must just be dense, or something. > > > > > > > > Is not the only difference between a modular driver and a built in > > > > driver supposed to be the initialization and cleanup functions? > > > > > > > > I don't see why you would have to expose any additional symbols, over > > > > and above the existing required symbols, to load your module. > > > > > > Every kernel symbol a module uses must be explicitely exported with > > > EXPORT_SYMBOL. > > > > Yes, I understand that I need to export symbols to define the interface > > to my driver. whether its a module or compiled in. This is how other > > systems interact with my driver, right? > > EXPORT_SYMBOL is only required for modules. > > > > CONFIG_UNIX uses symbols that are neither used by any other in-kernel > > > modules nor should be exported. > > > > Are you saying that AF_UNIX has to export symbols for its own private > > functions in order to call them? I guess I don't understand this. Why > > not just call them. They're in scope within the driver code, aren't > > they? > > No, this is about functions defined in other parts of the kernel. > Ok, if I understand you correctly now, there is a function defined in another part of the kernel, which is _called_ by AF_UNIX, and it is for this function that the other part of the kernel must export a symbol? But you only need to do this so that modules can use the function, because if, instead, the driver is built in, then the function is directly in scope, and can be called explicitly? > > James C. Georgas > > cu > Adrian > -- James C. Georgas - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/