Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp348136ybz;
        Tue, 21 Apr 2020 10:08:54 -0700 (PDT)
X-Google-Smtp-Source: APiQypLZ7DFitRADWtSQE3wjNtffxwi8trXqnHWP7Z1+TnAUfmUupBFF73faDuck/8DeFWZzJiT+
X-Received: by 2002:a50:9b53:: with SMTP id a19mr20240833edj.104.1587488933939;
        Tue, 21 Apr 2020 10:08:53 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1587488933; cv=none;
        d=google.com; s=arc-20160816;
        b=MXgrGJMw96+X1GmerD8wYuUzu9/Kmz0fQmVt9Z3dXLZwzyyApxYY7Lwg/m3fFX9W0h
         v4a4mOmivhwyFp+tRA97nQ9V3tnPN0GJ/D4LOOIuqmXSFTc/NRQzL0nX/NbdfsGfLPb+
         3YHRxMifKXNZ7pU8zd3Plv7BpuIGDcbY535qq73SLB7iTc+bTtikphrUlo/6oWKpVo+w
         JT40a6qitldDYfa5ERa2+/NSHYTQSsrZAlUPgMlNY7BWTcn4IS0CutIrIghyDZ0htZAT
         /C2ze9poA15DaLg4e40EMTX9zFLswbCaGchMhwRKISlsaj6SArEbOQwzjAZLnYcb6/r5
         ph9A==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:sender:dkim-signature:content-language
         :content-transfer-encoding:in-reply-to:mime-version:user-agent:date
         :message-id:from:references:cc:to:subject;
        bh=ptrpSmZOQMvw0nRhpdqpN96FKh6de9mBIaM+4ppgBy8=;
        b=xacEPhq25GTJBwrjL+di8c5wf7ArLzI1F2Jq+9fwKkYkSyIz/iCpsr3NAsAAjjfCSn
         VGBlMOFt1vS7DgAo8uQPFzhNyUIWjow+3O84VjqPpkulTv35K1YN7yK7+73llGk4tHkN
         4mOF9nZEy/qd4sJl8EVvQigaXC6udZ229y8IGp58TpbOqqK4mtkv+TCvroUsQ8IIokk2
         dVxI3DFRE8ZSYib0YZiWR4LnEAW0YV4uR0+TMObQzpZjyQ2MsaRv3nj4T6g6Iz7Vncr1
         f3FhjB4IPUKMnmb9U+1lxh5u6dIW0uCeW7ojpmrgFivutUkwrknqzLvxlCYZRAbXN7XE
         mN6w==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=pass header.i=@nvidia.com header.s=n1 header.b=X4b8B6RI;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18])
        by mx.google.com with ESMTP id q18si1989051eju.4.2020.04.21.10.08.30;
        Tue, 21 Apr 2020 10:08:53 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Authentication-Results: mx.google.com;
       dkim=pass header.i=@nvidia.com header.s=n1 header.b=X4b8B6RI;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1729365AbgDUREs (ORCPT <rfc822;1dalishi1@gmail.com> + 99 others);
        Tue, 21 Apr 2020 13:04:48 -0400
Received: from hqnvemgate26.nvidia.com ([216.228.121.65]:12335 "EHLO
        hqnvemgate26.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1729040AbgDUREn (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 21 Apr 2020 13:04:43 -0400
Received: from hqpgpgate102.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate26.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA)
        id <B5e9f279d0000>; Tue, 21 Apr 2020 10:04:29 -0700
Received: from hqmail.nvidia.com ([172.20.161.6])
  by hqpgpgate102.nvidia.com (PGP Universal service);
  Tue, 21 Apr 2020 10:04:42 -0700
X-PGP-Universal: processed;
        by hqpgpgate102.nvidia.com on Tue, 21 Apr 2020 10:04:42 -0700
Received: from DRHQMAIL107.nvidia.com (10.27.9.16) by HQMAIL107.nvidia.com
 (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Tue, 21 Apr
 2020 17:04:42 +0000
Received: from [10.2.165.49] (10.124.1.5) by DRHQMAIL107.nvidia.com
 (10.27.9.16) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Tue, 21 Apr
 2020 17:04:40 +0000
Subject: Re: [PATCH 4.19.113 0/3] Fix for long operation cmds busy detection
To:     Ulf Hansson <ulf.hansson@linaro.org>,
        Greg KH <gregkh@linuxfoundation.org>
CC:     Adrian Hunter <adrian.hunter@intel.com>,
        "(Exiting) Baolin Wang" <baolin.wang@linaro.org>,
        Kate Stewart <kstewart@linuxfoundation.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        Bradley Bolen <bradleybolen@gmail.com>,
        Faiz Abbas <faiz_abbas@ti.com>,
        Thierry Reding <thierry.reding@gmail.com>,
        Jon Hunter <jonathanh@nvidia.com>,
        Bitan Biswas <bbiswas@nvidia.com>,
        Aniruddha Tvs Rao <anrao@nvidia.com>,
        linux-tegra <linux-tegra@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        "linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>
References: <1587150844-12003-1-git-send-email-skomatineni@nvidia.com>
 <20200419072030.GB3544449@kroah.com>
 <6911ee08-1376-a515-9393-1ebc6cc6a255@nvidia.com>
 <20200419165204.GA3697430@kroah.com>
 <CAPDyKFrdCip_r0fq2=FswsR8iRtC-Gqv2gbvT6PqFXYcaZyBkw@mail.gmail.com>
From:   Sowjanya Komatineni <skomatineni@nvidia.com>
Message-ID: <13eb79ee-726f-3863-2dec-9318d109602c@nvidia.com>
Date:   Tue, 21 Apr 2020 10:04:40 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.9.0
MIME-Version: 1.0
In-Reply-To: <CAPDyKFrdCip_r0fq2=FswsR8iRtC-Gqv2gbvT6PqFXYcaZyBkw@mail.gmail.com>
X-Originating-IP: [10.124.1.5]
X-ClientProxiedBy: HQMAIL105.nvidia.com (172.20.187.12) To
 DRHQMAIL107.nvidia.com (10.27.9.16)
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1;
        t=1587488669; bh=ptrpSmZOQMvw0nRhpdqpN96FKh6de9mBIaM+4ppgBy8=;
        h=X-PGP-Universal:Subject:To:CC:References:From:Message-ID:Date:
         User-Agent:MIME-Version:In-Reply-To:X-Originating-IP:
         X-ClientProxiedBy:Content-Type:Content-Transfer-Encoding:
         Content-Language;
        b=X4b8B6RISNkMpes5aFvS0NbS4ZoSdsoygr/nfq82VDVK4rOQVT7l0HxOeEEKgOkS8
         dViFgcYxJiNB+IWFL8aZ85B8BdzEafppqmxfKOJk5qTFXBo2suOB9JhWUz/GPSPTBZ
         z9ztgPu0XiyA+Dh2JVhQOQmx3yLWS7NQ0P11kgn28YONJ4+SfnKGokwYXmcvh+i8+/
         NAyf3VmKR1tNjRIgnodBxg6gWBoQblu7rtbl2j0hkHanC11PgXobGkdb3b8Alweg4r
         1aNUpctGLA6cm+4CSFPCl1VWV+MgqKFkChxVzkM0Yqr6l0PcD/Rhh1aWFfJoOHF3kJ
         pHdQ0o4NwkIuA==
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 4/20/20 12:01 AM, Ulf Hansson wrote:
> External email: Use caution opening links or attachments
>
>
> On Sun, 19 Apr 2020 at 18:52, Greg KH <gregkh@linuxfoundation.org> wrote:
>> On Sun, Apr 19, 2020 at 09:23:39AM -0700, Sowjanya Komatineni wrote:
>>> On 4/19/20 12:20 AM, Greg KH wrote:
>>>> External email: Use caution opening links or attachments
>>>>
>>>>
>>>> On Fri, Apr 17, 2020 at 12:14:01PM -0700, Sowjanya Komatineni wrote:
>>>>> This series includes manually backported changes that implements Tegra
>>>>> specific timeout callback to switch between finite and infinite HW busy
>>>>> detection wait modes.
>>>>>
>>>>> sdhci-tegra driver patch implements set_timeout callback based on one of
>>>>> the sdhci host driver patch that refactors sdhci_set_timeout and allows
>>>>> drivers to call __sdhci_set_timeout with their timeout callback
>>>>> implementation.
>>>>>
>>>>> Both of these patches are manually backported in this series.
>>>> Is this a bugfix or a new feature?  I can't tell, but it feels like it's
>>>> a new feature.  What's wrong with just using the 5.4.y kernel tree?
>>>>
>>>> thanks,
>>>>
>>>> greg k-h
>>> Ulf recent patches for increased timeout adds capability
>>> MMC_CAP_NEED_RSP_BUSY for sdhci-tegra as well.
>>>
>>> So, it will always use R1B for R1B type commands so there are no known bugs
>>> or failures with mmc devices we use on our platforms.
>> I have no idea what this means, sorry.
>>
>>> So, we can treat this patch as an improvement for long operation commands
>>> where HW will wait as long as device is busy.
>> Ok, so this isn't a regression and can't match the stable kernel rules,
>> sorry.
> Let me help to clarify. This isn't a regression, correct. However, the
> patch fixes a long outstanding bug for sdhci-tegra.
>
> For some SD/MMC commands, the mmc core may provide a long busy timeout
> trusting the mmc host to cope with it. It has turned out that
> sdhci-tegra didn't, thus it may report a cmd-timeout error, while in
> fact it shouldn't.
>
> I believe that is what the small series of patches should be addressing.
>
> Kind regards
> Uffe

Hi Greg,

Yes, we we don't have failure as of today with mmc devices we are using 
on our platforms.

But this is something thats missing from the beginning to handle 
commands that takes longer than max host timeout and it may fail if any 
operation takes more than max host timeout limit.

So, can we please have this applied to 4.19.113? I will also send 
patches to backport for 5.4 and 5.5?

Thanks

Sowjanya