Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 21 Apr 2020 10:05:44 -0700
From:   Jakub Kicinski <kuba@kernel.org>
To:     Tang Bin <tangbin@cmss.chinamobile.com>
Cc:     khalasa@piap.pl, davem@davemloft.net, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org,
        Shengju Zhang <zhangshengju@cmss.chinamobile.com>
Subject: Re: [PATCH] net: ethernet: ixp4xx: Add error handling
 inixp4xx_eth_probe()
Message-ID: <20200421100544.0de3fbba@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
In-Reply-To: <71697844-cc03-9206-1594-b8af02f38018@cmss.chinamobile.com>
References: <20200412092728.8396-1-tangbin@cmss.chinamobile.com>
        <20200412113538.517669d9@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
        <71697844-cc03-9206-1594-b8af02f38018@cmss.chinamobile.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue, 21 Apr 2020 12:46:37 +0800 Tang Bin wrote:
> Hi Jakub:
>=20
> On 2020/4/13 2:35, Jakub Kicinski wrote:
> > On Sun, 12 Apr 2020 17:27:28 +0800 Tang Bin wrote: =20
> >> The function ixp4xx_eth_probe() does not perform sufficient error
> >> checking after executing devm_ioremap_resource(),which can result
> >> in crashes if a critical error path is encountered.
> >> =20
> > Please provide an appropriate Fixes: tag. =20
>=20
> Thanks for your reply.
>=20
> I don't know whether the commit message affect this patch's result. If so,
>=20
> I think the commit message in v2 needs more clarification. As follows:
>=20
>  =C2=A0=C2=A0=C2=A0 The function ixp4xx_eth_probe() does not perform suff=
icient error=20
> checking
>=20
> after executing devm_ioremap_resource(), which can result in crashes if=20
> a critical
>=20
> error path is encountered.
>=20
>  =C2=A0=C2=A0=C2=A0 Fixes: f458ac479777 ("ARM/net: ixp4xx: Pass ethernet =
physical base=20
> as resource").
>=20
>=20
> I'm waiting for you reply actively.

Please repost with the tag included.