Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp423498ybz; Tue, 21 Apr 2020 11:40:01 -0700 (PDT) X-Google-Smtp-Source: APiQypLaCK/6HnlUvnuRNvmiBL0I03H/Uv/NR2BwVBnBe7UHiog0bnvP6ZqzjU9BKAl0epcmu9Wi X-Received: by 2002:a50:c3c2:: with SMTP id i2mr10518185edf.227.1587494400966; Tue, 21 Apr 2020 11:40:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1587494400; cv=none; d=google.com; s=arc-20160816; b=erBRhASU4GA91yrSs2fhQ/Y+oCqX5w9jbrhaFTkMmwqma2yiQSWsz+g+MPx/6Y9QP2 qtJGTcezrQVAKJtYpTBlenga66HStEW3OzMu7Kksj2xB5YN9dGWaXGONkbzxwc29jR94 Huh+s0mb1Ctfaj2GEf06qby/nnlOKrmWlnImnJWdIjDcHkLlBzFWmN99//L8ApyoJ0M1 prucfsJEtXae8YNyCGGbfJcl4rJfHxOveTrwNVk5Hg3t5ZXioXv3Nxex6+KDOMMPxLUn 8NTkTLAXPrIjHJB+mg0pYe3wVESnZkuAdYV9vN7S3BXi2lcu+GGnaO9JXxTzaBPP4UMI ByqQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :ironport-sdr:ironport-sdr; bh=cgqFTspdI78dSyHCOL7jmdnuUIcbzKnEajTQZC9R++0=; b=JlbIDnZ91QOVjnKfCpfNk8CniQ5pFruFon1BS5IYdU59M9mOB8bJVdKpq7s2FyNEHs Z2miinN9i+8jEcggvHjN3ZXa4ldHf0Jd7xjBZw/4PZKQZaGxbBNDmar6qaDLXKlRxrhL gXOyvoTViV8e7c0coTAA7iKbnsNrR8aoFsAPSo2lQKJ3hju7eduRWZhmZpK0+kQVsRWs RnLjNriiEVQOL41bGfOipBL9KvvVcmaWLeqHjnk5ZVoz4mXs2xkAe9p/9/Xxb+ktPbHH iORsSYhFCjLmTLbEHeJ+CRvAigcJg4lhEW+SvTovg1QVZOqO6LexrD1Vb3GrWHXrpf/b Dvjw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id bi3si2445094edb.116.2020.04.21.11.39.37; Tue, 21 Apr 2020 11:40:00 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726628AbgDUSgQ (ORCPT + 99 others); Tue, 21 Apr 2020 14:36:16 -0400 Received: from mga11.intel.com ([192.55.52.93]:46292 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725930AbgDUSgP (ORCPT ); Tue, 21 Apr 2020 14:36:15 -0400 IronPort-SDR: scvtaxEkEngtdjnBdaN6kHmNvCqceikiJP4GD7vEYgf4AMdvtrdyz429rhtp46ep+h22R2fd3r I8H42nMWZJxQ== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Apr 2020 11:36:15 -0700 IronPort-SDR: htjAKHyunl6st7EPXfAJmsqzIZ/0M/Kh4zbkR26LdWAaQerXxhJ8Cef19+An/ZUDAks4TOdXPc 7DtBkWX+G4lQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.72,411,1580803200"; d="scan'208";a="273617738" Received: from tassilo.jf.intel.com (HELO tassilo.localdomain) ([10.7.201.21]) by orsmga002.jf.intel.com with ESMTP; 21 Apr 2020 11:36:15 -0700 Received: by tassilo.localdomain (Postfix, from userid 1000) id 325D63019B6; Tue, 21 Apr 2020 11:36:15 -0700 (PDT) Date: Tue, 21 Apr 2020 11:36:15 -0700 From: Andi Kleen To: Jiri Olsa Cc: Arnaldo Carvalho de Melo , lkml , Ingo Molnar , Namhyung Kim , Alexander Shishkin , Peter Zijlstra , Michael Petlan , Joe Mario , Kajol Jain , John Garry Subject: Re: [PATCH 3/3] perf stat: Add --metrics-file option Message-ID: <20200421183615.GD608746@tassilo.jf.intel.com> References: <20200421181337.988681-1-jolsa@kernel.org> <20200421181337.988681-4-jolsa@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200421181337.988681-4-jolsa@kernel.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > +--metrics-file file:: > +Read metrics definitions from file in addition to compiled in metrics. > + You would need to define the syntax and format. Perhaps in a separate man page. Also there are some asserts that can be triggered by expressions. I think you should fix those too and convert them to errors. -Andi