Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp485104ybz; Tue, 21 Apr 2020 12:57:11 -0700 (PDT) X-Google-Smtp-Source: APiQypJl1OuqM5MWqbZAmaYUlvNK1UP2ExYEXG9NiyyDMhUZwMHOdMNB2I41UntSQScRxS56Jw/n X-Received: by 2002:a17:906:4bc3:: with SMTP id x3mr23327567ejv.38.1587499031777; Tue, 21 Apr 2020 12:57:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1587499031; cv=none; d=google.com; s=arc-20160816; b=0dGSsfwJWd5r4UJtbYRiBhcxqQdl1NjGWEWgA/p4Q5+mu+QVQWwfQxow+IQcRpqulJ On+Fkmmd0JEdCSuDF3z6eC2gGiIuievfOum3IOZRHqHKNj+o+WmsqGygZKo5jssqyazh F8IgqZjZcXYY1Yzplyo5s8r+n42A7CjruZJo/+FJpQnjaDhGZbzv5tE9l92GrBOtnHDS t/G31q5dO9dn4nc1atRn94GA6cgELOKCGRZ2Sr/VgPNzfMbASehDbnK42DJzzKroWCqB j0CJZkvOQy2ucjjMfZZqGnr4gJ/Eq/MIC4g+nUK3b4IJfi3DL1F4BCtG8ZIMaTvW4rFR Q2tg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:organization:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:ironport-sdr:ironport-sdr; bh=Ngo7CKRRwu0gymfx7EAp5VHfH+K3PaNmQjkK1FBzR9w=; b=XTRX7LZGppu/tck2+kQnVXksK9LrHDf9/ZOlHlnpdkXVA/swJjD0Hej+wKHz3JUEGl 4Fq1MDRSBKp5Cm/01R5mWp+2iUrXLkG2sBU5GVG+UpiO6Pzv1BrvsiWzCq+AufAH33Eh LQkSzttQoV7mU0KddCfLqtq+5HH9IxRm8ogFR3PKvmgUHmKmE/PHpO0mDf95WxzpT5lF QpGEKopBNhvzVEg4IXOAOeoiXdwA07x5fBdnXBD8m5wuzVgkGOVdr0x1bz56vXxG2DJV ffM07b2dIBwiwJ8P6fibzocblX9GJc+EMHDnGL+H/Rs+sYrhmyw9P8xS/BpnRAh+AycW yQ4w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id by26si2223945edb.144.2020.04.21.12.56.49; Tue, 21 Apr 2020 12:57:11 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726228AbgDUTyH (ORCPT + 99 others); Tue, 21 Apr 2020 15:54:07 -0400 Received: from mga17.intel.com ([192.55.52.151]:48553 "EHLO mga17.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725987AbgDUTyG (ORCPT ); Tue, 21 Apr 2020 15:54:06 -0400 IronPort-SDR: sRFZdjmZfWE7GSX/iJccG5wnFLZ7P7RogLTw2PqqGmD5QJRmfs09PcS0NBvv9u65R8zfnCZULW /+A0MGGDAdUA== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Apr 2020 12:54:06 -0700 IronPort-SDR: u0PucUAwlTW5D/vEtBMVccgXiyEn4WGQVAczLuFaWatEh/EbMdaAfn9ZmlhHEG39aYysNO3bSz gxfIScmQTOqg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.72,411,1580803200"; d="scan'208";a="247264606" Received: from mnchalux-mobl2.gar.corp.intel.com (HELO localhost) ([10.252.44.234]) by fmsmga008.fm.intel.com with ESMTP; 21 Apr 2020 12:54:04 -0700 Date: Tue, 21 Apr 2020 22:54:03 +0300 From: Jarkko Sakkinen To: Hans de Goede Cc: linux-integrity@vger.kernel.org, stable@vger.kernel.org, Peter Huewe , Jason Gunthorpe , Arnd Bergmann , Greg Kroah-Hartman , open list Subject: Re: [PATCH v2] tpm/tpm_tis: Free IRQ if probing fails Message-ID: <20200421195403.GA46589@linux.intel.com> References: <20200416160751.180791-1-jarkko.sakkinen@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Apr 21, 2020 at 03:23:19PM +0200, Hans de Goede wrote: > Hi, > > On 4/16/20 6:07 PM, Jarkko Sakkinen wrote: > > Call disable_interrupts() if we have to revert to polling in order not to > > unnecessarily reserve the IRQ for the life-cycle of the driver. > > > > Cc: stable@vger.kernel.org # 4.5.x > > Reported-by: Hans de Goede > > Fixes: e3837e74a06d ("tpm_tis: Refactor the interrupt setup") > > Signed-off-by: Jarkko Sakkinen > > I can confirm that this fixes the "irq 31 nobody cared" oops for me: > > Tested-by: Hans de Goede Hi, thanks a lot! Unfortunately I already put this out given the criticality of the issue: https://lkml.org/lkml/2020/4/20/1544 Sincere apologies that I couldn't include your tested-by but the most important thing is to know that it works now. /Jarkko