Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp494731ybz; Tue, 21 Apr 2020 13:07:57 -0700 (PDT) X-Google-Smtp-Source: APiQypKzaz1Pi/xE3MtzDoHWljCsi255mufPSzi5/gmL+M+WpC0AqZlZIJ09AijAr8WMYOGN/7dK X-Received: by 2002:aa7:c610:: with SMTP id h16mr19553884edq.323.1587499677683; Tue, 21 Apr 2020 13:07:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1587499677; cv=none; d=google.com; s=arc-20160816; b=NVeZ19cUqrCoSDOSxa4zJVN9Uz5fdj25Wcxs7srRKsLjZdOTS4y9rRp4YNqrs4grOY 5AbnuQSf9tVMtys08nLLjODGAWOZHT4iSIxXoOhd31tpFjUcOEE+LLSgDMtOMcMxVn4B MYpaGysZv94rGuGVT1V+DtV54YzVDa7fVJx2ORgcpbgt9Bf0xom91aI/YcTacQ/bGeAf 0ARezQGR0Rd2ypS55OWCcFW/Y2ZK2OSfOt850QTQPPrxKqYFN0Df/dS4A9UZyhCYO+WU y5rvzvGhXmCXGhALLIpDynlun6izFDbaeXPN+paI1EUMJZ3XHTSIAxzFBwmuWIUnm1AN 7a5w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :ironport-sdr:ironport-sdr; bh=J9u3Az+7zvon5rEyszrFERLqoRLf5S1zU6tSuyIWzP4=; b=YPpp5wHGBAXYPpuNGNHu+Q4xARbMCyYgCaP5duBRfrDwVDIGsqTYaxoA7n2XRiFRT4 2Mrp3i2mQyfFz3u7wTjrOtC30OyenUpIK7oxjZI3iyCduMjlaDzocGbiW3ro71xLkBmI JcyuaRkmstXfYNFnos+P79b+XaQvzv9at0n4o/w+G/c+YhTD8+SJSo9qRfRsONxBAI7I ESxuuSuTIOzPG7EAvd71hMObDbfljInVv4S/dxKSx8FW2yqOL/cfInkeTNre7rtjwaa4 TY4j3+5tVDxVlQmDFxQbCy2HcEYhXdjRuoh7rKEdy/c47kEHJISVds7mn+vX9SdrflEP lAOQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id cw10si2171246edb.54.2020.04.21.13.07.34; Tue, 21 Apr 2020 13:07:57 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726121AbgDUUGc (ORCPT + 99 others); Tue, 21 Apr 2020 16:06:32 -0400 Received: from mga06.intel.com ([134.134.136.31]:1677 "EHLO mga06.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725987AbgDUUGc (ORCPT ); Tue, 21 Apr 2020 16:06:32 -0400 IronPort-SDR: L4nZDE7pqRowTFaaI2BK0srPc+H5edwjFPNz4189iHpuc/w50FvUpDANIGc/t5OASve1kRkOVF jGaW8a9Z4tQg== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Apr 2020 13:06:31 -0700 IronPort-SDR: RO23W0D2pXrfBWwzMV3NBUTnrL4YYUAL8T/lx+vgIyA22DauPPQtjCZGEMJ/0QjHOyTxzLsgnR OGJheq79i4KA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.72,411,1580803200"; d="scan'208";a="247267230" Received: from tassilo.jf.intel.com (HELO tassilo.localdomain) ([10.7.201.21]) by fmsmga008.fm.intel.com with ESMTP; 21 Apr 2020 13:06:31 -0700 Received: by tassilo.localdomain (Postfix, from userid 1000) id 09B9E3019B6; Tue, 21 Apr 2020 13:06:31 -0700 (PDT) Date: Tue, 21 Apr 2020 13:06:30 -0700 From: Andi Kleen To: Jiri Olsa Cc: Jiri Olsa , Arnaldo Carvalho de Melo , lkml , Ingo Molnar , Namhyung Kim , Alexander Shishkin , Peter Zijlstra , Michael Petlan , Joe Mario , Kajol Jain , John Garry Subject: Re: [PATCH 3/3] perf stat: Add --metrics-file option Message-ID: <20200421200630.GG608746@tassilo.jf.intel.com> References: <20200421181337.988681-1-jolsa@kernel.org> <20200421181337.988681-4-jolsa@kernel.org> <20200421183615.GD608746@tassilo.jf.intel.com> <20200421185252.GA962614@krava> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200421185252.GA962614@krava> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > > Also there are some asserts that can be triggered by expressions. I think > > you should fix those too and convert them to errors. > > do you have some details on this? examples of those failures? At a minimum /* Caller must make sure id is allocated */ void expr__add_id(struct parse_ctx *ctx, const char *name, double val) { int idx; assert(ctx->num_ids < MAX_PARSE_ID); -Andi