Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20200420190916.GA11695@gmail.com> <CAHk-=wiejBvKnrDysDva=DNFgyX02TZred_JMjzUnjFgVOUtOg@mail.gmail.com>
In-Reply-To: <CAHk-=wiejBvKnrDysDva=DNFgyX02TZred_JMjzUnjFgVOUtOg@mail.gmail.com>
From:   Ian Rogers <irogers@google.com>
Date:   Tue, 21 Apr 2020 14:03:22 -0700
Message-ID: <CAP-5=fVhWREzzjnXH4j+dcnP-GbSMnT_07qVrZM8huAhx6wtVw@mail.gmail.com>
Subject: Re: [GIT PULL] clang-format for v5.7-rc3
To:     Linus Torvalds <torvalds@linux-foundation.org>
Cc:     Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue, Apr 21, 2020 at 12:10 PM Linus Torvalds
<torvalds@linux-foundation.org> wrote:
>
> On Mon, Apr 20, 2020 at 12:09 PM Miguel Ojeda
> <miguel.ojeda.sandonis@gmail.com> wrote:
> >
> >  - Don't indent C++ namespaces (Ian Rogers)
>
> I've taken this, since it doesn't matter, but I'm wondering at the
> motivation for it (exactly because it shouldn't matter).

Hi Linus!

We (Google, Stephane Eranian, ..) have a tool that converts Intel's
topdown metrics:
https://download.01.org/perfmon/TMA_Metrics.xlsx
into the json format used for metrics in perf. It is written in C++
and we are planning to upstream it. In C++ there is preference for
anonymous namespaces over static functions and the namespace
indentation was pretty annoying for this. There's a little more
motivation in the commit message too.

Thanks,
Ian Rogers

>                    Linus