Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp83813ybz; Tue, 21 Apr 2020 15:48:38 -0700 (PDT) X-Google-Smtp-Source: APiQypIxpONOCFMW/j7yJxX+s1G274ibi6yjBTfCexkPOOUcqGn8DlJR5tMU8qDw+x/a3QjqiyST X-Received: by 2002:a17:906:1c8a:: with SMTP id g10mr24431941ejh.342.1587509318688; Tue, 21 Apr 2020 15:48:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1587509318; cv=none; d=google.com; s=arc-20160816; b=uHvbJ1Gla6fmSVxdLtaLtGk1BXoRVYrIFwLokjJfjhpOybgPlUcwIAPIuuvmcpn3HV n2DJ0eA9YYcdoIF7onZvBDqKY2l2+PyqBB+Tn/Lzp4xO55uh0v48gFoPPVNpfDeZ6XfJ QBOvvQlQvJq1GfND4Jag6FZJYaIdeNRBHh1C1qyE5wKPs5hVl77oG40YeX9tdTBPsI2h fiiu5T8kjoqYJ7uR1qOEJPXOiZPtcFWBMMzM4gIpuZELwMHXluny8eGaRFXT1cGF0CCo pjV6+kvEPk1E1KhkETzxOQrR63jAHOz86o5NHSOspHsPVSwb+gITXqytj3Af0SZXS/VF slDQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date; bh=2VeoUf9AbUhk5kWb+Lb/YKnZeoegAPGlo76EWr916q4=; b=rUZBQ5hSVZOIsV5pLUYqF859MHQPq2RQ/jaQE0KrJBuTgryG4cMuepjV1xz3WO+EbK WysobI8EP5ojzyDaAt3Z1t13IcWgSuRfvOXwwFqqV8Zz0DO9o8zX4FhmxR8nuXSenNaz PYOB0Hpvllhh9olRBqnyuPwXGA8C9V7V8EPT2GXIC433UYlROL9JbcFRqDvRTzPY0uet dvunik8AamY7KePaScniJ88Dlt5jYkdZ/Udb2FP3R7SxpnxBTIEam6C3MoeDOg6jDlTf Jgen3s5iYGBOc6cB/7M4BRcGCAyZ/VCns4LO+yvrwE/nuI2IsSPSXa8LefT6ACkYuwEY ChwQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id b5si2767632edf.69.2020.04.21.15.48.10; Tue, 21 Apr 2020 15:48:38 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726415AbgDUWqE (ORCPT + 99 others); Tue, 21 Apr 2020 18:46:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40934 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1726067AbgDUWqC (ORCPT ); Tue, 21 Apr 2020 18:46:02 -0400 Received: from shards.monkeyblade.net (shards.monkeyblade.net [IPv6:2620:137:e000::1:9]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C43C0C0610D5; Tue, 21 Apr 2020 15:46:02 -0700 (PDT) Received: from localhost (unknown [IPv6:2601:601:9f00:477::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 75569128E9284; Tue, 21 Apr 2020 15:46:02 -0700 (PDT) Date: Tue, 21 Apr 2020 15:46:01 -0700 (PDT) Message-Id: <20200421.154601.158772582316590260.davem@davemloft.net> To: yanaijie@huawei.com Cc: jeffrey.t.kirsher@intel.com, intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] e1000: remove unneeded conversion to bool From: David Miller In-Reply-To: <20200420123506.7716-1-yanaijie@huawei.com> References: <20200420123506.7716-1-yanaijie@huawei.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 21 Apr 2020 15:46:02 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Jason Yan Date: Mon, 20 Apr 2020 20:35:06 +0800 > The '==' expression itself is bool, no need to convert it to bool again. > This fixes the following coccicheck warning: > > drivers/net/ethernet/intel/e1000/e1000_main.c:1479:44-49: WARNING: > conversion to bool not needed here > > Signed-off-by: Jason Yan Applied to net-next.