Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 21 Apr 2020 17:56:58 -0700
From:   Benson Leung <bleung@google.com>
To:     Prashant Malani <pmalani@chromium.org>
Cc:     linux-kernel@vger.kernel.org, Benson Leung <bleung@chromium.org>,
        Enric Balletbo i Serra <enric.balletbo@collabora.com>,
        Guenter Roeck <groeck@chromium.org>,
        Heikki Krogerus <heikki.krogerus@linux.intel.com>
Subject: Re: [PATCH] platform/chrome: typec: Fix ret value check error
Message-ID: <20200422005658.GA208993@google.com>
References: <20200422004151.116323-1-pmalani@chromium.org>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="SLDf9lqlvOQaIe6s"
Content-Disposition: inline
In-Reply-To: <20200422004151.116323-1-pmalani@chromium.org>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


--SLDf9lqlvOQaIe6s
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi Prashant,

On Tue, Apr 21, 2020 at 05:41:51PM -0700, Prashant Malani wrote:
> cros_typec_add_partner() returns 0 on success, so check for "ret"
> instead of "!ret" as an error.
>=20
> Signed-off-by: Prashant Malani <pmalani@chromium.org>
> Fixes: 9d33ea331032 ("platform/chrome: cros_ec_typec: Register port partn=
er")

Thanks. Applied for 5.8.

origin/for-kernelci updated.

Thanks,
Benson

> ---
>  drivers/platform/chrome/cros_ec_typec.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/drivers/platform/chrome/cros_ec_typec.c b/drivers/platform/c=
hrome/cros_ec_typec.c
> index eda57db26f8d..66b8d21092af 100644
> --- a/drivers/platform/chrome/cros_ec_typec.c
> +++ b/drivers/platform/chrome/cros_ec_typec.c
> @@ -263,7 +263,7 @@ static void cros_typec_set_port_params_v1(struct cros=
_typec_data *typec,
> =20
>  		pd_en =3D resp->enabled & PD_CTRL_RESP_ENABLED_PD_CAPABLE;
>  		ret =3D cros_typec_add_partner(typec, port_num, pd_en);
> -		if (!ret)
> +		if (ret)
>  			dev_warn(typec->dev,
>  				 "Failed to register partner on port: %d\n",
>  				 port_num);
> --=20
> 2.26.1.301.g55bc3eb7cb9-goog
>=20

--=20
Benson Leung
Staff Software Engineer
Chrome OS Kernel
Google Inc.
bleung@google.com
Chromium OS Project
bleung@chromium.org

--SLDf9lqlvOQaIe6s
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYKAB0WIQQCtZK6p/AktxXfkOlzbaomhzOwwgUCXp+WWgAKCRBzbaomhzOw
whqjAP9vj3ehlrgYTfe7GbbIZvZJPN5fPnDJFqIiF6HgovzcPQD6As22716OzrWi
bIJXqW53SM3cskd9BB2jF1cO//7LaAM=
=ptXK
-----END PGP SIGNATURE-----

--SLDf9lqlvOQaIe6s--