Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
In-Reply-To: <3097723.HxHl8gbcWJ@192.168.0.120>
References: <1586163611-4565-1-git-send-email-masonccyang@mxic.com.tw> <1586163611-4565-3-git-send-email-masonccyang@mxic.com.tw> <3097723.HxHl8gbcWJ@192.168.0.120>
To:     <Tudor.Ambarus@microchip.com>
Cc:     juliensu@mxic.com.tw, linux-kernel@vger.kernel.org,
        linux-mtd@lists.infradead.org, miquel.raynal@bootlin.com,
        richard@nod.at, vigneshr@ti.com
Subject: Re: [PATCH 2/2] mtd: spi-nor: macronix: Add mx25u51245g support
MIME-Version: 1.0
Message-ID: <OF415076FF.CD74781E-ON48258552.000C02E7-48258552.000C8626@mxic.com.tw>
From:   masonccyang@mxic.com.tw
Date:   Wed, 22 Apr 2020 10:16:48 +0800
Content-Type: text/plain; charset="US-ASCII"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


 Hi Tudor,

> On Monday, April 6, 2020 12:00:11 PM EEST Mason Yang wrote:
> > EXTERNAL EMAIL: Do not click links or open attachments unless you know 
the
> > content is safe
> > 
> > mx25u51245g is a mass production for new design and
> > replace mx66u51235f(phase out).
> > 
> > Signed-off-by: Mason Yang <masonccyang@mxic.com.tw>
> > ---
> >  drivers/mtd/spi-nor/macronix.c | 3 +++
> >  1 file changed, 3 insertions(+)
> > 
> > diff --git a/drivers/mtd/spi-nor/macronix.c 
b/drivers/mtd/spi-nor/macronix.c
> > index c864ac8..e685aec 100644
> > --- a/drivers/mtd/spi-nor/macronix.c
> > +++ b/drivers/mtd/spi-nor/macronix.c
> > @@ -73,6 +73,9 @@
> >         { "mx66l51235l", INFO(0xc2201a, 0, 64 * 1024, 1024,
> >                               SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ |
> >                               SPI_NOR_4B_OPCODES) },
> > +       { "mx25u51245g", INFO(0xc2253a, 0, 64 * 1024, 1024,
> 
> Shouldn't the ID be 0xc2953a?

no! 
it's 0xc2253a

please refer to Macronix website
https://www.macronix.com/zh-tw/products/NOR-Flash/Serial-NOR-Flash/Pages/spec.aspx?p=MX25U51245G&m=Serial%20NOR%20Flash&n=PM2244 


> 
> We usually don't add new flashes if they are not tested. Please specify 
in the 
> commit message with which controller you tested the flash. Please do the 
same 
> for the previous patch.

okay.

> 
> The minimal test is a read, erase, read back, write and read back. This 
> sequence should verify if read, erase and pp work fine.

sure.

> 
> Cheers,
> ta
> 

thanks for your time & review.
Mason


CONFIDENTIALITY NOTE:

This e-mail and any attachments may contain confidential information 
and/or personal data, which is protected by applicable laws. Please be 
reminded that duplication, disclosure, distribution, or use of this e-mail 
(and/or its attachments) or any part thereof is prohibited. If you receive 
this e-mail in error, please notify us immediately and delete this mail as 
well as its attachment(s) from your system. In addition, please be 
informed that collection, processing, and/or use of personal data is 
prohibited unless expressly permitted by personal data protection laws. 
Thank you for your attention and cooperation.

Macronix International Co., Ltd.

=====================================================================


============================================================================

CONFIDENTIALITY NOTE:

This e-mail and any attachments may contain confidential information and/or personal data, which is protected by applicable laws. Please be reminded that duplication, disclosure, distribution, or use of this e-mail (and/or its attachments) or any part thereof is prohibited. If you receive this e-mail in error, please notify us immediately and delete this mail as well as its attachment(s) from your system. In addition, please be informed that collection, processing, and/or use of personal data is prohibited unless expressly permitted by personal data protection laws. Thank you for your attention and cooperation.

Macronix International Co., Ltd.

=====================================================================