Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp295316ybz; Tue, 21 Apr 2020 21:17:21 -0700 (PDT) X-Google-Smtp-Source: APiQypKfNdy07SsRBjymgcufMsIj1ntNWDZquHTPiQoyzJE3lblA2Ut/feVFbllKhA1e9DfPBuLs X-Received: by 2002:a50:baa9:: with SMTP id x38mr14684990ede.55.1587529041069; Tue, 21 Apr 2020 21:17:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1587529041; cv=none; d=google.com; s=arc-20160816; b=b5VEJEpxX/i+iX7DagwukWCOGgZ5SIW2+YwUyhXkILDCMpf1xmapReyjgEgIjPx0YD Kjz+qTQcNbYr3fzrrI1y0IdQRuJqj/g8C3ug5KmCBsnqFjXRn0W52U5DCJ07sxxpdEX9 SfaH9+fiVYsmLW7G7AE4JeKCRiDwZM9+SJA0ErswP1/uLosXRv51XdoWKQ3KFBilitcl 6MllcrkKbc/4rcCp07tpNdnSjHiBjHLwOcFCVZWifu8c+Vmk8NmbWSz4a2mmV3FXXL5b /KIrsqgnQoHA/F33tCgvD5JfK8TARg7pxnSOYR+L+0yZFHrjyBcBHqse9B2pi50vhlEV yaqQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=Kg2icj+XoK5z32K73+Ky/IwpjRd8JDVLbZ4vK1dpblg=; b=vQCbSNaTm2RlFARXjIvIEwuCtdj1+qmC59u+Iq7TXNtVwn5lORAO/LwYRt3NRjnTmg azLWigaDI3FVjStfeoUhoLOdpwflhkmMbxnd06+zfNpNs0KiMInwgnkzHRLpKz+yOqQQ zXqydPzMbt44XPBmlnotcXTryt7R5Db0qNjaEZKvHfE4yf1owB1tUV1ov5b19hQABWcj NeX5CZwGpCRM6TA0tIEEX1I0bU8km67W0n4KjrBQLPuZQcQDHcCSrBUq5dP/VRW0DI4Y hdj8xOnRJ1L9s5PdX5lmwJ3TaptNY24e+P+BLbuf5m12dWwvwJupf7Dl6wxGjcxd63eG e5Ew== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=fKfmdlAj; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id a24si2671605eds.168.2020.04.21.21.16.58; Tue, 21 Apr 2020 21:17:21 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=fKfmdlAj; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726046AbgDVEOF (ORCPT + 99 others); Wed, 22 Apr 2020 00:14:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34910 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1725811AbgDVEOF (ORCPT ); Wed, 22 Apr 2020 00:14:05 -0400 Received: from mail-ej1-x644.google.com (mail-ej1-x644.google.com [IPv6:2a00:1450:4864:20::644]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 51645C061BD3; Tue, 21 Apr 2020 21:14:04 -0700 (PDT) Received: by mail-ej1-x644.google.com with SMTP id x1so797608ejd.8; Tue, 21 Apr 2020 21:14:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Kg2icj+XoK5z32K73+Ky/IwpjRd8JDVLbZ4vK1dpblg=; b=fKfmdlAjjmK8jg1eJvSvHV5q0/GDlVU5mgiBSkk2siru0FaCsYR7TDzluj28w2ykYI rBtotEP8Ybp+ikkyTDdYtDCF5749niE/qGwtj7Wi0vOQVDqDPabTDvaqObBHZBCaH2sz kD5P+o+VjEcB3y1ohRM4KTR85lwz8xggeIkarMzqnXwHOgeTh3ixzF3PHC4AjvS3QNbs glErE9umhqdySH8MsjfA91MnzebjY144oQOJ2IghEXix0p16bfMwYMrrA8H0mXxoOIwm r2TuQf4Xg9iMpQojz5tUPRuWc/16xIRNbzSQK71IoO6We8SFpqtnib4UW18zYRoUGQ4C AvyQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Kg2icj+XoK5z32K73+Ky/IwpjRd8JDVLbZ4vK1dpblg=; b=c3tBE1BnmgK1IfiWE4JQesm8lDqeZDiGZCjnO8gUrnTnCv1UXsqd9hTOanml4uWvPS krJt7WpExkR85fvEAaeCOQqfPVyUjy2yPOSPimP+FtBrvscy9LOkoKfRwv750JiqUDem s8DDnG1EKDGgCEJO+TuxCnBfyXne3d+aj7Hs6NAZqvS7HgQDxkMzvdX8Fm9ZkwPbXkXR oQZ17klMQJdyeePzEOebax1y3zVs6lNwB9wKfG8IGSrBfgQczmelfY+YPU80Qek8qTGB pKc9zKUmuPlQWIyxU9s53G6BmKc2oYssZv7HiYIbUwHmnQvhWhBqefyfgUVysvu6+qYM ckLg== X-Gm-Message-State: AGi0PubIi9yfmR84LhTRaS6sq2PI8DJDmXHfF4CtBTggPWbL92vAKV3g WlThLl+Pgk4oRXfGMdaE8G4hYWr3Yy/Gc8goWUU= X-Received: by 2002:a17:906:548:: with SMTP id k8mr23639280eja.259.1587528842861; Tue, 21 Apr 2020 21:14:02 -0700 (PDT) MIME-Version: 1.0 References: <20200421171552.28393-1-luke.r.nels@gmail.com> <6f1130b3-eaea-cc5e-716f-5d6be77101b9@zytor.com> In-Reply-To: From: Xi Wang Date: Tue, 21 Apr 2020 21:13:26 -0700 Message-ID: Subject: Re: [PATCH bpf 1/2] bpf, x32: Fix invalid instruction in BPF_LDX zero-extension To: Brian Gerst Cc: "H. Peter Anvin" , Luke Nelson , bpf@vger.kernel.org, Luke Nelson , Wang YanQing , "David S. Miller" , Alexey Kuznetsov , Hideaki YOSHIFUJI , Thomas Gleixner , Ingo Molnar , Borislav Petkov , "the arch/x86 maintainers" , Alexei Starovoitov , Daniel Borkmann , Martin KaFai Lau , Song Liu , Yonghong Song , Andrii Nakryiko , John Fastabend , KP Singh , netdev@vger.kernel.org, Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Apr 21, 2020 at 8:22 PM Brian Gerst wrote: > You should explain the reason it is invalid, ie. the instruction > encoding needs a 32-bit immediate but the current code only emits an > 8-bit immediate. Thanks! Will do in v2.