Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] PCI: endpoint: functions/pci-epf-test: Avoid DMA release
 when DMA is unsupported
To:     Kishon Vijay Abraham I <kishon@ti.com>
Cc:     Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
        Bjorn Helgaas <bhelgaas@google.com>, linux-pci@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <1584956747-9273-1-git-send-email-hayashi.kunihiko@socionext.com>
 <948ae2b0-825e-4557-7e43-16d95d26e9f4@ti.com>
From:   Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
Message-ID: <b5501127-826f-78f2-beb2-1b8093c90245@socionext.com>
Date:   Wed, 22 Apr 2020 14:59:28 +0900
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101
 Thunderbird/68.7.0
MIME-Version: 1.0
In-Reply-To: <948ae2b0-825e-4557-7e43-16d95d26e9f4@ti.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Kishon,

On 2020/04/22 14:45, Kishon Vijay Abraham I wrote:
> Hi Kunihiko,
> 
> On 3/23/2020 3:15 PM, Kunihiko Hayashi wrote:
>> When unbinding pci_epf_test, pci_epf_test_clean_dma_chan() is called in
>> pci_epf_test_unbind() even though epf_test->dma_supported is false.
>> As a result, dma_release_channel() will occur null pointer access because
>> dma_chan isn't set.
>>
>> This avoids calling dma_release_channel() if epf_test->dma_supported
>> is false.
>>
>> Fixes: a1d105d4ab8e ("PCI: endpoint: functions/pci-epf-test: Add DMA support to transfer data")
>> Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
>> ---
>>   drivers/pci/endpoint/functions/pci-epf-test.c | 3 ++-
>>   1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/pci/endpoint/functions/pci-epf-test.c b/drivers/pci/endpoint/functions/pci-epf-test.c
>> index 3b4cf7e..8b4f136 100644
>> --- a/drivers/pci/endpoint/functions/pci-epf-test.c
>> +++ b/drivers/pci/endpoint/functions/pci-epf-test.c
>> @@ -609,7 +609,8 @@ static void pci_epf_test_unbind(struct pci_epf *epf)
>>   	int bar;
>>   
>>   	cancel_delayed_work(&epf_test->cmd_handler);
>> -	pci_epf_test_clean_dma_chan(epf_test);
>> +	if (epf_test->dma_supported)
>> +		pci_epf_test_clean_dma_chan(epf_test);
> 
> Can you add this check inside the pci_epf_test_clean_dma_chan()?
Okay, I'll move this check to the pci_epf_test_clean_dma_chan().

Thank you,

---
Best Regards
Kunihiko Hayashi