Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp446250ybz; Wed, 22 Apr 2020 01:09:22 -0700 (PDT) X-Google-Smtp-Source: APiQypIeZ566BaDR1vX4YQ85SLqj3qZBQSi75K+dx8yWPVbLmfu+x4KvWYreo5kh3ZOopBrQ2nYH X-Received: by 2002:a17:906:5287:: with SMTP id c7mr12391488ejm.141.1587542962159; Wed, 22 Apr 2020 01:09:22 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1587542962; cv=none; d=google.com; s=arc-20160816; b=Hg0480akU30EsXm3RL3w+oCIZTdS/KVpZlL4aCFo+Mph5VPkFMimcxySQWtHwsgVGl vFHZHvGPKwjvjw0blkF0iRlTQaA4wpUhRecrAjGp+LxbVjn4Qw8apOo14He2w+DiA9vX N2pEao/nmDDB3AhkCQGNxQlm3YXGfGTLcYnWFShDXsXot5iEhR16Adh/bChft/Onpgmi qaIsks4dJyQNkOKXRv8XPIz2fPLj0sJEeOe1qOkfa+lmbZKA379nwuYVLUKap7VTbHpI CAeo1mxbwJoafosBIxOenyUXPxHILAT76lsgZuKOVn5jAvoD5O418ZDisCnE1HPheuA/ FHOA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=LALBEzmuCRS/3PCJiM+XIrx7OF6kE4ANWmlIVrarBNU=; b=uI7tLUMJAlzfK0Ocj/jZypLWM8zElLiXNR+NKR6wZySrBoyNM2LpLcFnk3hdRxQICX Qt04KV0wK87hksFLarEjOAhptj1f+Y7Jf7CBGwlrUZuDyFCfnRCS70DQFEpTpWEhUoOU Xf/ipqB6Y1Jj5I1B3TGtuO16TVyk37F9nXHe6jJqwvY2pmrha87JdDylqblcV80tr3rM LtwcXyqruQJZ9aPqMarGzjXr/0VvvgCbR9rZ1sAr3hq/OMdAo/IpIA6gRWR+Cz5+3HvK rse+U4nnBx9+G3cqmNZp9NQ85OwL9Bt0KS6rWO+Y9WoIDOl8ZE4jq7BnNK4ePvtPnHDC rAeQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id ck10si3213578ejb.431.2020.04.22.01.08.58; Wed, 22 Apr 2020 01:09:22 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725968AbgDVIH4 (ORCPT + 99 others); Wed, 22 Apr 2020 04:07:56 -0400 Received: from verein.lst.de ([213.95.11.211]:50856 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725810AbgDVIH4 (ORCPT ); Wed, 22 Apr 2020 04:07:56 -0400 Received: by verein.lst.de (Postfix, from userid 2407) id 0F9E268C4E; Wed, 22 Apr 2020 10:07:53 +0200 (CEST) Date: Wed, 22 Apr 2020 10:07:52 +0200 From: Christoph Hellwig To: Martijn Coenen Cc: Christoph Hellwig , Jens Axboe , Ming Lei , Narayan Kamath , Zimuzo Ezeozue , kernel-team@android.com, linux-block , LKML , Martijn Coenen , Bart Van Assche , Chaitanya Kulkarni Subject: Re: [PATCH 4/4] loop: Add LOOP_SET_FD_AND_STATUS ioctl. Message-ID: <20200422080752.GA24916@lst.de> References: <20200420080409.111693-1-maco@android.com> <20200420080409.111693-5-maco@android.com> <20200422061919.GA22819@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Apr 22, 2020 at 10:06:17AM +0200, Martijn Coenen wrote: > > line at the top of lo_compat_ioctl, and switches the LOOP_SET_STATUS > > and LOOP_GET_STATUS case to it? > > Did you mean in regular lo_ioctl()? Yes, sorry. > eg something like this: > > @@ -1671,6 +1671,7 @@ static int lo_ioctl(struct block_device *bdev, > fmode_t mode, > unsigned int cmd, unsigned long arg) > { > struct loop_device *lo = bdev->bd_disk->private_data; > + void __user *argp = (void __user *) arg; > int err; > > switch (cmd) { > @@ -1694,21 +1695,19 @@ static int lo_ioctl(struct block_device *bdev, > fmode_t mode, > case LOOP_SET_STATUS: > err = -EPERM; > if ((mode & FMODE_WRITE) || capable(CAP_SYS_ADMIN)) { > - err = loop_set_status_old(lo, > - (struct loop_info __user *)arg); > + err = loop_set_status_old(lo, argp); > } > break; > case LOOP_GET_STATUS: > - return loop_get_status_old(lo, (struct loop_info __user *) arg); > + return loop_get_status_old(lo, argp); > case LOOP_SET_STATUS64: > err = -EPERM; > if ((mode & FMODE_WRITE) || capable(CAP_SYS_ADMIN)) { > - err = loop_set_status64(lo, > - (struct loop_info64 __user *) arg); > + err = loop_set_status64(lo, argp); > } > break; > case LOOP_GET_STATUS64: > - return loop_get_status64(lo, (struct loop_info64 __user *) arg); > + return loop_get_status64(lo, argp); Exactly!