Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp538909ybz; Wed, 22 Apr 2020 03:15:25 -0700 (PDT) X-Google-Smtp-Source: APiQypKvr7WeKsU6xXxv9r9Dgf7uq8qE+y8uNQcuE9SRIPbbc+UJzxUOKmvCgJUUW5k2fKzkCGZx X-Received: by 2002:aa7:d3d3:: with SMTP id o19mr22518700edr.76.1587550524825; Wed, 22 Apr 2020 03:15:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1587550524; cv=none; d=google.com; s=arc-20160816; b=J19GVa0Ff4ojI1F4dFN/t1zdKvLamLy9gh6So96ezfihx55z8V63KB/GDlN2VEE8m7 So+1gmnQ2spUbUBArf3yiE7O+z/ior4DkkGJLPl5glIUGSmZjo7hfUsWqmt0wcLXzHne P5E/YgSL2aa2hIe+C9FDKRKvZQ7MbFw/Y9G4JbseiKqzC0hAt/zcTjB2tqNFNrqYCNAY uSgz3lXkUupXROth1OZ9EuBFCy/8l4iBA81VSinCQV0aYirlraTcutcf2FY4eEKP8cL/ XPF2KFQawMwn5g/Xm8BxpVY02hmcAPM72oxkIbXXadgQSKg4XtzJivZ9e3XyzsnM+gix 4WaA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=raaC8TDVU9q6M+zzHhhWV6OFXZkWIWp78tNuRwOAYUs=; b=aDmqky3jt0Niibw2dFleNANCT4f7ZEYpE3HvoGUvl0u8cMV1vUtgqpmsgV77atdytt CYL9RyXiqYmSdeOqGIXEdBZ8pRrHDquPm70L6Slsx/79JBKS+EtJiGsNVO72rVFA5kLe b/p3+hGbA/no8Tq5Qg5Yw3xgxQTYHpMsXXkzml5Cq05cE6gSw89bP5DMywuQ22RnGUH4 ujWKBl+/aiUYPIK1Omj14x8aPTRPfvmw08pknN1fOxvfLwqvkp2+4Sn+j0TUjLWHPDt8 8tIrtkzG/QyEkAIMedO/HjTPhglkg0r0iqbwK5YeCVnQ9sM9eqxou9F38fYFOMFIU4Sq SuWA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=E+WvSGB2; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id dp4si3957678ejc.399.2020.04.22.03.15.01; Wed, 22 Apr 2020 03:15:24 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=E+WvSGB2; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729400AbgDVKM5 (ORCPT + 99 others); Wed, 22 Apr 2020 06:12:57 -0400 Received: from mail.kernel.org ([198.145.29.99]:46028 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728528AbgDVKMo (ORCPT ); Wed, 22 Apr 2020 06:12:44 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 6E19920575; Wed, 22 Apr 2020 10:12:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1587550363; bh=c85CGpP7cfzhhX9b7oR7I9LDFO5HgAAJ4/uX9JDnpQQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=E+WvSGB23Hcaoj5+NGcf0jS5gBY5zANRrvyvKOLk3G49E6ByT04Zqx5e5XZQUXV7W Epwp+6L/fVTuZJnPKvCntD526K2697dCVh8JoHddQazYsraeEiKDVVrpPgKG9OeTia yWpVa+w4EdKAfghkvxPBBf1ddAcA/PoPR55phqnw= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Andreas Dilger , Josh Triplett , Theodore Tso Subject: [PATCH 4.14 117/199] ext4: fix incorrect inodes per group in error message Date: Wed, 22 Apr 2020 11:57:23 +0200 Message-Id: <20200422095109.346227713@linuxfoundation.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200422095057.806111593@linuxfoundation.org> References: <20200422095057.806111593@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Josh Triplett commit b9c538da4e52a7b79dfcf4cfa487c46125066dfb upstream. If ext4_fill_super detects an invalid number of inodes per group, the resulting error message printed the number of blocks per group, rather than the number of inodes per group. Fix it to print the correct value. Fixes: cd6bb35bf7f6d ("ext4: use more strict checks for inodes_per_block on mount") Link: https://lore.kernel.org/r/8be03355983a08e5d4eed480944613454d7e2550.1585434649.git.josh@joshtriplett.org Reviewed-by: Andreas Dilger Signed-off-by: Josh Triplett Signed-off-by: Theodore Ts'o Signed-off-by: Greg Kroah-Hartman --- fs/ext4/super.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/fs/ext4/super.c +++ b/fs/ext4/super.c @@ -3969,7 +3969,7 @@ static int ext4_fill_super(struct super_ if (sbi->s_inodes_per_group < sbi->s_inodes_per_block || sbi->s_inodes_per_group > blocksize * 8) { ext4_msg(sb, KERN_ERR, "invalid inodes per group: %lu\n", - sbi->s_blocks_per_group); + sbi->s_inodes_per_group); goto failed_mount; } sbi->s_itb_per_group = sbi->s_inodes_per_group /