Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp567618ybz; Wed, 22 Apr 2020 03:54:00 -0700 (PDT) X-Google-Smtp-Source: APiQypLP/CwVXJfEn+BowlCMZOTs5IYH37QBLUQpmSMvlCHRHyMHFT7D0brbzwjrjMtymcpRIHtn X-Received: by 2002:aa7:d892:: with SMTP id u18mr21501348edq.156.1587552839892; Wed, 22 Apr 2020 03:53:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1587552839; cv=none; d=google.com; s=arc-20160816; b=SL/zhj7nbLL13yWCb0gLwrrxqwh66DzRmm9bQSHJSoFlEFcUBExu8zN/Ejb+3oE0iS 2wk1s9576KKtvzTMOgV2NuqwqyyG0lqFsCxcQo728G5DtujEO9vhDP0k/tClQ5cPrLpV bnE+fSzr/1vO5nehSbANVo5OPk9mvI65c83P60SS8k6QACFksb6DczhLoKfriaXzWdd0 PUY5kE+bV6yk78m+WwrKOtJqQ0+Oke/IDF+xboAC4ifOk6LzHXcBVprWrBvyvq0s2d5S hXLIPwsguyPMC2L02QqXJ5AuhQKxMfeiHDmAeMjZvCrf4qX9lO7gy0qgJxfulo9+0I5J tDuw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=3PgggCUifOrb7dRVTtUlgtosbje+Ps68Wmm5DHQgUeg=; b=DbjIutifKuLVoCax+atyN5AWH+vQQoIJF2Bfc2WeTUDnJrUaEKd+PG5KhYMUO2Lag1 dnUtBWz1f4eQASVqHZhIchR3WYxZ6D8IamXWdhWSfbUSEBrQFBGpilRJMAH7mzoGlKmV RRbefkEY+vE7BTEGFH3VMAja2MBHvtrr1HEa267CzAQM8tyhKqJvXaWKTgfi7Sf+Ph02 r7V0DshggWHYu4ZGtqctlMlnZRSJwYBifJSwrxFEWJKG48iUFTiaR+DgAz8U0otl19vM vmPe5nJ6TKrZBMDNcJNKhaexOI96jYJE7tQ920I0KW1dkFzWOR7iih1UtmgYgkxPgeTZ OUHw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=q8Mpn1yG; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id k17si3121817ejg.470.2020.04.22.03.53.36; Wed, 22 Apr 2020 03:53:59 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=q8Mpn1yG; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729129AbgDVKLA (ORCPT + 99 others); Wed, 22 Apr 2020 06:11:00 -0400 Received: from mail.kernel.org ([198.145.29.99]:41462 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728554AbgDVKKy (ORCPT ); Wed, 22 Apr 2020 06:10:54 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id D20892077D; Wed, 22 Apr 2020 10:10:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1587550253; bh=t3gf1WfgzA7QkhtiJsUlvysRRBiRev8FPPvrFOpxF64=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=q8Mpn1yGFBz8cWRcR42ma3UYosPCpvVcaxcBNnfTrOeeGctlfjANtnw7y5apXh/DB yHs/CdqhQLfImRkaWkZsfHpSEHKRxMae9ydmbrjcUHY972YiUymTxU1SEjhp3Ujd9M Yo+IYbCP8wXaoainv63YcgU+OpVIYl56z0NhhNvc= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Harshini Shetty , Mike Snitzer Subject: [PATCH 4.14 072/199] dm verity fec: fix memory leak in verity_fec_dtr Date: Wed, 22 Apr 2020 11:56:38 +0200 Message-Id: <20200422095105.366516837@linuxfoundation.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200422095057.806111593@linuxfoundation.org> References: <20200422095057.806111593@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Shetty, Harshini X (EXT-Sony Mobile) commit 75fa601934fda23d2f15bf44b09c2401942d8e15 upstream. Fix below kmemleak detected in verity_fec_ctr. output_pool is allocated for each dm-verity-fec device. But it is not freed when dm-table for the verity target is removed. Hence free the output mempool in destructor function verity_fec_dtr. unreferenced object 0xffffffffa574d000 (size 4096): comm "init", pid 1667, jiffies 4294894890 (age 307.168s) hex dump (first 32 bytes): 8e 36 00 98 66 a8 0b 9b 00 00 00 00 00 00 00 00 .6..f........... 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................ backtrace: [<0000000060e82407>] __kmalloc+0x2b4/0x340 [<00000000dd99488f>] mempool_kmalloc+0x18/0x20 [<000000002560172b>] mempool_init_node+0x98/0x118 [<000000006c3574d2>] mempool_init+0x14/0x20 [<0000000008cb266e>] verity_fec_ctr+0x388/0x3b0 [<000000000887261b>] verity_ctr+0x87c/0x8d0 [<000000002b1e1c62>] dm_table_add_target+0x174/0x348 [<000000002ad89eda>] table_load+0xe4/0x328 [<000000001f06f5e9>] dm_ctl_ioctl+0x3b4/0x5a0 [<00000000bee5fbb7>] do_vfs_ioctl+0x5dc/0x928 [<00000000b475b8f5>] __arm64_sys_ioctl+0x70/0x98 [<000000005361e2e8>] el0_svc_common+0xa0/0x158 [<000000001374818f>] el0_svc_handler+0x6c/0x88 [<000000003364e9f4>] el0_svc+0x8/0xc [<000000009d84cec9>] 0xffffffffffffffff Fixes: a739ff3f543af ("dm verity: add support for forward error correction") Depends-on: 6f1c819c219f7 ("dm: convert to bioset_init()/mempool_init()") Cc: stable@vger.kernel.org Signed-off-by: Harshini Shetty Signed-off-by: Mike Snitzer Signed-off-by: Greg Kroah-Hartman --- drivers/md/dm-verity-fec.c | 1 + 1 file changed, 1 insertion(+) --- a/drivers/md/dm-verity-fec.c +++ b/drivers/md/dm-verity-fec.c @@ -552,6 +552,7 @@ void verity_fec_dtr(struct dm_verity *v) mempool_destroy(f->rs_pool); mempool_destroy(f->prealloc_pool); mempool_destroy(f->extra_pool); + mempool_destroy(f->output_pool); kmem_cache_destroy(f->cache); if (f->data_bufio)