Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp574709ybz; Wed, 22 Apr 2020 04:02:17 -0700 (PDT) X-Google-Smtp-Source: APiQypI0Qbm9CyaYwXeV9XZhxtN56uBBh6IXZ53qib2uZ4atKPHABzVgjWfbqGjTTjRP8kUdtDbX X-Received: by 2002:a50:d98b:: with SMTP id w11mr12153771edj.196.1587553330964; Wed, 22 Apr 2020 04:02:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1587553330; cv=none; d=google.com; s=arc-20160816; b=mOruuTt0QIdre9kHMux1AEAmHtAQWIoimEKH4t0z+ktBn8SmZpwcLcGr0anhLG+Y4P ol4bO5fylQREG+20ByiR/R9THnzG9apKwki+WBnQi35fK98QRASTocRYfs3kMSaN0i4Y HgDLNYC4ArGUra3k2IWKXGoGXTqDkb2PR2EZEsmTiva90Y6X6+kjVLYmktK1IrP+fHrE ve/46tTNkQB2U/IX7zMTQkyW6/oB6TWO48qqpEVfrOEHXoWBaWobedCocIXS4wSi1A1a ZUNnM9XK98abVjeP0BKya76v1sAjPswSDL9tfE8N/FO/Qk9d35zdtztEmTIVKKFPLluE xmrQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=sb1DDuk3KFlLAdp8ms1jYvkr0thANhDvH4d1WisXass=; b=H7ObVWUshHbeOxQhParTJLUSZrGkRZ+2fJZ2x+NfKnD055H1Ahcs3/gH91Qd1McuDI zxbbZKqOiGSJBHWZNaq3fC/4ayHRc8lRSVv/BcapBUY4vm+s4yzGW9SWC3C0kb+ZWeeY pnXOuKgHHjHmzQUNbskmVaS7Ik1e5zMM1y9QeIgOWv6DtKK+bki+KsT2HkzhCOJ9mF8j d0aN3K2X5pq/hl4BKvB5JdACBAEUJR49v7KCWSJbIXUh6PZqsTMUSOI8AjMDUCRyLHkw XH+E7macY8IIdgMIXq8SCwHj+LF7dfWvCMdwhMp1EC6xPqLNZUCNKViL56w/1bn/nJ54 CJHg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=16ycsSAg; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id a15si3572933edk.298.2020.04.22.04.01.46; Wed, 22 Apr 2020 04:02:10 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=16ycsSAg; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732306AbgDVK70 (ORCPT + 99 others); Wed, 22 Apr 2020 06:59:26 -0400 Received: from mail.kernel.org ([198.145.29.99]:52312 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727076AbgDVKC4 (ORCPT ); Wed, 22 Apr 2020 06:02:56 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id A33F920774; Wed, 22 Apr 2020 10:02:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1587549776; bh=bjvnJTPPAmrWn7sTp40MNKJPn2kc6bhnn19g0wsb8I0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=16ycsSAgHz9vFCdBDZ36wYFRFrVQsDMiVqwrcyuzKHfbBLIfQhDvV0vNCSTlUsVGl jsNLdZ/PZFfoYsmpb6h2aXRLItls05ZyHFfyRa3qmdU2vGzS7llomTmvUCjFZuYb9Z hoCvzFcW+b92HtCqLhPuRheN2o5RFHn1m60l3soM= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Samuel Neves , Thomas Gleixner , Andy Lutomirski , "Nobuhiro Iwamatsu (CIP)" Subject: [PATCH 4.4 100/100] x86/vdso: Fix lsl operand order Date: Wed, 22 Apr 2020 11:57:10 +0200 Message-Id: <20200422095040.834180030@linuxfoundation.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200422095022.476101261@linuxfoundation.org> References: <20200422095022.476101261@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Samuel Neves commit e78e5a91456fcecaa2efbb3706572fe043766f4d upstream. In the __getcpu function, lsl is using the wrong target and destination registers. Luckily, the compiler tends to choose %eax for both variables, so it has been working so far. Fixes: a582c540ac1b ("x86/vdso: Use RDPID in preference to LSL when available") Signed-off-by: Samuel Neves Signed-off-by: Thomas Gleixner Acked-by: Andy Lutomirski Cc: stable@vger.kernel.org Link: https://lkml.kernel.org/r/20180901201452.27828-1-sneves@dei.uc.pt Signed-off-by: Nobuhiro Iwamatsu (CIP) Signed-off-by: Greg Kroah-Hartman --- arch/x86/include/asm/vgtod.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/arch/x86/include/asm/vgtod.h +++ b/arch/x86/include/asm/vgtod.h @@ -86,7 +86,7 @@ static inline unsigned int __getcpu(void * * If RDPID is available, use it. */ - alternative_io ("lsl %[p],%[seg]", + alternative_io ("lsl %[seg],%[p]", ".byte 0xf3,0x0f,0xc7,0xf8", /* RDPID %eax/rax */ X86_FEATURE_RDPID, [p] "=a" (p), [seg] "r" (__PER_CPU_SEG));