Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp575587ybz; Wed, 22 Apr 2020 04:03:06 -0700 (PDT) X-Google-Smtp-Source: APiQypJpxsYkg781yH+fj+4PZA4DbcGN3W6UQ0tKS7y/qIE73G1bfUxvhFO9FqAhu5+vEh0pjpHo X-Received: by 2002:a50:9dc4:: with SMTP id l4mr23161022edk.234.1587553386204; Wed, 22 Apr 2020 04:03:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1587553386; cv=none; d=google.com; s=arc-20160816; b=pxV/V0ZeUJorGP1F1NmYqmRDCK33jFUug0WivWIxGXniMqVtHfdGVQH3GINxW1ZSjg 3hViM1wzddGOfoxwsA546D/OuIFvAhwbk/qFo19zBsJNiwd6FVbFjwch+0NmNKoF2XIL hVl3fzr7Vk7Rvqc1TJTST53rfaWrCZUl9Bq+TLbS8OhVJZaEJIv2klqnYuoYQrK6Ot5o cNzJxB8YKxBLxCzCSEeTTksxdghBECYI5Ox8acKfe7Z2fdQOKOuDFZ4Ne655Rv0dRXBO aubwjeUACQGsc1F/8yVBkHEbDP8IeLA5WiNsUjHn+54Kh0lCwsG221L8xWZu2kcgMR2e Lz+Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=XPu5DdIcBFibbldQUaQbrOKL8GXAUsgMiAj7FxE+n30=; b=vewRMRoDieHI8IrTqtP5CxAk7ts+088QaAKGSn6QP4HOyL1tpkVxUMpeOhGweeYNIl 3GfWrcneFabg4sstcOGwpvl63QXGf2IFmtlLzxh7ALcgQRAA4THbVIPH+m3HdBzLHPUD aWiVyhRBhgg6aAt71LznTLooPv3edhjAl/mLPOzCZqIEv1jmKcYQsKOsrBlACAjC/QjP 8qEn5BiB6hOln52xoCyMfALCp5Z24IaaFGLri3phTbzcAm+AIvhzvgdFWDrX/K5mrwpc TxXRnPSUSrj1CRLC3LTWR730XpdZ9C1r6z6geVUZJiCKwACGq+oY/RfkfeIyTAjwerEg 0xUA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=C34qLx9S; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id h11si3087300edr.106.2020.04.22.04.02.35; Wed, 22 Apr 2020 04:03:06 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=C34qLx9S; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726916AbgDVKCA (ORCPT + 99 others); Wed, 22 Apr 2020 06:02:00 -0400 Received: from mail.kernel.org ([198.145.29.99]:50744 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726889AbgDVKB6 (ORCPT ); Wed, 22 Apr 2020 06:01:58 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id B735D20735; Wed, 22 Apr 2020 10:01:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1587549718; bh=rrmnOmOsnTMK7HOIQLxfsYxR7IdNREV8GXUA269AL/k=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=C34qLx9S8mreB/viOxniADnELUGMxRmMGZKZJK/m99EY90+vB0k0Okiyx19qggdeG OkhLxCrZO/6zKWzQAcZtebsAE8sRe172vmwODU3NzHkTIFKj1DwpXZgeFzIlFOTgky 4Q/naLGI90u1e9XBy9YwhqWD1ZPRMweDhJakMdyc= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Andreas Dilger , Josh Triplett , Theodore Tso Subject: [PATCH 4.4 061/100] ext4: fix incorrect inodes per group in error message Date: Wed, 22 Apr 2020 11:56:31 +0200 Message-Id: <20200422095034.054617285@linuxfoundation.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200422095022.476101261@linuxfoundation.org> References: <20200422095022.476101261@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Josh Triplett commit b9c538da4e52a7b79dfcf4cfa487c46125066dfb upstream. If ext4_fill_super detects an invalid number of inodes per group, the resulting error message printed the number of blocks per group, rather than the number of inodes per group. Fix it to print the correct value. Fixes: cd6bb35bf7f6d ("ext4: use more strict checks for inodes_per_block on mount") Link: https://lore.kernel.org/r/8be03355983a08e5d4eed480944613454d7e2550.1585434649.git.josh@joshtriplett.org Reviewed-by: Andreas Dilger Signed-off-by: Josh Triplett Signed-off-by: Theodore Ts'o Signed-off-by: Greg Kroah-Hartman --- fs/ext4/super.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/fs/ext4/super.c +++ b/fs/ext4/super.c @@ -3660,7 +3660,7 @@ static int ext4_fill_super(struct super_ if (sbi->s_inodes_per_group < sbi->s_inodes_per_block || sbi->s_inodes_per_group > blocksize * 8) { ext4_msg(sb, KERN_ERR, "invalid inodes per group: %lu\n", - sbi->s_blocks_per_group); + sbi->s_inodes_per_group); goto failed_mount; } sbi->s_itb_per_group = sbi->s_inodes_per_group /