Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751049AbWCCX0E (ORCPT ); Fri, 3 Mar 2006 18:26:04 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932556AbWCCX0E (ORCPT ); Fri, 3 Mar 2006 18:26:04 -0500 Received: from smtp.osdl.org ([65.172.181.4]:38580 "EHLO smtp.osdl.org") by vger.kernel.org with ESMTP id S1751033AbWCCX0C (ORCPT ); Fri, 3 Mar 2006 18:26:02 -0500 Date: Fri, 3 Mar 2006 15:22:42 -0800 (PST) From: Linus Torvalds To: Adrian Bunk cc: Andrew Morton , ".geert"@linux-m68k.org, zippel@linux-m68k.org, linux-m68k@vger.kernel.org, Linux Kernel Mailing List , Nick Piggin Subject: Re: 2.6.16-rc regression: m68k CONFIG_RMW_INSNS=n compile broken In-Reply-To: <20060303230149.GB9295@stusta.de> Message-ID: References: <20060303230149.GB9295@stusta.de> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 910 Lines: 24 On Sat, 4 Mar 2006, Adrian Bunk wrote: > > It seems the problem is that in the CONFIG_RMW_INSNS=n case, there's no > cmpxchg #define in include/asm-m68k/system.h required for the > atomic_add_unless #define in include/asm-m68k/atomic.h. Hmm. It seems like it never has been there.. Do you know what brought this on? Was it Nick's RCU changes from "rcuref_dec_and_test()" to "atomic_dec_and_test()" and friends? Judging by your error messages, I _think_ it's the "atomic_inc_not_zero()" that gets expanded to a cmpxchg() that simply doesn't exist on m68k and never has. I guess we've never depended on cmpxchg before. Or am I missing something? Linus - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/