Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp601149ybz; Wed, 22 Apr 2020 04:31:55 -0700 (PDT) X-Google-Smtp-Source: APiQypKIiMrh15YIopXxbO/UcF5KpnkviulA4SdNJkPIGixkpsKgjtQEXQm45F2KTG+BXWFIL5NK X-Received: by 2002:a05:6402:712:: with SMTP id w18mr23152799edx.386.1587555114792; Wed, 22 Apr 2020 04:31:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1587555114; cv=none; d=google.com; s=arc-20160816; b=JoO7b5V2nQgCruvI5NiAUlM6Po/lD3+/TkMgRDSOaFA+pkNERpDiIhiVRo7ris1xWh 9/CdPDsTf0Yhj7bLIg4sXNRoZnVbvoJtY40HsZ1nLVVN+LGQkaSLcAb2ta29JUaebZO/ 8w9PtC/f0o/v1NDws7H9a8ZlnCgdObWU+sl+u1XnfPXecDEFDP7Ji5vSnrO+BIvuKWhX ARgxXnJoEbB1ap3QShCH95sHXlrgY1LQhMv7hgpYqZK9NB/MIz3gxAvGRf9g6K91pUud WXAs3XuPvy/9XB9vGNR7JPdQBguFi+Yrpc5r/vlIfaNxuGiQz285aM8zbd05CPwbgEAG rJ0A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:references:subject:cc:to :from:date:user-agent:message-id:dkim-signature; bh=yT7zCXasH20UC6NIVxkpNndV6tvyX4o1l6S+JN7w94s=; b=QOn6INfVCeIHpZ8O6tAm3givP1fy3/pIhe6oD9CynP9U4iJ61OyDR2HVPp0GnUBQuV 31TxwIUbCXzDPudB3PG4Ya8qlCcqvEuyHtbn+Vv3F88nt1vbj1Lgm3Xh399sVtrto1xl b4OjMQ1CjD/PqLFZxRbr3LoY4c2efhtaeqbJqoW017qmOcukZk+J6FrzZAk2785zC+th +vSUP5OF/odmRCYKjVhQyh0W2sbj98mzKCadLyWVsJOUgq915UOIF5tFtczyLfKTb1qF wU4Th4QKvQjn3kfjC/yHkBt8TWbQErn32wjHeRIORV24tTjzLAJm5GBIxCXpagFmUCI1 VGEg== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=UI46sCky; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id os28si2712660ejb.98.2020.04.22.04.31.31; Wed, 22 Apr 2020 04:31:54 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=UI46sCky; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727784AbgDVL3u (ORCPT + 99 others); Wed, 22 Apr 2020 07:29:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45778 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1726517AbgDVL3Z (ORCPT ); Wed, 22 Apr 2020 07:29:25 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 29FCFC03C1AF for ; Wed, 22 Apr 2020 04:29:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=Content-Type:MIME-Version:References: Subject:Cc:To:From:Date:Message-Id:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:In-Reply-To; bh=yT7zCXasH20UC6NIVxkpNndV6tvyX4o1l6S+JN7w94s=; b=UI46sCkyYaicIu3j/fS/4FtUZa QliP64YDd+4nGIGS4JeRra+YtVSnCq48I39wmOafhnFEpTJ6mrPEUf8CP+jm5tGCEqkO4KNb9YXQ2 XkMS+KzqR4IbygalSm1+GUnmKyvj6RQIbnQkXkyHmlbfbxPzIVHxY8JPWwHFQ/hwQAYCJBnvkYFbz 0MjiDyw1s8qBVCN/+zg1aUnTqY65rb124ACBcCwnjR2XkvGlYacp5U1pC96thQwDw6Sbur9Pjqk/W LdXZHLHFyYq4FlJbgVt/6STAPIJpd8dWJjMWfKmaRFm0obXBr3GmHEcj4bNfRORvlRvligxSl7XeS dX5SWNOw==; Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=noisy.programming.kicks-ass.net) by bombadil.infradead.org with esmtpsa (Exim 4.92.3 #3 (Red Hat Linux)) id 1jRDYy-0003bS-MF; Wed, 22 Apr 2020 11:29:08 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id 58564307981; Wed, 22 Apr 2020 13:29:03 +0200 (CEST) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 0) id 163E022B99F0A; Wed, 22 Apr 2020 13:29:03 +0200 (CEST) Message-Id: <20200422112832.403795265@infradead.org> User-Agent: quilt/0.65 Date: Wed, 22 Apr 2020 13:27:39 +0200 From: Peter Zijlstra To: mingo@kernel.org, linux-kernel@vger.kernel.org Cc: tglx@linutronix.de, rostedt@goodmis.org, qais.yousef@arm.com, juri.lelli@redhat.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, bsegall@google.com, mgorman@suse.de, peterz@infradead.org, paulmck@kernel.org Subject: [PATCH 20/23] sched,rcutorture: Convert to sched_set_fifo_low() References: <20200422112719.826676174@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Because SCHED_FIFO is a broken scheduler model (see previous patches) take away the priority field, the kernel can't possibly make an informed decision. Effectively no change. Cc: paulmck@kernel.org Signed-off-by: Peter Zijlstra (Intel) Reviewed-by: Ingo Molnar --- kernel/rcu/rcutorture.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) --- a/kernel/rcu/rcutorture.c +++ b/kernel/rcu/rcutorture.c @@ -802,13 +802,11 @@ static int rcu_torture_boost(void *arg) unsigned long endtime; unsigned long oldstarttime; struct rcu_boost_inflight rbi = { .inflight = 0 }; - struct sched_param sp; VERBOSE_TOROUT_STRING("rcu_torture_boost started"); /* Set real-time priority. */ - sp.sched_priority = 1; - if (sched_setscheduler(current, SCHED_FIFO, &sp) < 0) { + if (sched_set_fifo_low(current) < 0) { VERBOSE_TOROUT_STRING("rcu_torture_boost RT prio failed!"); n_rcu_torture_boost_rterror++; }