Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp642174ybz; Wed, 22 Apr 2020 05:20:39 -0700 (PDT) X-Google-Smtp-Source: APiQypKHPmA3RRGEsSHo3hQesVGzY+Td5aAAIWA/DMmY5x5xAhdZaBrx28glDrY7Fvip+mF1q9ry X-Received: by 2002:a17:906:1b57:: with SMTP id p23mr26052886ejg.345.1587558038834; Wed, 22 Apr 2020 05:20:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1587558038; cv=none; d=google.com; s=arc-20160816; b=jZ9k2rb9v9Y1ATbTfcPPG4K8WkBHmtDhd7Rbu6gcxNLTVed4EPLlKdQ7VVlb9c5qqU p7J15CKzcLbae3+27hRofBzwE8xM4zlg6e5NXu2NEfevLwicy1TH0dPMZkNseszlUxkW adbuG7Dnzl70ImAOC3tPxr5PBM4AQaMgCpsZ6UIFu4/JcWt+oCiQc4aF7nXUL6YVL841 AF2nWY65xDkgS7OYoGBLRZpLdEhLlOURpLi/0LR15swTw3XewG9kBhFpfkDUHvy2sq9M FCOZz35ErdCfw6DZlC8EBcsIVtMlVxZVIHmbKrhlwtTkZLm5xUfX6yeqjyJF0IKwY8cg YSSA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=H2/6sfE/2uiuDzNRmzy/abb52VvzL0iR4+kk68gzsCQ=; b=xUznT2DHNyjG+rbhJCIDR2qtOikUZQsO1Fm1Sn4xQ5f8rY1MXOhq1rQ5PUzfvuwtMl XdioWbBTyj+LjgESgUr8NQPpFxxJksfhpn74K1lLHOIlihyNS4KRVhOfwmQ0okZjb+41 WcYZXsfLILY/WOYjqpqBotDjUdhDT3R2Kv8RVgFxJqq9s4tAF9UKDto3C94LXucKx5B2 KyztpiYUgpqdoqD+9JL5aXKpGMctZVofv3U5V75JogKfNXs+3vz0roQa758HxdgSBWdG s1YQWTGmAEWS/x1875bkpw/sgsHhXobWJdXNfOZ6RP4KtJ2JQYU6If4E37MCKGMB8dno M48g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=OmrcXvI6; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id va12si3575991ejb.227.2020.04.22.05.20.14; Wed, 22 Apr 2020 05:20:38 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=OmrcXvI6; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728836AbgDVKJO (ORCPT + 99 others); Wed, 22 Apr 2020 06:09:14 -0400 Received: from mail.kernel.org ([198.145.29.99]:35606 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728824AbgDVKJL (ORCPT ); Wed, 22 Apr 2020 06:09:11 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 13C0C2071E; Wed, 22 Apr 2020 10:09:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1587550150; bh=7Wrp0PSfQ8AxYH33MglpUgdu3eVad235QHlg9qT66K0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=OmrcXvI685Sv5862kRIOO34mcG2A3CqHsdkX+1DYH8N3wrzT7M2jERJgIvWN2A5JI dFIAVRFuetTFEYrSw1Dvj5DuJn4a2rVW3EeyIf2yv2Pdt9KFuTSJsvQohWcj4PXuRL 7PEL7AEUlrjQdUgr8//Ph57YZNumewL+zVG+zn+g= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Paul Menzel , Bob Liu , Konstantin Khlebnikov , Song Liu , Sasha Levin Subject: [PATCH 4.14 012/199] block: keep bdi->io_pages in sync with max_sectors_kb for stacked devices Date: Wed, 22 Apr 2020 11:55:38 +0200 Message-Id: <20200422095059.423991176@linuxfoundation.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200422095057.806111593@linuxfoundation.org> References: <20200422095057.806111593@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Konstantin Khlebnikov [ Upstream commit e74d93e96d721c4297f2a900ad0191890d2fc2b0 ] Field bdi->io_pages added in commit 9491ae4aade6 ("mm: don't cap request size based on read-ahead setting") removes unneeded split of read requests. Stacked drivers do not call blk_queue_max_hw_sectors(). Instead they set limits of their devices by blk_set_stacking_limits() + disk_stack_limits(). Field bio->io_pages stays zero until user set max_sectors_kb via sysfs. This patch updates io_pages after merging limits in disk_stack_limits(). Commit c6d6e9b0f6b4 ("dm: do not allow readahead to limit IO size") fixed the same problem for device-mapper devices, this one fixes MD RAIDs. Fixes: 9491ae4aade6 ("mm: don't cap request size based on read-ahead setting") Reviewed-by: Paul Menzel Reviewed-by: Bob Liu Signed-off-by: Konstantin Khlebnikov Signed-off-by: Song Liu Signed-off-by: Sasha Levin --- block/blk-settings.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/block/blk-settings.c b/block/blk-settings.c index 6c2faaa38cc1e..e0a744921ed3d 100644 --- a/block/blk-settings.c +++ b/block/blk-settings.c @@ -717,6 +717,9 @@ void disk_stack_limits(struct gendisk *disk, struct block_device *bdev, printk(KERN_NOTICE "%s: Warning: Device %s is misaligned\n", top, bottom); } + + t->backing_dev_info->io_pages = + t->limits.max_sectors >> (PAGE_SHIFT - 9); } EXPORT_SYMBOL(disk_stack_limits); -- 2.20.1