Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp642215ybz; Wed, 22 Apr 2020 05:20:41 -0700 (PDT) X-Google-Smtp-Source: APiQypJXooEtYse6eHqHBnc1S8l0oMIe8geO61Y3zSQQ1e9hh0ZAxq87S5ZHx5n08ObBcl5jxRRR X-Received: by 2002:aa7:d342:: with SMTP id m2mr1831559edr.341.1587558041397; Wed, 22 Apr 2020 05:20:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1587558041; cv=none; d=google.com; s=arc-20160816; b=Ys3mWzNBXXZ9F5JwHHl5VpQsu8nwkndrE+yQkCVUoNKsEvxQ/phKySyhiDHVuZy82b 9HWVG87UCmkkzEGDplw7pINN9vFcfHCN4H8X9qUlEOIGObK3JlNNd8OPmas6TiHwn29Z am8CedvJ8L4xwRIUh1yxRNhWjjWZGmvD8PSfwy6URiZK9IpZKoR5aSjGBn42iKoIN1aj KMgBb+ui7ziYe+TrZaZeH0BB0oRDvQP4rRuEu/hoGpz3v9OC16l7zefn1+bFL1JWSJ+a 8dJWCODN8Dge3LTA324EJ8NjzO40iW+AcSdLk9pYOmqxYFwjB2xSRKlUa+XSZDKhqlAt vArw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=HN/L9xl2qtpCDpx6Yklzjxkruv77LWGvj/Ec+sd2Tjk=; b=uQkH8F6/mnHZ2lL+QEVj1cwpftyYCXlNppSAie8/CnGhJWJrJY9V0mNHAtxavASABc SPWc1p5tBsG5LPlqm0VFZ0Xb2taV7NvqYyVMY45reVHF2f05sGFjmu3Fsj8iXlo52pcH 7lgyB6mcaMJJlTqCjbcqBI3j5G8bgfrnKVDfCQ6b6DY9GZTFLWRuYNqGji9y4pI/d26T EQz9Px7OiJ7QFDKHdUal5SHYp8Tud0M0xvvEEuzxqTq7skPlsKTQ5VZbvJZMpy30I02i fKFzCplsw85lzZiMRzBY6XNXaF5ZttnVQl3y2xmMTMLJMNb2d753C6FXr5OjROSry+Yb 9X/w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=i3JqBX7z; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id m4si3587237ejc.103.2020.04.22.05.20.16; Wed, 22 Apr 2020 05:20:41 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=i3JqBX7z; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729153AbgDVKLK (ORCPT + 99 others); Wed, 22 Apr 2020 06:11:10 -0400 Received: from mail.kernel.org ([198.145.29.99]:42108 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729143AbgDVKLF (ORCPT ); Wed, 22 Apr 2020 06:11:05 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 31A432075A; Wed, 22 Apr 2020 10:11:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1587550265; bh=N5J9ZYL1hq7IPOPZg5qQPF4MWiEvJy7wIJMDw9IxfVI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=i3JqBX7zJ6PIn2x5uWmLdh4TloleuI/avZAVx5d6qhE5AXqsKvRsnahVy7RDMo17u Akg/X/2ND78qe7se5zEeArzRdF7f5psE5PbHQx32Aw/BcG/jU3/sRTWpg/cvU9e07A XgfoytA0Khl+sqJq+MO6vQt4ofCQEUwMWLT0lBqc= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Trond Myklebust Subject: [PATCH 4.14 076/199] NFS: Fix a page leak in nfs_destroy_unlinked_subrequests() Date: Wed, 22 Apr 2020 11:56:42 +0200 Message-Id: <20200422095105.739175307@linuxfoundation.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200422095057.806111593@linuxfoundation.org> References: <20200422095057.806111593@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Trond Myklebust commit add42de31721fa29ed77a7ce388674d69f9d31a4 upstream. When we detach a subrequest from the list, we must also release the reference it holds to the parent. Fixes: 5b2b5187fa85 ("NFS: Fix nfs_page_group_destroy() and nfs_lock_and_join_requests() race cases") Cc: stable@vger.kernel.org # v4.14+ Signed-off-by: Trond Myklebust Signed-off-by: Greg Kroah-Hartman --- fs/nfs/write.c | 1 + 1 file changed, 1 insertion(+) --- a/fs/nfs/write.c +++ b/fs/nfs/write.c @@ -422,6 +422,7 @@ nfs_destroy_unlinked_subrequests(struct } subreq->wb_head = subreq; + nfs_release_request(old_head); if (test_and_clear_bit(PG_INODE_REF, &subreq->wb_flags)) { nfs_release_request(subreq);