Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp643056ybz; Wed, 22 Apr 2020 05:21:37 -0700 (PDT) X-Google-Smtp-Source: APiQypK89hQuhk4KHRvBxFnkQ5sOC9F2AoaJHr8XUo+v6HZv6MGzCHxBPFXP2EY+IryeJV4NLayQ X-Received: by 2002:aa7:db41:: with SMTP id n1mr9101340edt.314.1587558096865; Wed, 22 Apr 2020 05:21:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1587558096; cv=none; d=google.com; s=arc-20160816; b=ms9jZ0XDV9Sz7pSXc2RPJMdG/CzctTe4vpnxEQsg0wwF3Wfgu26v9jfujn6m6KiRBT ydtkI35GejhYMC3qEGUHoSB1s/KiPQXlH8Qx3GwqRL5BKlgQiuL8aveDguKMXGdgd2Ob bSEeyw9ZaHa0apgSx+DEdEjg3eTdBJt1DFX/n+XejDC1kF1QZSOJGrEwhPpnmYrHdLmo N6dnvTltPSEFtR4URXRE+8nHeNexBw7h9Da22oYLuO3oi5B6yUEnrZhdi/EVOYDHEsdo JDlRQEPHowuOasiOFf8pMapgEAjCVyxIgbjITa0pjLrSlByABgywDoXgtTGXIzw+VafA zwVg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=c9/V/6oRSlgIA4zRytOoF3D6DED5OULll5Zm3Cvzpsw=; b=bBZilsxBbxmUZvmIcWE40v/HEQWD+SPsbnj2p63J3G7zZtzOU6UDErb+MpjzoluJyO Hut+J97TqDyoZUMvhdsqCqJ45nrtrPmnpmai7wzMxCGwWp0mDiKsD/RUOcuDsJK/QjnQ fpfUrp/pl5BxJJD7s5NpBO9xWwpLD5vVHFjgz2CAGVAoUhNhbACoJ+8iK144+32YrqR9 KSgx3tnHw0rdEXu/zsa3YfEO7othoMv4MKDrzuwZrAM7PYU1sObX77+ISqk7OS1LN+YS a9URPveMYxEANB6qRKwmailoBDFObCC18INHNXcq3w15DIwIt3AA7sH/m6/JHdolnZnG FfFw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="G5b/Sp0H"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id os28si2777681ejb.98.2020.04.22.05.21.14; Wed, 22 Apr 2020 05:21:36 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="G5b/Sp0H"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730326AbgDVKXW (ORCPT + 99 others); Wed, 22 Apr 2020 06:23:22 -0400 Received: from mail.kernel.org ([198.145.29.99]:59468 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730273AbgDVKXD (ORCPT ); Wed, 22 Apr 2020 06:23:03 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 4BB3C215A4; Wed, 22 Apr 2020 10:23:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1587550982; bh=Pk3LH+KtmLOnF31lo8mARZysIUUWRRZBhV3Ch4KKeVI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=G5b/Sp0HBiqzYEj/YvJyVZ8Xtq6vOXidOAPO1ixEIFTDZoKh+1kGJBhcldZt8S74B GmKEJbtJbhIoQPw7lTwC6LrEjR22J0ygj2Pi+9pXdxVHT7wHXjXBcATLgwbyJZwdw4 LrSWYsGLlf8o3aaoj7xjdKl6+6SAISTWXIobIMlY= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Chao Yu , Jaegeuk Kim , Sasha Levin Subject: [PATCH 5.6 052/166] f2fs: fix to avoid use-after-free in f2fs_write_multi_pages() Date: Wed, 22 Apr 2020 11:56:19 +0200 Message-Id: <20200422095054.595424518@linuxfoundation.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200422095047.669225321@linuxfoundation.org> References: <20200422095047.669225321@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Chao Yu [ Upstream commit 95978caa138948054e06d00bfc3432b518699f1b ] In compress cluster, if physical block number is less than logic page number, race condition will cause use-after-free issue as described below: - f2fs_write_compressed_pages - fio.page = cic->rpages[0]; - f2fs_outplace_write_data - f2fs_compress_write_end_io - kfree(cic->rpages); - kfree(cic); - fio.page = cic->rpages[1]; f2fs_write_multi_pages+0xfd0/0x1a98 f2fs_write_data_pages+0x74c/0xb5c do_writepages+0x64/0x108 __writeback_single_inode+0xdc/0x4b8 writeback_sb_inodes+0x4d0/0xa68 __writeback_inodes_wb+0x88/0x178 wb_writeback+0x1f0/0x424 wb_workfn+0x2f4/0x574 process_one_work+0x210/0x48c worker_thread+0x2e8/0x44c kthread+0x110/0x120 ret_from_fork+0x10/0x18 Fixes: 4c8ff7095bef ("f2fs: support data compression") Signed-off-by: Chao Yu Signed-off-by: Jaegeuk Kim Signed-off-by: Sasha Levin --- fs/f2fs/compress.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/f2fs/compress.c b/fs/f2fs/compress.c index c847523ab4a2e..927db1205bd81 100644 --- a/fs/f2fs/compress.c +++ b/fs/f2fs/compress.c @@ -845,7 +845,7 @@ static int f2fs_write_compressed_pages(struct compress_ctx *cc, blkaddr = datablock_addr(dn.inode, dn.node_page, dn.ofs_in_node); - fio.page = cic->rpages[i]; + fio.page = cc->rpages[i]; fio.old_blkaddr = blkaddr; /* cluster header */ -- 2.20.1