Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp643818ybz; Wed, 22 Apr 2020 05:22:26 -0700 (PDT) X-Google-Smtp-Source: APiQypI4MaoXKXhgQNaW3rhaJedLR4cLcPXBr+8XZnz+QhSUwCVxUBqzya9Ok//b5MvKb8okKoy8 X-Received: by 2002:a17:906:7f0c:: with SMTP id d12mr25414213ejr.40.1587558146012; Wed, 22 Apr 2020 05:22:26 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1587558146; cv=none; d=google.com; s=arc-20160816; b=wFMNrdhza893vYDHA1vgoMDVr6fJ6BNIZwcz8EwNG+qEvRifsilPXCIFmLqEKy0rDG QAhQGMIK8gNOIfYZatt/j3UpI/9LZP1KYbGjftgXjCsnxH6dmT8e2hAxGxA+9xWqrUx+ Qt+VXFVEniSzBHWSlmcA6ybPq95jVw34CxYsu6JmNAYyhKvqNEwV7OVY+f5SE8E2vKyS oWRDchs7rrKQobnFaXAVkyy04uiBt8hY/9U15npAABERbVA2yasP9NsDQ/HSAMancyjA k69NHk3eTC7SCzFZGCrQGJQsH8AP/1J3LbKNiWu40KVVWAUL5Jj4+Bq5hL8EzWPzifsR f0FA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=Q90xNbTGa4prKVkdmy/tBDgdlFxzKhyadfOs9MkmQHU=; b=FCo4y9tUcSUvxUwcLYJfxnK1XUe9/5Ax3/5q3HYKlDVLGbCoUQH/wXphiSpFhz7k81 OjY8odWWtfwTdgsUvAQfJaulHQzfURgSKRYBTAmwNbfiuK3dK0TWGffEZY8nCgEle+zH j9CKfmtiJoWAeJe6ZQHHLOLgpZFUZ6EKU4WkQ1j5P6e/+W25/SmonH+QdOloTcTPUo41 0GB0fMzM83oXX0I/CPeZhudsg2cX39Pa/dMKtK2jmZOy4I8ywtCwO/0eBS37GmiZrasJ HVwE9vc3nGPK6INnP/iDrG2bDQvxc/aMpwUumxK7rvxNryM0Ra8bmi1OnOgxso7csPNo AdRg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=LyJ500Fo; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id w21si3053411ejz.276.2020.04.22.05.22.03; Wed, 22 Apr 2020 05:22:25 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=LyJ500Fo; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731011AbgDVKb5 (ORCPT + 99 others); Wed, 22 Apr 2020 06:31:57 -0400 Received: from mail.kernel.org ([198.145.29.99]:34282 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729243AbgDVKZi (ORCPT ); Wed, 22 Apr 2020 06:25:38 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id BFCB72071E; Wed, 22 Apr 2020 10:25:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1587551138; bh=0mz/Y/XDqS62jM3Y3+Il9l69KDQU3zU3El4aqkaNenE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=LyJ500Fo2u4+L2PbSUJjIxM6weeQFxK73yf2FUY/aOQC5MELdfOTitJXyYY2nOMv9 TqCMxjSy3GYRLKbPY/W5ley0Pk7POAAmjUb5qye1TsVYW5CAoTJ1M6vA+1vaJl3Qiz 5QiMgDjXsBK6WnS/gceSsm5qgqCfYWAcx70eNYoE= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Murphy Zhou , Trond Myklebust , Sasha Levin Subject: [PATCH 5.6 073/166] NFSv4.2: error out when relink swapfile Date: Wed, 22 Apr 2020 11:56:40 +0200 Message-Id: <20200422095056.710030751@linuxfoundation.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200422095047.669225321@linuxfoundation.org> References: <20200422095047.669225321@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Murphy Zhou [ Upstream commit f5fdf1243fb750598b46305dd03c553949cfa14f ] This fixes xfstests generic/356 failure on NFSv4.2. Signed-off-by: Murphy Zhou Signed-off-by: Trond Myklebust Signed-off-by: Sasha Levin --- fs/nfs/nfs4file.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/fs/nfs/nfs4file.c b/fs/nfs/nfs4file.c index 1297919e0fce3..8e5d6223ddd35 100644 --- a/fs/nfs/nfs4file.c +++ b/fs/nfs/nfs4file.c @@ -252,6 +252,9 @@ static loff_t nfs42_remap_file_range(struct file *src_file, loff_t src_off, if (remap_flags & ~REMAP_FILE_ADVISORY) return -EINVAL; + if (IS_SWAPFILE(dst_inode) || IS_SWAPFILE(src_inode)) + return -ETXTBSY; + /* check alignment w.r.t. clone_blksize */ ret = -EINVAL; if (bs) { -- 2.20.1