Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20200416114256.226329-1-elver@google.com> <alpine.LRH.2.21.2004171103160.32364@localhost>
In-Reply-To: <alpine.LRH.2.21.2004171103160.32364@localhost>
From:   Marco Elver <elver@google.com>
Date:   Wed, 22 Apr 2020 13:05:39 +0200
Message-ID: <CANpmjNNsSX+C1oXezj+WuW-DQpGJ2ETvqH6n6XryVwmKB0phxw@mail.gmail.com>
Subject: Re: [PATCH] kunit: Add missing newline in summary message
To:     Alan Maguire <alan.maguire@oracle.com>
Cc:     LKML <linux-kernel@vger.kernel.org>,
        Brendan Higgins <brendanhiggins@google.com>,
        linux-kselftest@vger.kernel.org, kunit-dev@googlegroups.com,
        frank.rowand@sony.com, skhan@linuxfoundation.org
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Fri, 17 Apr 2020 at 12:03, Alan Maguire <alan.maguire@oracle.com> wrote:
>
> On Thu, 16 Apr 2020, Marco Elver wrote:
>
> > Add missing newline, as otherwise flushing of the final summary message
> > to the console log can be delayed.
> >
> > Fixes: e2219db280e3 ("kunit: add debugfs /sys/kernel/debug/kunit/<suite>/results display")
> > Signed-off-by: Marco Elver <elver@google.com>
>
> Reviewed-by: Alan Maguire <alan.maguire@oracle.com>
>
> Thanks for finding/fixing this!
>
> Alan
>
> > ---
> >  lib/kunit/test.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)

Which tree will pick this up? I cannot yet see this in -next.

Thanks,
-- Marco


> > diff --git a/lib/kunit/test.c b/lib/kunit/test.c
> > index 7a6430a7fca0..ccb2ffad8dcf 100644
> > --- a/lib/kunit/test.c
> > +++ b/lib/kunit/test.c
> > @@ -93,7 +93,7 @@ static void kunit_print_ok_not_ok(void *test_or_suite,
> >        * representation.
> >        */
> >       if (suite)
> > -             pr_info("%s %zd - %s",
> > +             pr_info("%s %zd - %s\n",
> >                       kunit_status_to_string(is_ok),
> >                       test_number, description);
> >       else
> > --
> > 2.26.1.301.g55bc3eb7cb9-goog
> >
> >