Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750776AbWCDBkn (ORCPT ); Fri, 3 Mar 2006 20:40:43 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1750895AbWCDBkm (ORCPT ); Fri, 3 Mar 2006 20:40:42 -0500 Received: from dsl027-180-168.sfo1.dsl.speakeasy.net ([216.27.180.168]:42660 "EHLO sunset.davemloft.net") by vger.kernel.org with ESMTP id S1750882AbWCDBkm (ORCPT ); Fri, 3 Mar 2006 20:40:42 -0500 Date: Fri, 03 Mar 2006 17:40:48 -0800 (PST) Message-Id: <20060303.174048.14793187.davem@davemloft.net> To: christopher.leech@intel.com Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH 1/8] [I/OAT] DMA memcpy subsystem From: "David S. Miller" In-Reply-To: <20060303214220.11908.75517.stgit@gitlost.site> References: <20060303214036.11908.10499.stgit@gitlost.site> <20060303214220.11908.75517.stgit@gitlost.site> X-Mailer: Mew version 4.2.53 on Emacs 21.4 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 759 Lines: 31 From: Chris Leech Date: Fri, 03 Mar 2006 13:42:20 -0800 > +static spinlock_t dma_list_lock; Please use DEFINE_SPINLOCK(). > +static void dma_chan_free_rcu(struct rcu_head *rcu) { Newline before the brace please. > +static void dma_async_device_cleanup(struct kref *kref) { Newline before the brace please. > +struct dma_chan_percpu > +{ Left brace on the same line as "struct dma_chan_percpu" please. > +struct dma_chan > +{ Similarly. Otherwise this patch looks mostly ok. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/