Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp770609ybz; Wed, 22 Apr 2020 07:42:56 -0700 (PDT) X-Google-Smtp-Source: APiQypIoiNomKsaqvdNZJxaI5l6meHcObiDE+XjrsHWSj5ujDl8d1JMz/XDfT7ER+/uor2jiwmIl X-Received: by 2002:a17:906:1d4c:: with SMTP id o12mr20690545ejh.357.1587566576154; Wed, 22 Apr 2020 07:42:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1587566576; cv=none; d=google.com; s=arc-20160816; b=iFxE6QwsugQO5hyraFfydHS41JUSqyAcyVjToN3L1woQnyiBBBIFg+oBAorRET9CGI IlC5jJomBEuiohqy5aEJJSN6PAqzl8OnzLRQjVhm5ewlnxN0RtNQq526QoQ3HHyW8q0P JsuhasClBG8VZ8iyK4Yhk+htSg7g1KNN/wiudqAy9laQGVdmIhac/vf8cS65oawUcugk gNYT54SwlYf8mTfShU+mjrot4BI5xb4bNAWm6wlcPle0yd1UisvJnzwY7Je7+6QI5RVq /L0juALW/cnCtwyAoQrx2d7h5ddKJltgaAezJKcFzO9KY78lbfAOOnLaUl+Gx3anud+6 HkgA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :ironport-sdr:ironport-sdr; bh=mkp3FA+egu/Qi8bFdTnG0DAk9G4ktTyak/updYftg2w=; b=O9QZ+hReENthk00R9L55iL4BdcNOkbqMIyQAMuT4bywvhJeeVP5x98KF51K/VoAr0H 3KuTaSl9U10XH7CUge57c3RRAPoTz/ytKZl7nNpSkW6jwyNyMhR/fKxCTVrpn+ixfX4W ATIsJZK+3nr8y2lX8y9aAmUwiOst7J7sqFfcPYFrDjzfW01gO4ejsM9UwxEWgECGB14w PqTcMiduje4I5sBl685kZceJVy/7Bh4hB31/b45+1Zv6XXxXJkzV6EBaVnqWf6YlwCv9 t1MvRxxwGEQxJaiBKUW3XUm/MPMgFoHze6XpJKqHMbv5svPivxajfqcxVugXvPz4nrjC YsGw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id ci25si3782739ejb.476.2020.04.22.07.42.28; Wed, 22 Apr 2020 07:42:56 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726071AbgDVOil (ORCPT + 99 others); Wed, 22 Apr 2020 10:38:41 -0400 Received: from mga04.intel.com ([192.55.52.120]:24155 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725934AbgDVOik (ORCPT ); Wed, 22 Apr 2020 10:38:40 -0400 IronPort-SDR: M0ff1S6lzAn0NKw939+TuIVhoikW3vPWbVmw16vel+aEsq5GKlPy5sBkznGQpen4J5Yns8UIzp DdMIawgO4c1Q== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Apr 2020 07:38:40 -0700 IronPort-SDR: N1APEwHTnT18ajiIph6Dp451Pq+/HFeago4+E1KDsDOHQbPIYVQ+DwLgO0X2goDYXFbGuezuSP BLZc/EIBFXQw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.72,414,1580803200"; d="scan'208";a="245990894" Received: from tassilo.jf.intel.com (HELO tassilo.localdomain) ([10.7.201.21]) by fmsmga007.fm.intel.com with ESMTP; 22 Apr 2020 07:38:40 -0700 Received: by tassilo.localdomain (Postfix, from userid 1000) id 1A1663019B5; Wed, 22 Apr 2020 07:38:40 -0700 (PDT) Date: Wed, 22 Apr 2020 07:38:40 -0700 From: Andi Kleen To: Ian Rogers Cc: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Kan Liang , Haiyan Song , Jin Yao , Ravi Bangoria , John Garry , Leo Yan , Adrian Hunter , linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, Stephane Eranian Subject: Re: [PATCH 2/8] perf metrics: fix parse errors in cascade lake metrics Message-ID: <20200422143840.GJ608746@tassilo.jf.intel.com> References: <20200422074809.160248-1-irogers@google.com> <20200422074809.160248-3-irogers@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200422074809.160248-3-irogers@google.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Apr 22, 2020 at 12:48:03AM -0700, Ian Rogers wrote: > Remove over escaping with \\. > Remove extraneous if 1 if 0 == 1 else 0 else 0. So where do these parse errors happen exactly? Some earlier patches introduced them as regressions? The original metrics worked without parse errors as far as I know. If it fixes something earlier it would need Fixes: tags. -Andi