Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Content-Type: text/plain;
        charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.14\))
Subject: Re: [v2] arm64: dts: meson: odroid-n2: extend cpu opp-points
From:   Christian Hewitt <christianshewitt@gmail.com>
In-Reply-To: <20200418214223.GA4484@imac>
Date:   Wed, 22 Apr 2020 18:54:21 +0400
Cc:     Neil Armstrong <narmstrong@baylibre.com>, khilman@baylibre.com,
        joy.cho@hardkernel.com, tobetter@gmail.com,
        linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
        mark.rutland@arm.com, robh+dt@kernel.org
Content-Transfer-Encoding: quoted-printable
Message-Id: <52230ECA-EA47-499D-B71C-FFCD374B75C3@gmail.com>
References: <20200418214223.GA4484@imac>
To:     Tim Lewis <elatllat@gmail.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


> On 19 Apr 2020, at 1:42 am, Tim Lewis <elatllat@gmail.com> wrote:
>=20
> Odroid N2 has a large heatsink and HardKernel supports overclock
> through the addition to extra opp points in their official kernel
> sources [1]. Add these to the N2 dts only, as other S922X devices
> may not have suitable heatsinks.
>=20
> [1] =
https://github.com/hardkernel/linux/commit/f86cd9487c7483b2a05f448b9ebacf6=
bd5a2ad2f
> Signed-off-by: Tim Lewis <elatllat@gmail.com>

Kodi is not a demanding workload, but the extra opp points are being =
used:

N2:~ # cat /sys/devices/system/cpu/cpufreq/policy0/stats/trans_table=20
   =46rom  :    To
         :    100000    250000    500000    667000   1000000   1200000   =
1398000   1512000   1608000   1704000   1896000   1992000=20
   100000:         0     20465       294        81        47         0   =
      1         0         0         0         0       183=20
   250000:     20388         0       161        52        59         0   =
      0         0         1         0         1       169=20
   500000:       199       256         0         9        47         1   =
      2         0         0         0         0        57=20
   667000:       177        50        10         0       284         1   =
      1         0         0         0         0       136=20
  1000000:       230        12        15       284         0         1   =
      2         0         0         0         0       285=20
  1200000:         0         0         0         1         0         0   =
      0         0         0         1         0         2=20
  1398000:         1         1         0         2         0         0   =
      0         0         1         1         0         3=20
  1512000:         0         0         0         0         0         0   =
      0         0         0         1         0         2=20
  1608000:         0         0         0         0         0         0   =
      0         1         0         0         0         2=20
  1704000:         0         1         0         0         0         0   =
      1         0         0         0         0         2=20
  1896000:         0         0         1         0         0         0   =
      0         0         0         0         0         1=20
  1992000:        76        47        90       230       392         0   =
      2         2         1         1         1         0=20

N2:~ # cat /sys/devices/system/cpu/cpufreq/policy2/stats/trans_table=20
   =46rom  :    To
         :    100000    250000    500000    667000   1000000   1200000   =
1398000   1512000   1608000   1704000   1800000   1908000=20
   100000:         0      1698       130        76        87         0   =
      0         0         1         0         1       199=20
   250000:      1655         0        25        15       357         1   =
      2         0         1         0         0        12=20
   500000:       258        54         0     50102        30         3   =
      1         0         0         0         1        32=20
   667000:       267       151     49708         0        77         3   =
      0         0         0         0         0        11=20
  1000000:         3         5       525        15         0         3   =
      2         0         1         1         0         6=20
  1200000:         0         2         1         2         2         0   =
      3         0         0         0         1         4=20
  1398000:         1         0         1         1         4         0   =
      0         1         1         0         2         2=20
  1512000:         0         0         0         0         0         0   =
      1         0         0         0         0         1=20
  1608000:         1         0         0         1         0         1   =
      0         0         0         0         0         3=20
  1704000:         0         0         0         0         0         1   =
      0         1         0         0         0         1=20
  1800000:         0         0         1         1         0         0   =
      1         0         1         0         0         1=20
  1908000:         8       158        90         4         3         3   =
      3         0         1         2         0         0=20

Board boots in under 4 seconds, Kodi home-screen in about 7 seconds. I =
haven=E2=80=99t seen the N2 rise over 44=C2=BAC.

I=E2=80=99ve also tested some S922X box devices (moving the change to =
meson-g12b-s922x.dtsi) and no obvious issues.

Tested-by: Christian Hewitt <christianshewitt@gmail.com>

> ---
> .../boot/dts/amlogic/meson-g12b-odroid-n2.dts | 19 +++++++++++++++++++
> 1 file changed, 19 insertions(+)
>=20
> diff --git a/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dts =
b/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dts
> index 42f154057..6f32ac83f 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dts
> +++ b/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dts
> @@ -260,6 +260,25 @@
> 			};
> 		};
> 	};
> +
> +	cpu_opp_table_0: opp-table-0 {
> +		opp-1992000000 {
> +			opp-hz =3D /bits/ 64 <1992000000>;
> +			opp-microvolt =3D <1001000>;
> +		};
> +	};
> +
> +	cpub_opp_table_1: opp-table-1 {
> +		opp-1800000000 {
> +			opp-hz =3D /bits/ 64 <1800000000>;
> +			opp-microvolt =3D <981000>;
> +		};
> +
> +		opp-1908000000 {
> +			opp-hz =3D /bits/ 64 <1908000000>;
> +			opp-microvolt =3D <1022000>;
> +		};
> +	};
> };
>=20
> &arb {
> --=20
> 2.17.1
>=20