Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp800358ybz; Wed, 22 Apr 2020 08:13:40 -0700 (PDT) X-Google-Smtp-Source: APiQypKku5/WpVJJm8SCXccUh/rL8i6qQYyCZUWrFgpD8QXtpefZtl/b6M4nCSa+IGri6d9sX7Ib X-Received: by 2002:a17:907:435d:: with SMTP id oc21mr27289059ejb.100.1587568420040; Wed, 22 Apr 2020 08:13:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1587568420; cv=none; d=google.com; s=arc-20160816; b=FEy1tLnEcu7F9mxmqcikwUtO/hxl8POLE1/4Wwy+jU5WkETWjh5r5ZJoPndTCJhzzL 9xviT7RsagKrCird89Tc8wjgGKbYywrtIezJf1j/XZFA0WlOZ4dG+gHXxZvxka+7WN12 eoQy/bxnsbstoQHYd0fLmSemeR55BOqZwidAvz5Mo/15JsfWYOpQKt7zXEnyHHuUrVJx 9+MfxIRhRtwKOsiy618RCjetsPUEHxB4q7q5KqgGqDsIdOm5j7DH9mPhDqIrhfezIHks 6TufiOpbq3CRAfPKWLEjGcmTHZKYDLIQGJPHeR4zzTVRO1AwVWSxUdUECQZfDVBoC3Sv Wslg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from; bh=nlJK3Q1ssGD66kpU36th2KjLTt/lcxENz64PS2YWH1A=; b=jkJykh2Ln09Fvh7OzFIu9/tN3pfhnh6rIQciLD1OE/nJO9ck5cl2hlFR5fAVtnjAmS kWsn8k3MQmpAUOe8wbjP7xSs8+gjyFGHsOw2MCJfgfjS8wJrU/9kKGj0rOWL7NR5kfJb Iuywsk0Q2BDqAD6WyDcdCYvpdR3XIDwG0sfns0S4ScB5z5uRCsmN0/64/+wksfl67a0N hL8/P8hPeFuT0uTWQJ/1hQTUgJYEQQYpoGQPYXoFMH5yq8cwXmSi2Mqo/Mx2KyOgrVTr BraNdwxN6XSnc48KK+iJodaFU2WyxIi7Zff50aJtawo4Eyu2EEpt2ESBdGBQmVMSF7W7 C9tw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id q11si3683060eju.120.2020.04.22.08.13.06; Wed, 22 Apr 2020 08:13:40 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727800AbgDVPDG (ORCPT + 99 others); Wed, 22 Apr 2020 11:03:06 -0400 Received: from mx2.suse.de ([195.135.220.15]:57966 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725935AbgDVPDF (ORCPT ); Wed, 22 Apr 2020 11:03:05 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 159F4AC4D; Wed, 22 Apr 2020 15:03:03 +0000 (UTC) Received: by quack2.suse.cz (Postfix, from userid 1000) id 592C41E0B00; Wed, 22 Apr 2020 17:03:03 +0200 (CEST) From: Jan Kara To: Matthew Wilcox Cc: , LKML , Jan Kara Subject: [PATCH 01/23] xarray: Remove stale comment Date: Wed, 22 Apr 2020 17:02:34 +0200 Message-Id: <20200422150256.23473-2-jack@suse.cz> X-Mailer: git-send-email 2.16.4 In-Reply-To: <20200422150256.23473-1-jack@suse.cz> References: <20200422150256.23473-1-jack@suse.cz> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Since commit 7e934cf5ace1 "xarray: Fix early termination of xas_for_each_marked" the comment is no longer relevant since xas_for_each_marked() can cope with marked NULL entries. Remove the comment. Signed-off-by: Jan Kara --- lib/xarray.c | 7 ------- 1 file changed, 7 deletions(-) diff --git a/lib/xarray.c b/lib/xarray.c index e9e641d3c0c3..dae68dd13a02 100644 --- a/lib/xarray.c +++ b/lib/xarray.c @@ -803,13 +803,6 @@ void *xas_store(struct xa_state *xas, void *entry) xas_init_marks(xas); for (;;) { - /* - * Must clear the marks before setting the entry to NULL, - * otherwise xas_for_each_marked may find a NULL entry and - * stop early. rcu_assign_pointer contains a release barrier - * so the mark clearing will appear to happen before the - * entry is set to NULL. - */ rcu_assign_pointer(*slot, entry); if (xa_is_node(next) && (!node || node->shift)) xas_free_nodes(xas, xa_to_node(next)); -- 2.16.4