Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: EkJZ5xH3CsMZl2nxn0B62GL0E6bODK3BPqvEiXgJ0/W4T8wZfnrV7fiVaHw2HDeIZKS17phkdn
 yh1ragYfSqPQ==
IronPort-SDR: uacoHrS/75vy0fPWVfYZWr90WFuxiU1gdrPpxIteIEZyoAgjFdEtLcjloN+lDtgm0kwddB598v
 0XaXqF7klQ1Q==
Date:   Wed, 22 Apr 2020 18:44:02 +0300
From:   Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To:     Joe Perches <joe@perches.com>
Cc:     Andrew Morton <akpm@linux-foundation.org>,
        linux-kernel@vger.kernel.org, Steven Rostedt <rostedt@goodmis.org>,
        Rasmus Villemoes <linux@rasmusvillemoes.dk>,
        Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [PATCH v4 4/7] kernel.h: Split out min()/max() et al helpers
Message-ID: <20200422154402.GK185537@smile.fi.intel.com>
References: <20200422125201.37618-1-andriy.shevchenko@linux.intel.com>
 <20200422125201.37618-4-andriy.shevchenko@linux.intel.com>
 <5b413a379b8bba39fb75469699b7fd0d50d67e96.camel@perches.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <5b413a379b8bba39fb75469699b7fd0d50d67e96.camel@perches.com>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, Apr 22, 2020 at 07:52:32AM -0700, Joe Perches wrote:
> On Wed, 2020-04-22 at 15:51 +0300, Andy Shevchenko wrote:
> > kernel.h is being used as a dump for all kinds of stuff for a long time.
> > Here is the attempt to start cleaning it up by splitting out min()/max()
> > et al helpers.
> 
> While adding organization into kernel.h by splitting
> out various bits into separate files is a fine idea,
> I believe removing the generic #include <linux/kernel.h>
> from various files and substituting the sub-includes
> is not a good idea.

Are you sure?

> > At the same time convert users in header and lib folder to use new header.
> > Though for time being include new header back to kernel.h to avoid twisted
> > indirected includes for existing users.
> 
> Yeah, that's the difficult bit and it could make
> using precompiled headers very cumbersome.
> 
> I'd rather make #include <linux/kernel.h>" _more_
> common or even used as the mandatory first #include
> for all kernel .c files.

Huh?

Perhaps we may just cat include/linux/* > include/linux/kernel.h?

> That would also ensure that common kernel facilities
> are not duplicated or have naming conflicts with other
> files.

-- 
With Best Regards,
Andy Shevchenko