Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp831924ybz; Wed, 22 Apr 2020 08:46:00 -0700 (PDT) X-Google-Smtp-Source: APiQypLQFJZqO6psfm3m2KRMhb+aLMAxHoSWS63CDgo4bcO0+jhLMzz3yf7YJ95H2CyfV9yBMJ23 X-Received: by 2002:a05:6402:1768:: with SMTP id da8mr24175818edb.216.1587570360032; Wed, 22 Apr 2020 08:46:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1587570360; cv=none; d=google.com; s=arc-20160816; b=Vbz2qjxgfPPlKC1Ip4w1sriD3XIsvAXE6YiL9XwXHfFRztS0FXhe0NJAisJJSohEyS bm5JYMXrgTctR9P4YMKKCWtnnbyaZbStWbvnf8A62jxuk036bTKPX2IdnFZ4esKXyc8p voiUHU1dcFOvtv3tODviEV3LV5KZgBlnSWWZhXrdn7OvcCsQBTDiqT0BBEIXDix8rosT EUYsE2+D5VqBLX8KPg9NRSJ/yxbgEuJP4EZLJO9mcXSKqxmxBgD74ML8wGjCZmZFaeM3 /qPz/MgIG1kG4hxpRQnZq3ADsyi4BQsp0br0wyWWaJWmakKbxFHUWqJRTv7PGcUGQU4S o8cw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=d189Ht66WkNhS7qEev42XSV+pMJKpBQ+6wQXP4iX/B0=; b=hmHDt4HwbS4rX0UW7SyysiCWmJ/eSNIqdIua2cIiKwjLFayGdskjcjLoRtOVUAsMWi K68KiQiCoPT7hIk3nfRmHWbS6Vw1+/TvOYsD2PqRESA3bHjjWqXt8o878wBwjmzpcOXv SXg6P4AerIH9eaLhZsNdmKWggmHBXs59Q/eKlO95IJtgF25CVtl99NIXRQXne0KBqlt/ /PFW+VHMU53sar8pjwUWNQU7LrkcBFo4ej2ypTUHVNnM96Fhd1UDeW9LRlq7v3++6JBx bHZ9NbaEgZauTXoGq9rOMcQTxN3Ks83ezdS6RpCWI6s/Lv+eNkTvo8LdIY5JhkPYBRtX OdNw== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=nw4Xj1fY; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id l61si3579150ede.343.2020.04.22.08.45.37; Wed, 22 Apr 2020 08:46:00 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=nw4Xj1fY; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726651AbgDVPoG (ORCPT + 99 others); Wed, 22 Apr 2020 11:44:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57330 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726154AbgDVPoE (ORCPT ); Wed, 22 Apr 2020 11:44:04 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BB1F5C03C1A9; Wed, 22 Apr 2020 08:44:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=d189Ht66WkNhS7qEev42XSV+pMJKpBQ+6wQXP4iX/B0=; b=nw4Xj1fY4FG1c+4lbVWravMDJg FmJrQLxqg8GzrzqGIYlmpd4sbmocteJxuRA0UlFGIAtBEPVd8EtW0bO+XUYXYRGqoYWTkELYcq7Hk PiOmvar7kH7mjR6YHZlQIIEtCU3WK6WpmPL7AhpJ4kxkDAz4qoGMAoc677HYTMwbqm2+mXtbjI6bO EHSSg8CVovE2aDqNn3EGvysLCibViHIEs/7lXsfKT+1Y0ADQDs8wU6mWsqdT/ZR44ibgrGt87y0G3 T5VUBSvN8BIwJxipP0FAkplmTKSsCTDs/mUN5D9Fv6HicsQ2PmqoTca6GAbQZYAiUKDKA+kAGudKu /vf0E95w==; Received: from willy by bombadil.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1jRHXY-0001vC-BB; Wed, 22 Apr 2020 15:43:56 +0000 Date: Wed, 22 Apr 2020 08:43:56 -0700 From: Matthew Wilcox To: "Karstens, Nate" Cc: Alexander Viro , Jeff Layton , "J. Bruce Fields" , Arnd Bergmann , Richard Henderson , Ivan Kokshaysky , Matt Turner , "James E.J. Bottomley" , Helge Deller , "David S. Miller" , Jakub Kicinski , "linux-fsdevel@vger.kernel.org" , "linux-arch@vger.kernel.org" , "linux-alpha@vger.kernel.org" , "linux-parisc@vger.kernel.org" , "sparclinux@vger.kernel.org" , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" , David Laight , Changli Gao Subject: Re: [PATCH 1/4] fs: Implement close-on-fork Message-ID: <20200422154356.GU5820@bombadil.infradead.org> References: <20200420071548.62112-1-nate.karstens@garmin.com> <20200420071548.62112-2-nate.karstens@garmin.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Apr 22, 2020 at 03:36:09PM +0000, Karstens, Nate wrote: > There was some skepticism about whether our practice of > closing/reopening sockets was advisable. Regardless, it does expose what > I believe to be something that was overlooked in the forking process > model. We posted two solutions to the Austin Group defect tracker: I don't think it was "overlooked" at all. It's not safe to call system() from a threaded app. That's all. It's right there in the DESCRIPTION: The system() function need not be thread-safe. https://pubs.opengroup.org/onlinepubs/9699919799/functions/system.html > Ultimately the Austin Group felt that close-on-fork > was the preferred approach. I think it's also worth > pointing that out Solaris reportedly has this feature > (https://www.mail-archive.com/austin-group-l@opengroup.org/msg05359.html). I am perplexed that the Austin Group thought this was a good idea.