Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp1181384ybz; Wed, 22 Apr 2020 15:19:15 -0700 (PDT) X-Google-Smtp-Source: APiQypJpMudw5uDK72AheKDClRBfXhBqTP9fBWGsNjnV+DYYgjR0yZjyOnPLOKKr9dDl7SWJH8gH X-Received: by 2002:a50:de44:: with SMTP id a4mr661091edl.56.1587593955345; Wed, 22 Apr 2020 15:19:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1587593955; cv=none; d=google.com; s=arc-20160816; b=XL9h7MRMsh9t9kY4ydpLLp7+hqBwgbA4IWjH5Vg7H2Mif0Zs3dEgzxYQCwSDr8wiEN D0R41W9Hcz9CxpiZfS2/T43iiqYyGiMqRNW/fF0DO4GzSIGWyvIuhncbhjCJr/f6O+0l upu5ugR/R5PgVd6aLR5+TMOAUILbXNwUggsmTUSnw32fWGs0Hh88g1Vr8T2kbYhGpVud JHbjABRtGlSlvokeDn5q3ipSm+/aPFfw/IkpLeFskxuEFbj8CtCLvrUWSj3WDJijq1AP iHM4Ab/8WTnCOY2r6rvSon70vVla5RnOPzhnNDG9ZYejoaCX5iWdfY950f/rz5WK/ZX1 cCEA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=/cWGqNrwRUi86LXOam7nhjqgeV8uCuXewweugzrbGz8=; b=PeuBMCrNfVxryJT+o3SSSMFne0Jmg7aZullxnOolRGjEGhVh4mTzVyFgDOBpoBWv6W z8IYYS31yeyAOwya148puua71XDHH1LxCyN8mIqKOXqL5vXNkYeYnqnqOC+Z4GdCUXX9 UtAsCnLSk8ratr8uS/uB8AuJWdorZAguKqMX9ymg2Ow9OsJkzZ8BYm03Q8jOVshYorS0 lHDoqae4rzWhEGJqJOMWD/zFCgDAbl0j6COgvQsZEHoy5i/QfLb0F6IrxYoNEPtQy5sK 5Hg97Ntpr7mDBZZ88UWv5BidhdSPs+u5nem8W24EFciPLUaqNySej8JByM+h16SLy0Tc Me2g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=VKT9+XVY; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id d9si274481ejh.303.2020.04.22.15.18.52; Wed, 22 Apr 2020 15:19:15 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=VKT9+XVY; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726102AbgDVWRl (ORCPT + 99 others); Wed, 22 Apr 2020 18:17:41 -0400 Received: from us-smtp-2.mimecast.com ([207.211.31.81]:23920 "EHLO us-smtp-delivery-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725839AbgDVWRl (ORCPT ); Wed, 22 Apr 2020 18:17:41 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1587593860; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=/cWGqNrwRUi86LXOam7nhjqgeV8uCuXewweugzrbGz8=; b=VKT9+XVYc3p2IjIFY1s1c8qHarMS59nnmMNV4aRkqJpOefuYTfuQSyzRTp2smvB3kf05Mi KwHoSACQ/szmhvWwW/233qfqLMJOstUyaBGC5nx/mkkjeyIqLa6QW/xwZsCGGIyXjfwAM+ FDEv/LYiBFqtVCm7uJIYXIU7VL++2Ss= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-53-etYuuQxEORWvQuObNkoVTA-1; Wed, 22 Apr 2020 18:17:38 -0400 X-MC-Unique: etYuuQxEORWvQuObNkoVTA-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id E500E8017FD; Wed, 22 Apr 2020 22:17:35 +0000 (UTC) Received: from treble (unknown [10.10.115.243]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 4010460C87; Wed, 22 Apr 2020 22:17:34 +0000 (UTC) Date: Wed, 22 Apr 2020 17:17:32 -0500 From: Josh Poimboeuf To: Kristen Carlson Accardi Cc: keescook@chromium.org, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, hpa@zytor.com, Peter Zijlstra , arjan@linux.intel.com, x86@kernel.org, linux-kernel@vger.kernel.org, kernel-hardening@lists.openwall.com, rick.p.edgecomb@intel.com Subject: Re: [PATCH 1/9] objtool: do not assume order of parent/child functions Message-ID: <20200422221732.wmih73qrdh4fksog@treble> References: <20200415210452.27436-1-kristen@linux.intel.com> <20200415210452.27436-2-kristen@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20200415210452.27436-2-kristen@linux.intel.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Apr 15, 2020 at 02:04:43PM -0700, Kristen Carlson Accardi wrote: > If a .cold function is examined prior to it's parent, the link > to the parent/child function can be overwritten when the parent > is examined. Only update pfunc and cfunc if they were previously > nil to prevent this from happening. > > Signed-off-by: Kristen Carlson Accardi > Acked-by: Josh Poimboeuf Hi Kristen, I grabbed this one and it will be merged into the -tip tree soon. Thanks! -- Josh