Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 22 Apr 2020 16:40:06 -0700
From:   Andrey Ignatov <rdna@fb.com>
To:     Christoph Hellwig <hch@lst.de>
CC:     Kees Cook <keescook@chromium.org>,
        Iurii Zaikin <yzaikin@google.com>,
        Alexei Starovoitov <ast@kernel.org>,
        Daniel Borkmann <daniel@iogearbox.net>,
        <linux-kernel@vger.kernel.org>, <linux-mm@kvack.org>,
        <linux-fsdevel@vger.kernel.org>, <netdev@vger.kernel.org>,
        <bpf@vger.kernel.org>
Subject: Re: [PATCH 5/5] sysctl: pass kernel pointers to ->proc_handler
Message-ID: <20200422234006.GB6764@rdna-mbp.dhcp.thefacebook.com>
References: <20200421171539.288622-1-hch@lst.de>
 <20200421171539.288622-6-hch@lst.de>
 <20200421192330.GA60879@rdna-mbp.dhcp.thefacebook.com>
 <20200422172254.GA30102@lst.de>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20200422172254.GA30102@lst.de>
User-Agent: Mutt/1.12.1 (2019-06-15)
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from localhost (2620:10d:c090:400::5:1d4c) by CO1PR15CA0064.namprd15.prod.outlook.com (2603:10b6:101:1f::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2937.13 via Frontend Transport; Wed, 22 Apr 2020 23:40:08 +0000
X-Originating-IP: [2620:10d:c090:400::5:1d4c]
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 6a2905c4-6400-47ce-10b4-08d7e7167e2e
X-MS-TrafficTypeDiagnostic: BYAPR15MB3301:
X-Microsoft-Antispam-PRVS: <BYAPR15MB3301CD24A6134E195668AB13A8D20@BYAPR15MB3301.namprd15.prod.outlook.com>
X-FB-Source: Internal
X-MS-Oob-TLC-OOBClassifiers: OLM:8273;
X-Forefront-PRVS: 03818C953D
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR15MB4119.namprd15.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(10019020)(366004)(39860400002)(396003)(136003)(376002)(346002)(8676002)(4744005)(2906002)(4326008)(316002)(52116002)(81156014)(7416002)(9686003)(6486002)(86362001)(54906003)(478600001)(186003)(6496006)(16526019)(1076003)(6916009)(66946007)(8936002)(5660300002)(66476007)(33656002)(66556008);DIR:OUT;SFP:1102;
Received-SPF: None (protection.outlook.com: fb.com does not designate
 permitted sender hosts)
X-MS-Exchange-SenderADCheck: 1
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: zDj16FjdrmPhWxAo7//JMl43AKSs4pwDhjj6+sAUFm/YaCE3p7hpwj2EnJEImHyMEmOf/UXvOuMs6AnQO1qe2ECSQ4r8xwSu2xaXB604Oix9qV3+YxEyVZA4RZIIGBft8do3LnTPFL3UXH9NJxCrl0JvKVPBwjv4iYfvWtr+04cntaWUNOWz7j1lTTRqAlYlHE/Q4+72/bkWkQ2+cJdy0Ae6NXPt188WQ2hvDxce23+Kubg7b9cLQ+wbvKFLQAMUBnG+OAkhIsMo7ep7J7Dgv2JWrudd/PYq8awxeZi1aA44GuVraJM9HHolmdSKLdkz4vfGFwli3zm0bFVZUzhCcMGUreqvuPSkfm1/WufMok/Eg/H/SJT477yNJUkwzFF3ZneEzkHZWwRvV7RNNLwonU3uCnNvlJbCDMyxXLpLfUnFSLnN7sDCl3q8O8rlyDuZ
X-MS-Exchange-AntiSpam-MessageData: DWOlApBR7q4M5Ejl2po1W3gE3iu64rgEMXz2iKiZS0O2dA/i8beq7OV76nl3znh86UOfVCASMEKnmm2x13qv6BqoYfhpN16x1+mIIe3hFfWOPguBE7gJwpqQwGPYT8G06RekRPEsxdG9ZNPaj5Pjwmg/JiYxRYV6/YOidjn8aASXoStMWUhrJy3KYdNEPaLk
X-MS-Exchange-CrossTenant-Network-Message-Id: 6a2905c4-6400-47ce-10b4-08d7e7167e2e
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Apr 2020 23:40:08.9468
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 8ae927fe-1255-47a7-a2af-5f3a069daaa2
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: jW6Oj33P4FRKJsXyqeNpeXmdl+r1u9LltWiVdj9vjLxJnTPhflK6JdD1zciKsw5B
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR15MB3301
X-OriginatorOrg: fb.com
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.138,18.0.676
 definitions=2020-04-22_08:2020-04-22,2020-04-22 signatures=0
X-Proofpoint-Spam-Details: rule=fb_default_notspam policy=fb_default score=0 adultscore=0
 mlxlogscore=885 spamscore=0 impostorscore=0 lowpriorityscore=0
 priorityscore=1501 phishscore=0 clxscore=1015 suspectscore=0 bulkscore=0
 mlxscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2003020000 definitions=main-2004220181
X-FB-Internal: deliver
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Christoph Hellwig <hch@lst.de> [Wed, 2020-04-22 10:23 -0700]:
> On Tue, Apr 21, 2020 at 12:23:30PM -0700, Andrey Ignatov wrote:
> > >  	if (ret == 1 && ctx.new_updated) {
> > > -		*new_buf = ctx.new_val;
> > > +		*buf = ctx.new_val;
> > 
> > Original value of *buf should be freed before overriding it here
> > otherwise it's lost/leaked unless I missed something.
> > 
> > Other than this BPF part of this patch looks good to me. Feel free to
> > add my Ack on the next iteration with this fix.
> 
> Thanks, fixed.
> 
> Can you also comment on "bpf-cgroup: remove unused exports" ?

Sure, reviewed.

-- 
Andrey Ignatov